From: Will Deacon <will@kernel.org>
To: Aashish Sharma <aashish@aashishsharma.net>
Cc: Vineeth Pillai <vineeth@bitbyteword.org>,
Dmytro Maluka <dmaluka@google.com>,
Joerg Roedel <joro@8bytes.org>,
Robin Murphy <robin.murphy@arm.com>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
Aashish Sharma <shraash@google.com>
Subject: Re: [PATCH] iommu: Remove redundant null check in iommu_iotlb_gather_queued
Date: Mon, 24 Nov 2025 17:03:42 +0000 [thread overview]
Message-ID: <aSSP7sG0OMFGElS9@willie-the-truck> (raw)
In-Reply-To: <20251111051952.1985154-1-aashish@aashishsharma.net>
On Mon, Nov 10, 2025 at 09:19:52PM -0800, Aashish Sharma wrote:
> The callers of 'iommu_iotlb_gather_queued' always have a non-null
> 'gather', so we don't need to check for the same in the function.
That's not obviously true to me, how did you check it?
For example, msm_iommu_pagetable_unmap() appears to call into
io_pgtable_ops::unmap_pages() with a NULL gather pointer.
Will
next prev parent reply other threads:[~2025-11-24 17:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 5:19 Aashish Sharma
2025-11-24 17:03 ` Will Deacon [this message]
2025-11-24 17:16 ` Robin Murphy
2025-11-25 1:07 ` Aashish Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSSP7sG0OMFGElS9@willie-the-truck \
--to=will@kernel.org \
--cc=aashish@aashishsharma.net \
--cc=dmaluka@google.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=shraash@google.com \
--cc=vineeth@bitbyteword.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®