From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B53831A04E for ; Tue, 25 Nov 2025 12:10:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764072627; cv=none; b=j1V9e34Gc09BwORm3aZWDUhG+ObqyXH0vnw4xg503PgJM7aGjxfh5PZLgO2w2jBhEArZkjEhLd8XeHPgYDcmQRmTL15w/stHiOV5Px+QHSYB39oq1HYIJvyScSQvKjdHy9jFKudYzM6dlRjWSl/t6wqwr85rKTN/mXunF/YXaNU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764072627; c=relaxed/simple; bh=vc4ZcsBT3hancraizAwEboUrHxG2gb53cAJYp9rMBSM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QX69Z8ysCDiXZLREwB5eoKM+JuJRyDmc0qmYbaGI2TEokBuA3vEZB8Y4wK0scEj7IKHy4uH6jfpq5q9qVN5zhGhL05CaGVCxRA5ZNsOBl9J+9om4Ue0uDcxu6LLRCFldljAp+k30NaCmNfz6LY74urqt8pILoo6Lo6c6l7scH6U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=iGCBYswG; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iGCBYswG" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-42b3ad51fecso4342456f8f.1 for ; Tue, 25 Nov 2025 04:10:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764072624; x=1764677424; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=K2OO2QVScy6triwwM1Pq5PaJWVgHVZPdOO72BhX0Y1E=; b=iGCBYswGaFbojO1rd/+aw8B2Vhg6+K1cX4++TaWZNSTnqECmiXm5vbeIJps2Qr/QFl Nk+wQopBKkuTduBShSNacYGhNHyurQQDbbvWtlm/zq81PUhkrI8mjNiSV57OpjLsA5Rq CaVkHJcwb4Ew37cqAJxHwokpJBlhgvAd7OymzLtPEWefIWPbvUY9YCucEjGg9y/kXqXw muLl4SFS4FL//zZ0k0Qf14Faf9S/Hh+Xc8cU9PT8B8G/1BblaULoGOyCj7N6QulJ9RSt pjSn3RXAjxCIEz1oiVjBL0LkVYCYgZTmqbIXbvRdNgk6fJSKu8+X9t0K+WjDD/KCD/H9 Q25Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764072624; x=1764677424; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K2OO2QVScy6triwwM1Pq5PaJWVgHVZPdOO72BhX0Y1E=; b=nTJqh38Vr0KC/my5h9ifNqtnpJ8+mFej2VhmMDKP2xAXspQX98nEYexJmLQdxpV5r+ 4ve8kfBg/BmI5fpaqxZaYX5pbXZ74XTc8A43q+vAvGfP8NbDZRREmwiBJ3VndgcZalFU sapaJPpZouKL+Ad8qVpp6TivLET6tLu/Owd+nsT5Bq/MwGOf7Xk3TBCmEemiRUCgap4F gyvxcR5ivlIk6WBDW9S64bRb/szaFfUHNeySBZDy2bqvr+7kDU+b+rOtn8WSQj7MXejK FkGvqaNeaZl2c6KcO+I9JfwnRBvKHRqmA0iySE2LoZImfXy6to+BPWB4/8AAfpMkPGrs JQ1Q== X-Forwarded-Encrypted: i=1; AJvYcCVFqHJvm6oTJpsMTujt3USU4EXH848M0L/MpqDR1y2zt/2CAcnwsDZdo5ErF/X05TXaaDfppeUag6J5wJI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy73uLUWltJfDwlYH2+gMTiHVlN9yR0DJkcBdII6mUEO1H2C020 XHJDKA0GW43R9WUQL+C8YL1IweXycUnsNXtEcyV2AQcCAKHEdVMBJ+YdMIY4oaHUoNQ= X-Gm-Gg: ASbGncsdwlLdA7Bmbxoa2zXVMoE8+7O9wyRBv98tsb+FYWVyco97CtbGiJQji0RAJ3x dpIoR3vQrEPp1oJ9C2pY+CS8zSIvkZB6nabhKTwgJeB0FuQz2sUouYQ9kIzV9eo6c/yX4DMlGXb 1OcHYaPRqLEEsINqOyp/z52dcA1Zk0rewMuRz6/Mjevpglg2Eteg89h+aqbEsqm11bre7B3zV7u LqHbCAICePDNNwuhnHU9o47Nc1pUz/DH/jh6rX2CwOxRYqkecSOOSKbVcuvUhwO7aMRO+aBrMmA qz8b4H69c5jAUWrY1uILaRpaD+PWWOe78IMj/pBZjH/E5MvzhL0D9PgF6bRBzxKrBRYVxZ49eaJ liyk2Dvzw12prlJLyIo+YJtpnrzcLFLMMYlQmtq1bw69XmGMlYje/FR+lmngcNmtT1bpagQZOZI H2zBrB0d4+3op6DjAd X-Google-Smtp-Source: AGHT+IExT+Ek+xNvguyC7BgIOl/onhEbrt1EeiBDSXVp/RXupxbve6p1sGi/hZmNng9xoP+N92kDvg== X-Received: by 2002:a05:6000:2385:b0:3eb:c276:a347 with SMTP id ffacd0b85a97d-42e0f1337b8mr3257360f8f.0.1764072624229; Tue, 25 Nov 2025 04:10:24 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42cb7fa35b7sm34583833f8f.20.2025.11.25.04.10.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 04:10:23 -0800 (PST) Date: Tue, 25 Nov 2025 15:10:19 +0300 From: Dan Carpenter To: Navaneeth K Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, david.laight@runbox.com Subject: Re: [PATCH v2 0/5] staging: rtl8723bs: FIELD_OFFSET macro cleanup Message-ID: References: <20251125112059.16913-1-knavaneeth786@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251125112059.16913-1-knavaneeth786@gmail.com> On Tue, Nov 25, 2025 at 11:20:54AM +0000, Navaneeth K wrote: > This series cleans up the rtl8723bs driver by removing the custom > FIELD_OFFSET macro and replacing its usages with the standard offsetof() > from . > > Changes in v2: > - Split the series for proper bisectability: the FIELD_OFFSET macro > definition is now removed in Patch 5 (after all usages are converted), > rather than in Patch 1. > - Patch 1: Now only removes unused RGTRY_OFT, RGTRY_SZ, BSSID_OFT, and > BSSID_SZ macros (dead code not used anywhere in the driver). > - Patch 2: Split long line to fit within 100 columns. Also added > include to basic_types.h to support offsetof usage. > - Patch 3: Fixed brace formatting issue caused by removing commented > code. Removed unnecessary outer parentheses, moved the inline > comment to its own line, and added braces to the else branch for > consistent style. > - Patch 5 (NEW): Remove FIELD_OFFSET definition now that it's unused. > Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter