From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C56C2FAC0A for ; Tue, 25 Nov 2025 21:19:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764105561; cv=none; b=RlNNv96rjr/EfWk9praBhf9hTPb30YKbCbQispXsjJGUgZTn8u9dcBGEvIiQzI8L5fjASFgyRhB+DvP/iF/z0WUJU8Eo2Y3ST82D6yem1RCdFojqMGIETbVhTFhdIhoxQXwDEf4i23MbANm1YhcenIb50MNSCQNKMsPz+dmWnqU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764105561; c=relaxed/simple; bh=s6oxw1XWGB4I9jqKvVZTebVhKAgC5EJsIirvx8Y4I9k=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=svRUEAjvQCYzNCRyiadA5fYIOV9OX2t+mBL4OJjFOq6AkE4WWJ9HJbzBub1yO/wiQMhAVmWQkDu/21IJC8M0t9bQdZ4qUi0YWLq3RHzENeCu7jYdG2GVMcgllV3DopdU/tTLGXtNUUPaXarX9N/JGHglqn6lEQvL2dS2xjdG18M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lJ+g6qcG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=O9+Hnj3w; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lJ+g6qcG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="O9+Hnj3w" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5APB5a0F3255983 for ; Tue, 25 Nov 2025 21:19:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=yLTPkC95YrE7y35XKu51MBDh XlQiAda3t/Tfz4Ry+2Y=; b=lJ+g6qcG4jkD6M+q24L6QxTnfVAwanik7pa5DbFY OxXASjIDibsH0tJb3c2KAYfGbrSp1C7G2Ak79iM13nDs3ZZ6nV9Ru9ia+FBjX+Ke N2jXeMAfHjan4vNnHL4u1H3H7VUJMfDzR+NYzeYgeKNcJMhEFOsbu8kdNIm4s63S W4AcHnP5eguh2WPRQGjp/7rXxrd3Wyz6TamYn8TPy+hce/jx+BDDDYg7dbr6ly1w 3O1Rq+KQyEgtNmF/VYGVnqwS6aFImIjsPWsE/Mcsu7zfXv+eQmGyp/hxf8X3hJ1A dKCCgb11dCm+6rm2ikYAZYaNWFH2UVYXue6AfW49Tahkrw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4anb9c1p8k-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 25 Nov 2025 21:19:18 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8b286006ffaso1442755085a.2 for ; Tue, 25 Nov 2025 13:19:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764105558; x=1764710358; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=yLTPkC95YrE7y35XKu51MBDhXlQiAda3t/Tfz4Ry+2Y=; b=O9+Hnj3wZNpuP7/Fso+1K8Bm14FjHoqNlEwbeo0eLZrunml8f+tgB8JD+FD6D53DGN 4bWAmU1Nm4qpVvrZ1l1EY7G0URLKn6SwUj5Y6Tn/LhCk5+BmrwLnYAowzKshXGPnX3n2 RY/SGvNBDewcm3nFszMI7MUnKA2yIUXyoUfLa5ZzOj4Sn1PhrRq4Y045l6g79rUnQWJa dn14KfQ4Kzm3kLxQxuRhSqSike6aodi3UdFDdvsqNl9fqrRUaTpf3H8IbxGElTMCW9Ca a41wFaemu9p1NxRPHBshbPn2uON+RzE4P9vOBOylhc0/0NhP+lVotQnqyBpp6jbOBoiC DZiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764105558; x=1764710358; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yLTPkC95YrE7y35XKu51MBDhXlQiAda3t/Tfz4Ry+2Y=; b=Z0rvDAZWVSa8IG6Lv4wdHy5LRIS9y6NY8Z5rSeXfR16sO2R13XAJHnAQJZJBaJLXMN G6hAG6A3JHakpfVAUAjgj0RMYaW258e2MrworzikVecnjn2oGV6T93Lb7MfeLSRmFqZX kbp2gXlQPodlYATuhhApsk1kM5adiQsj7NzmVZI2bqKPNaHpCnNaaAC5G741+mdUPkbS vyqJqU1rytE4maATLHIUPX6PSUabx5pM55+fJ5mk6cE1WV+t8oqBFW9TV44ycjb61hcv tgGf5lO6zKpAwdENJEWEABZV7uNRXqXn+wdf0SMKXCgJmrrT8f9eBitTlX31gNDn4WeT JKMQ== X-Forwarded-Encrypted: i=1; AJvYcCW2gt0Irbu3+bS6WEWXlpfDUHczSv6ovaVopc+0FV9bvOn4MEFJmAAPcDPuE0paovDCKrG59Mo6iQL8x1Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yy006P8R22YOU1ioDkU6I8tQ5D0cbDIdYrtfbXdHdqnI4TmSnG8 BgYC2T7p3/7yStkfgzeKWtcdWoQZraqmJ2wB5V4lGo7KIuK1l6B1DhFp6CjJ0zSNCF3Gra4SFuU OOmL6fAtBfNZAiD4g7bnWeN4VYXX7dGlamcUhYyOChsSo0scNBn4fNrXxrqlahpfD5TM= X-Gm-Gg: ASbGncsaNotmeQ+aYUV5xSjs64fIBkrozvBsUOTNH7bfpsO2WffKrQ7R3ky9op09a1l 8d228fdrjbJ5DvMmxRBgeIaLDaWAzfJRk4uneU4djn40Q/ndxzIYHTpa1EB5dh72WF5WdPt9NJR WY1Q+O3VWNbZSJktTOqjGDKb35wUeRMhRolp+Px3OpN2mc55jXzkQydUF5OGPlyyNCJNmN+ppQQ hdDmLuqhHN5xbUPtprXSOrZ9r3Sa0kpd9gT+9N+pdBOnezxG0FAfJMSS+CckjFuVPUqPoxckJKz Hf0lJVJBTFOWmyFOZivFrtnkIrMHep2ku0mu8vop/Axnd3T55prcS6Zz2GuGI26mOuiyw5D7cLF DwFB2k3gaNF7vMzNO0PA/gq+t7DPiiMFclTtVrcK4rIiS X-Received: by 2002:a05:620a:28d4:b0:8b2:7224:b25b with SMTP id af79cd13be357-8b33d1b3473mr2215372885a.16.1764105558126; Tue, 25 Nov 2025 13:19:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IF4F7F27ZWBnL7RYAn4cYaKbiarUuuQz14/G2GedWKvgXvvzElsQHBYyMfyKSvJPr1Lt4Clqg== X-Received: by 2002:a05:620a:28d4:b0:8b2:7224:b25b with SMTP id af79cd13be357-8b33d1b3473mr2215369685a.16.1764105557657; Tue, 25 Nov 2025 13:19:17 -0800 (PST) Received: from trex (125.red-79-144-189.dynamicip.rima-tde.net. [79.144.189.125]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f34ff3sm37293579f8f.16.2025.11.25.13.19.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 13:19:16 -0800 (PST) From: Jorge Ramirez X-Google-Original-From: Jorge Ramirez Date: Tue, 25 Nov 2025 22:19:15 +0100 To: Dikshita Agarwal Cc: Jorge Ramirez , vikash.garodia@oss.qualcomm.com, bod@kernel.org, mchehab@kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: venus: assign unique bus_info strings for encoder and decoder Message-ID: References: <20251121184306.218169-1-jorge.ramirez@oss.qualcomm.com> <35d86818-8b50-1c0e-40a0-5f80c4b24a32@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <35d86818-8b50-1c0e-40a0-5f80c4b24a32@oss.qualcomm.com> X-Proofpoint-GUID: pr7rCkUDmVO59KN-gyBMzao9VJrDxo1e X-Proofpoint-ORIG-GUID: pr7rCkUDmVO59KN-gyBMzao9VJrDxo1e X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI1MDE3NyBTYWx0ZWRfX9La/K2mSPCzf Nk5rgCnL2ih0qgBdFm24Scf96ENo/5O1ULFaXnwFoTJRy2nqw/kzIUzB6Al+dZqvX3GG53AWTn2 3YCr1GE8x9esLt7SwMRhrUATe2vXODPah1hj0/ZwKIIW24gmOZ/DmmuDDZ6m/kGwHxsjnlgy+ZI lvDIMU9nunFN6akey3D2IKdut2+eweBYevkKRDzOQl6YMrSyGdmj41mVGDme7hq5FAF/nuioB8b nk4h14IbjL0dtWy1aXX2Y2uMVy2SPglWDRXmHQnX+uQHtbdMdD4w12hYC+NySp06z4OQa5PtfhR p2ZSHxo8X8Pewj06zNfTGV/U6QMZuP6ReHtso9nLXOracClMUDqScPKNvFkM908j5qVohcQlz8Q L/oSD4wkwBfw9tfK9UMaVKd7m0qT2g== X-Authority-Analysis: v=2.4 cv=VKbQXtPX c=1 sm=1 tr=0 ts=69261d56 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=QCpOfKHlYVe8AePir1+hrw==:17 a=kj9zAlcOel0A:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=xOd6jRPJAAAA:8 a=EUspDBNiAAAA:8 a=LunTiXMjpaI1IbjBSeoA:9 a=CjuIK1q_8ugA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-25_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 bulkscore=0 adultscore=0 malwarescore=0 suspectscore=0 phishscore=0 impostorscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511250177 On 25/11/25 18:39:14, Dikshita Agarwal wrote: > > > On 11/25/2025 6:22 PM, Jorge Ramirez wrote: > > On 25/11/25 13:59:56, Dikshita Agarwal wrote: > >> > >> > >> On 11/22/2025 12:13 AM, Jorge Ramirez-Ortiz wrote: > >>> The Venus encoder and decoder video devices currently report the same > >>> bus_info string ("platform:qcom-venus"). > >>> > >>> Assign unique bus_info identifiers by appending ":dec" and ":enc" to the > >>> parent device name. With this change v4l2-ctl will display two separate > >>> logical devices > >>> > >>> Signed-off-by: Jorge Ramirez-Ortiz > >>> --- > >>> drivers/media/platform/qcom/venus/vdec.c | 5 +++++ > >>> drivers/media/platform/qcom/venus/venc.c | 5 +++++ > >>> 2 files changed, 10 insertions(+) > >>> > >>> diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c > >>> index 4a6641fdffcf..63f6ae1ff6ac 100644 > >>> --- a/drivers/media/platform/qcom/venus/vdec.c > >>> +++ b/drivers/media/platform/qcom/venus/vdec.c > >>> @@ -433,9 +433,14 @@ vdec_g_selection(struct file *file, void *fh, struct v4l2_selection *s) > >>> static int > >>> vdec_querycap(struct file *file, void *fh, struct v4l2_capability *cap) > >>> { > >>> + struct venus_inst *inst = to_inst(file); > >>> + struct venus_core *core = inst->core; > >>> + > >>> strscpy(cap->driver, "qcom-venus", sizeof(cap->driver)); > >>> strscpy(cap->card, "Qualcomm Venus video decoder", sizeof(cap->card)); > >>> strscpy(cap->bus_info, "platform:qcom-venus", sizeof(cap->bus_info)); > >>> + snprintf(cap->bus_info, sizeof(cap->bus_info), > >>> + "platform:%s:dec", dev_name(core->dev)); > >> > >> Is there a reason to keep both strscpy() and snprintf() for cap->bus_info? > >> The second call to snprintf() seems to overwrite the value set by > >> strscpy(), making the first assignment redundant. Would it be cleaner to > >> remove the strscpy() line and rely solely on snprintf()? > > > > argh, my bad, you are right. will fix. > > > > perhaps we should just have instead > > > > decoder: > > strscpy(cap->bus_info,"platform:qcom-venus-dec", sizeof(cap->bus_info)); > > > > encoder: > > strscpy(cap->bus_info, "platform:qcom-venus-enc",sizeof(cap->bus_info)); on the encoder > > > > I suppose the additional info provided by the dev_name is not really > > important to consumers. > > In-fact, we don't even need to fill the bus_info, received a similar > comment on iris [1] > [1]: > https://lore.kernel.org/linux-media/c4350128-a05c-47af-a7e7-2810171cd311@xs4all.nl/ Nope, that is wrong. if we dont fill bus_info we will end up with the following again: root@qrb2210-rb1-core-kit:~# v4l2-ctl --list-devices Qualcomm Venus video encoder (platform:5a00000.video-codec): /dev/video0 /dev/video1 instead of something like this: root@qrb2210-rb1-core-kit:~# v4l2-ctl --list-devices Qualcomm Venus video decoder (platform:qcom-venus_dec): /dev/video1 Qualcomm Venus video encoder (platform:qcom-venus_enc): /dev/video0