From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3238528E0F for ; Wed, 26 Nov 2025 02:26:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764123972; cv=none; b=uM0aC5F70qjZPChrMwNYhd5WhuOq+QN1U3nqpVDEn1cbGLVD5ufP56t9vglHCYTHOx+dWDPpc00WdVhH2AEX8rDiy/nScpg7MAkB2MZYADdzvoOKbaGHvj50cEEbY3HXerLpv6fF1ccilk6SPTBBGud5QEXlaL5IQ1H+Oi/XpYA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764123972; c=relaxed/simple; bh=IvkwnBreerHye+pyyWKXJbSIvj4RH/cd9+Bnp1+28CU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WH8+CRglVIiEmsOM5w09UJIijjTaV6O0JRWkyXiNKhzg2thcUNg20aqjtE3unnGT8UrcF2/N4+4Kj4jdMipGHmr/ZmuRZgUyc++Be1OZLq4D7NYUi5dgN8z+PRSwVw+YPnBHUX0+4DthE3fl3hfbeiBCOVwKJG70hzsGv6jnbfo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MIjijmdb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aSOBSh/d; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MIjijmdb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aSOBSh/d" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AQ2FxVb3317325 for ; Wed, 26 Nov 2025 02:26:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=TxSG1ManjepYP5kIvbTRIx6w sMG9QO6qn584WZ2KdCE=; b=MIjijmdbj4J9ynEqZ5gC2dJ5dIiY3zSRDJiUt5tU 8x719mlOxmciR+E1sOQVi1ygJ1bUuoJhgnhahm+dY2yR04FQqgIQfcaorhPmsqpL KH4j6yodePHJE58LI9Ly9VbR2rPJ8pvJq+3poRWDwNh4XHROu0xUwm6SokgvDEUn G+hL1a6eueoxcBHJ0825/V/s65XLI9BFx3DJxb38TpkZZOZnb4T7/b+gGiVdL8+V h8sYww3HaajvD5OdUUQqLz0jwHnQ0bMBRuVOHIVDxm3Z6gkZt2CVuxT1/ipp82Y6 pC2LUqUHi+5k/jE16CgvqLA5qPCiWUrv7aYjbU6A6EmM5A== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4and2qhyea-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 26 Nov 2025 02:26:09 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4ed7591799eso148624881cf.0 for ; Tue, 25 Nov 2025 18:26:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764123969; x=1764728769; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TxSG1ManjepYP5kIvbTRIx6wsMG9QO6qn584WZ2KdCE=; b=aSOBSh/dCV9myBx9J8AEdTkXaMBU9RhcMk1qkdlGo9QzqCXff/ihp5oKYGBZ4ScS4q vDFnTzte+icoKJkmrn5SHvz2DcCP2yJBjIKIrxumXH7AEN5lCzfCdHFvnk4hi/fJ9v+w csonRMNXBz0Wg3F3piUdKzO+MQYYYEKfnCYI3SCOT86N9Drr9JT6Ht8ln8sK81nanACB eF1nUb/Vvno8Vno0bG6MoaRtVivB8wM9z8bdBXR5DqdzF3nZXd9VEhFRAU0ebQ7j9A8/ 2cQ/UJpqw6NIBpGwfW9uaT7KJz4isyHiyOpkrIYVZuhKHi5kFPcPAvxb+oCplxsBT3mE Lnew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764123969; x=1764728769; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TxSG1ManjepYP5kIvbTRIx6wsMG9QO6qn584WZ2KdCE=; b=ICL3GL5qwKN1jErnqDFHb8vGp/Veh70mt6umTEUUy+otG43qBb2esJgnVVhbE+Bfym q1XhxzPaIFoMIT+X2uGxu8QIyviwOy1oOw9+Ne6FtiwK0PM3eOeJR9jceVsqjL4JzYu5 e+QTBFGvNY2VAacnAxh86UECQy6S9bjUmsJLmD2xc8weV7ZBmAN2/AgAf2QQcgAa09FI 0O+heBhDJ8A35UsAJKyk/cjrBdkQq97hd6xqD5vF5b7v53TngIzP2kRulHp+62TW3doP X/LUmlAJnCzwVbp8aNYar6cSGBdHz2pv0A6+N2Q0Z0iRdxKyY7g2bc+34DKqqumrEkCH IX7A== X-Forwarded-Encrypted: i=1; AJvYcCWWZ81/V5O+PETvJiekAm2jww8LN2ciatwE9p5gmhTgpfj+Esb3rjGooZbNGhFFNsUFi/nAmxcpFjdGErI=@vger.kernel.org X-Gm-Message-State: AOJu0YzuxLwNO36k3Z134rZ/Lz2s3Ubbtf1l4N9XNMH/gyUH/x92I8Gn nPcCUFRdLdrCr3Avv8ciGRYDRVTzb9MnD9MzzRdwIOCdpQfW2+NshXdbcpoc8t0Yo8QTX4/aMMs /DCjsrYw6w6ibHkF66fYs17Ud6DeByrbC51bMajVgKVeoSAgN3rAvuGQmxpZFzmptEvE= X-Gm-Gg: ASbGncszVa0nHjqay2LdZ6V5OMCPvPEc/S0/VWJvsrcM7vO9OCW6ir++0oygFx3v2B4 vGX6Pb+G36mADreD5G7IB2UvAAU/4821M7AQJYKLkUjb4OvildHvVVVsLqqWe435f12c7mAHHNk B8R089AHL2VZk83j6I85gGw6NWF5v6+zkWJjWr6TooTd5vwH4+xJplQ82uH/Qpx+nwcAgeEnuH5 7tI/PeKMHYBsEGYyAZOfUBMIcXZSifm5xLWmd42t/OC4CB+UexfSvGI8yEVUXkhN8A69H9rJ5Pu gE1p04+UoQ17O62jmoaXhPScmg5ts/04iK7Pi5p0Z5+1nZS6fS4TqGjPqz6OZ9tm02kXBmVm7aR dD2fH7z5QLChTgbQXzuc4FGV7DVBQSYRh3WLbtOknq+Jxh4NNKStuoh1vwRepENcjNhFb86hsMk U= X-Received: by 2002:a05:622a:1812:b0:4ee:4709:4c38 with SMTP id d75a77b69052e-4ee58943fb5mr234067841cf.80.1764123969286; Tue, 25 Nov 2025 18:26:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IEz8HcPa9d0VpPpenRMeT+be3LkzfrhEnN46hyIHhUBzFTAfu0MT5HHoOY/YvkYm3AIa6rYVA== X-Received: by 2002:a05:622a:1812:b0:4ee:4709:4c38 with SMTP id d75a77b69052e-4ee58943fb5mr234067381cf.80.1764123968793; Tue, 25 Nov 2025 18:26:08 -0800 (PST) Received: from yuanjiey.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8846e5749bcsm137582306d6.44.2025.11.25.18.26.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 18:26:08 -0800 (PST) Date: Wed, 26 Nov 2025 10:25:57 +0800 From: yuanjiey To: Dmitry Baryshkov Cc: robin.clark@oss.qualcomm.com, lumag@kernel.org, abhinav.kumar@linux.dev, sean@poorly.run, marijn.suijten@somainline.org, airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, quic_mkrishn@quicinc.com, jonathan@marek.ca, quic_khsieh@quicinc.com, neil.armstrong@linaro.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, tingwei.zhang@oss.qualcomm.com, aiqun.yu@oss.qualcomm.com, Yongxing Mou Subject: Re: [PATCH v2 05/10] drm/msm/mdss: Add support for Kaanapali Message-ID: References: <20251125064758.7207-1-yuanjie.yang@oss.qualcomm.com> <20251125064758.7207-6-yuanjie.yang@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI2MDAxOCBTYWx0ZWRfX9RiZ9cO1eXpn LQK3YXeT2l6BMdVfdHhKFWaNh6Vgg9AxqjLUHZtYLGjwAfx7pl7ri93r/s5CKcz3Bhgi57MMzq2 IobzDJ1yVt0tJsL2XIUyJbG1wesjbomlXqxclZUtLw0KzZKRbICqJPTibR29SqJE3AEDiGe6dlZ Jap5Fy4eoVILJcV8GRtCZW2hPG+s/FguFGyiC2/DPrXSgyIym7FhKyhnpFUA/lS1KhlaVGnjcZI BrNLOSEfH0QHhaBvlVfxnRatdAi1JDABs3j+NLNFZwInKMEnhb4vXH+yPJcgMbO3LMRSlS1WHCo w3lI0u6AC1UztD+5glbyfxa9x44PQQBQCEVAgkdJaY0N0YlPGpYlDpc4i+L89t6pDajGSZxzxrb 2qo7zxy99N+3KDzquS9rEdGuVzsAbw== X-Authority-Analysis: v=2.4 cv=dZyNHHXe c=1 sm=1 tr=0 ts=69266541 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=kj9zAlcOel0A:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=inixIHUC_2VtAalyxKMA:9 a=CjuIK1q_8ugA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-ORIG-GUID: stgfozqW-OKr5MYIVuhliXV1-zf1BLe9 X-Proofpoint-GUID: stgfozqW-OKr5MYIVuhliXV1-zf1BLe9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-25_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 spamscore=0 clxscore=1015 bulkscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511260018 On Tue, Nov 25, 2025 at 04:47:09PM +0200, Dmitry Baryshkov wrote: > On Tue, Nov 25, 2025 at 02:47:53PM +0800, yuanjie yang wrote: > > From: Yuanjie Yang > > > > Add mdss support for the Qualcomm Kaanapali platform. > > > > Co-developed-by: Yongxing Mou > > Signed-off-by: Yongxing Mou > > Signed-off-by: Yuanjie Yang > > --- > > drivers/gpu/drm/msm/msm_mdss.c | 22 ++++++++++++++++++++++ > > 1 file changed, 22 insertions(+) > > > > diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c > > index bf9a33e925ac..797ef134e081 100644 > > --- a/drivers/gpu/drm/msm/msm_mdss.c > > +++ b/drivers/gpu/drm/msm/msm_mdss.c > > @@ -243,6 +243,24 @@ static void msm_mdss_setup_ubwc_dec_50(struct msm_mdss *msm_mdss) > > writel_relaxed(1, msm_mdss->mmio + REG_MDSS_UBWC_PREDICTION_MODE); > > } > > > > +static void msm_mdss_setup_ubwc_dec_60(struct msm_mdss *msm_mdss) > > +{ > > + const struct qcom_ubwc_cfg_data *data = msm_mdss->mdss_data; > > + u32 value = MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | > > + MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit); > > + > > + if (data->ubwc_bank_spread) > > + value |= MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; > > + > > + if (data->macrotile_mode) > > + value |= MDSS_UBWC_STATIC_MACROTILE_MODE; > > + > > + writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); > > + > > + writel_relaxed(5, msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); > > + writel_relaxed(1, msm_mdss->mmio + REG_MDSS_UBWC_PREDICTION_MODE); > > +} > > Can we please merge this with 4.0 and 5.0 functions? Ok , will do. > > + > > static int msm_mdss_enable(struct msm_mdss *msm_mdss) > > { > > int ret, i; > > @@ -296,6 +314,9 @@ static int msm_mdss_enable(struct msm_mdss *msm_mdss) > > case UBWC_5_0: > > msm_mdss_setup_ubwc_dec_50(msm_mdss); > > break; > > + case UBWC_6_0: > > + msm_mdss_setup_ubwc_dec_60(msm_mdss); > > + break; > > default: > > dev_err(msm_mdss->dev, "Unsupported UBWC decoder version %x\n", > > msm_mdss->mdss_data->ubwc_dec_version); > > @@ -552,6 +573,7 @@ static const struct msm_mdss_data data_153k6 = { > > }; > > > > static const struct of_device_id mdss_dt_match[] = { > > + { .compatible = "qcom,kaanapali-mdss", .data = &data_57k }, > > After glymur, please. OK, will do. Thanks, Yuanjie > > { .compatible = "qcom,mdss", .data = &data_153k6 }, > > { .compatible = "qcom,glymur-mdss", .data = &data_57k }, > > { .compatible = "qcom,msm8998-mdss", .data = &data_76k8 }, > > -- > > 2.34.1 > > > > -- > With best wishes > Dmitry