From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9DF21F1302 for ; Wed, 26 Nov 2025 13:12:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764162746; cv=none; b=qFtVTiOMjDM7wYpOOqJ/z/B0kFVy1qW9TMH6RU84DWz8Z8ce07C9nFbKvhUCzEmz4Wq6tr2BiIuwHGrcqg5f3Yj2MdG/tdwP73l4m0jOzOlQJHxGu09i5jTgXg+vvtiJEcFsA7rg5QtdpCYObmqxrUR/ZdQ4ZtSqy9lvipJCut0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764162746; c=relaxed/simple; bh=Rv4FJgnug7MT27zvDvDPacsYboDa76Y1pxEBVDzA/WM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=isqX7zU/TGTu3RsDY7+txfEwnYPAFfucvzf1wVSW9QN+fkpKCUvZYUtW9LXy3debUUxIFTblo+UM1t8x9LBpBmfzJSTh9OvNcALwJLKBVia7+3GKYsD7dnskoK0Gxf2w9LJji6uw4KMhQrra/rxKtCqtFJ2H4ia2/ecUA6lx0u8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Iwk85+da; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Iwk85+da" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-477563e28a3so6165925e9.1 for ; Wed, 26 Nov 2025 05:12:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1764162743; x=1764767543; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=azsrhZgWyYhx6NRpCHGgrx0NKRpo3MJZPtnrDvh+H7E=; b=Iwk85+daZY41KQ0FQQPhkcQtKlJwzksbrh9oItXlzCSGI7qTVAt0ffJL88guSUXAG1 1cn/OHbdU5nl9FhUWe0IeoyPW6k6ssBnauynWrd+iQeBJAwEHJBifR6N+3gXWRFEcRPl LOY9012DbHIg5fnWXvWZwPPlpv91DkLz2+8YjQcJnJV43UGo3i0Lq3LvaUSFQyxtXbMm RYxh9206Usb/Ld/2MZWUEfxUVmW2cdRW1gi2kLkyqmeICurQL/eZITgOQf4RJSlK9jMG ibh17xRrQ3E3d/Zy7f1V2h0eUh1dlEcQHYSHPbQ5SU2f5jzep2giIIdf49CUYuNsAHtY K7dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764162743; x=1764767543; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=azsrhZgWyYhx6NRpCHGgrx0NKRpo3MJZPtnrDvh+H7E=; b=nEVB01rDuXmawt5rOByA1yNVLm0DKgQjHnRAaX76MDL9JNoYOdGEkibRJz9DWMcmvu ur3zJac5/CcPKV/PmRV7mPWi4pCWrxA0GE4yK4BpUNVB2k98jMW80kQlQ5pTSgRAzmCK pG6TRGZbfP1wDjYpp5hWp7NKXxaNheETOu2cAWn2CltV7IWVPGozdXldyT9gpT+UQv3H u4Cew+VnWw/tbmk33elwlW0oDILI4jsK/bwCesjsj7dFO/EsYeRMsfEhvxle7IfQExVM M5qFm2VdzMWKWzWYSMTCeiTRoDeYtgR8aqtDLYFgAGpYzDU09CCQlqZSD183m9N671I6 3BDA== X-Forwarded-Encrypted: i=1; AJvYcCV3lxSwabzszCMqJaCBMnL2w2N2WCf5DEYjb2nMMoAtM7p/qmMtcizHLbyMdGV4FnWm0sZ7F/n7vpzeixA=@vger.kernel.org X-Gm-Message-State: AOJu0YyDro/j8Co3yzUdcWCteozFZ/Bx0K5Etis538gVF6U0ByP3OtVT 7cAu3Xx2KpwME2IDwA36gQ2fTlbdCHQZfEW4EPMesRkdT+7jglzkbgclUOQ7tMQYcyE= X-Gm-Gg: ASbGncsV9r6FA9Vm8M53hsnrq2cnmZE0t2/C11VVOlFfiANzRZZRc87+Y0h1SHW5et+ +eKONyVrgbiNkt0EF0q4031ftFeUAWol1lR3K2wx0Bp9gKgKQBYomhbTVUovYno9IGT7jqV3a55 1j5K7zW3XNDWZt/SHlFzhSv2AyHyJzBzdTS28D2kj1O8ZglBWkNVm/PWGNaENhF+Iya1pEMKBc8 d1HkaUlnJd5qQfiVA74UijLT3jCalQD6neTtci8TkWjS2LAlDfAlp2+4V6AfoM6mILjE/LLMRHa 5EPI8p0ZpjZym56Lrxfx0eqr5DEsebpBuTQfGjVBS3NLudsIknYo2zaomo89LpVTd6n2nmgAg/v TM0ECU6FcVmAAjBAq3AK+9++6jWfhT3Lx282wJks0hhdwCGZvDGTzy/iPpSCCP/0KefdZTfLuHc cHN7PevC/fbbZQPA== X-Google-Smtp-Source: AGHT+IFEYv6UMcwGn4taVzPLuUnJBcIZRl4prj8V/wWkXOqPExh69hNsmDyiZhSbwf/siv21g/oC8w== X-Received: by 2002:a05:600c:1e89:b0:477:a1bb:c58e with SMTP id 5b1f17b1804b1-477c04cfddcmr213170355e9.7.1764162743079; Wed, 26 Nov 2025 05:12:23 -0800 (PST) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f34fe8sm40473140f8f.15.2025.11.26.05.12.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 05:12:22 -0800 (PST) Date: Wed, 26 Nov 2025 14:12:19 +0100 From: Petr Mladek To: Marcos Paulo de Souza Cc: Steven Rostedt , John Ogness , Sergey Senozhatsky , Greg Kroah-Hartman , Jiri Slaby , Jason Wessel , Daniel Thompson , Douglas Anderson , Richard Weinberger , Anton Ivanov , Johannes Berg , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-um@lists.infradead.org Subject: Re: [PATCH v2 1/4] drivers: serial: kgdboc: Drop checks for CON_ENABLED and CON_BOOT Message-ID: References: <20251121-printk-cleanup-part2-v2-0-57b8b78647f4@suse.com> <20251121-printk-cleanup-part2-v2-1-57b8b78647f4@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251121-printk-cleanup-part2-v2-1-57b8b78647f4@suse.com> On Fri 2025-11-21 15:50:33, Marcos Paulo de Souza wrote: > The original code tried to find a console that has CON_BOOT _or_ > CON_ENABLED flag set. The flag CON_ENABLED is set to all registered > consoles, so in this case this check is always true, even for the > CON_BOOT consoles. > > The initial intent of the kgdboc_earlycon_init was to get a console > early (CON_BOOT) or later on in the process (CON_ENABLED). The > code was using for_each_console macro, meaning that all console structs > were previously registered on the printk() machinery. At this point, > any console found on for_each_console is safe for kgdboc_earlycon_init > to use. > > Dropping the check makes the code cleaner, and avoids further confusion > by future readers of the code. > > Signed-off-by: Marcos Paulo de Souza I agree that the check is superfluous and can be removed: Reviewed-by: Petr Mladek Best Regards, Petr