From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4C48229D295 for ; Thu, 27 Nov 2025 09:21:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764235264; cv=none; b=g4f1dixEfNE7QG76Zut2VtsPbdSTaZCo9YoZQRwqXmT6ytm2HKYNuxeVoIHeN4EPjgAjQHobflwBZcGCDjPhaqUmyT7uUiR+eWta9HJDM4oK0RbmHo/MemLCx2Cvy7/MU0UJQm9Z5JqRuqaO6WvE19Bb2uQJqGtM7PI85F6Ko5Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764235264; c=relaxed/simple; bh=rWCFmR1K+Llp5/ObWBQYBsgiYp5zHDVJqbyE3u3t39c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=p4RNl4e4VwcN8pvnNapUoCtvEen909FZrwVTzEPVh15+YpFzROWMqbvOoJDx/UMrp4XlP2abrUXvmaLhcuZpUeNlie3fOeZDQv817LBfZHYViQz1Wd2ASDAcu50I7jjc7obYaelA7NWQJuUrylF3IrwGpKA5i8VaNHcEQK4uHSI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1EB2E1570; Thu, 27 Nov 2025 01:20:54 -0800 (PST) Received: from J2N7QTR9R3 (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2A25B3F66E; Thu, 27 Nov 2025 01:21:00 -0800 (PST) Date: Thu, 27 Nov 2025 09:20:57 +0000 From: Mark Rutland To: Osama Abdelkader Cc: catalin.marinas@arm.com, will@kernel.org, ada.coupriediaz@arm.com, smostafa@google.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: Remove unreachable break after die Message-ID: References: <20251126222620.215245-1-osama.abdelkader@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251126222620.215245-1-osama.abdelkader@gmail.com> On Thu, Nov 27, 2025 at 12:26:20AM +0200, Osama Abdelkader wrote: > die() never returns, the break is unreachable in arch/arm64/kernel/traps.c Is the break causing some problem, e.g. a compiler warning? If not, then I don't see a reason to remove the break. There are many other instances of "die(...); break" throughout the kernel, and this doesn't seem to be speecial. Mark. > Signed-off-by: Osama Abdelkader > --- > arch/arm64/kernel/traps.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c > index 681939ef5d16..81dd2d7759eb 100644 > --- a/arch/arm64/kernel/traps.c > +++ b/arch/arm64/kernel/traps.c > @@ -1003,7 +1003,6 @@ int bug_brk_handler(struct pt_regs *regs, unsigned long esr) > switch (report_bug(regs->pc, regs)) { > case BUG_TRAP_TYPE_BUG: > die("Oops - BUG", regs, esr); > - break; > > case BUG_TRAP_TYPE_WARN: > break; > -- > 2.43.0 >