From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DACFC32862A for ; Fri, 28 Nov 2025 12:16:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764332189; cv=none; b=Ilpl15fx0dMfoIAMm7+psFYnqHyc1aVnBUp6Mk0HjdOYGWguyonQ8imO/nhIYZMiyGwJNgh2tLgbJ74DRZwxeZjuRbnBIACK5QNXXjxDNzq10rrCJBzpRJgjDYl9KwSImHO1SBH1o1aMS2JkEPzJcyGJGAlTxpw+vb9YJIQt4xg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764332189; c=relaxed/simple; bh=g4y7Hz328+8IEKpa4hdtQbueyA3WDjV4cr57ogp33So=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EVWucMAduKsyPC+UE/PcNZVpXeh0UO8pr/CMNcqmovAMN9ZiCLD7zLCJ2nvueRlfvt1nrIT+KCdRdffB/2QRRbxClRnhWxZfynFtGh7xFViM3citma9lR7sWdzQ8txetd7ocZFpxKsOV3lmKEGx17IzN3vHOIkAGa8+zl9Y19ro= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=G37UNOEM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="G37UNOEM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE09DC4CEF1; Fri, 28 Nov 2025 12:16:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764332189; bh=g4y7Hz328+8IEKpa4hdtQbueyA3WDjV4cr57ogp33So=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G37UNOEMVutj78J8T647ePZx7d1VxztQSsh1umig/8luofsMrnDLm0UwExHwKF9dP laNDKvNkN4aVDE0bPRh24pdAM+yzwJBDRzVQeoD9UL18IY44VS3v35P/qX+kVF/VGa fp2z8IiKHgmjfbah7KOxEgCtMAf4mS55b0UrC9MJIqoZ1LX6ROUzsKbs3glR+iZXp5 bIexMApL5XVic3oDZ6Ko5JG1DtlmXwgYvQ0+3XyCC93axjw3tvhVdmGIPeWFj0zwOE LgX6lAEjv1kzJ3T0banFWSzAqmwpfQPbrg6aeaY92gAIQ+gSUx+R5JSZw1cfY9B6cH vk7q9Aw02saFg== Date: Fri, 28 Nov 2025 12:16:24 +0000 From: Will Deacon To: Yeoreum Yun Cc: catalin.marinas@arm.com, akpm@linux-foundation.org, bhe@redhat.com, leitao@debian.org, coxu@redhat.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: kernel: initialize missing kexec_buf->random field Message-ID: References: <20251127182644.1577592-1-yeoreum.yun@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251127182644.1577592-1-yeoreum.yun@arm.com> On Thu, Nov 27, 2025 at 06:26:44PM +0000, Yeoreum Yun wrote: > Commit bf454ec31add ("kexec_file: allow to place kexec_buf randomly") > introduced the kexec_buf->random field to enable random placement of > kexec_buf. > > However, this field was never properly initialized for kexec images > that do not need to be placed randomly, leading to the following UBSAN > warning: > > [ +0.364528] ------------[ cut here ]------------ > [ +0.000019] UBSAN: invalid-load in ./include/linux/kexec.h:210:12 > [ +0.000131] load of value 2 is not a valid value for type 'bool' (aka '_Bool') > [ +0.000003] CPU: 4 UID: 0 PID: 927 Comm: kexec Not tainted 6.18.0-rc7+ #3 PREEMPT(full) > [ +0.000002] Hardware name: QEMU QEMU Virtual Machine, BIOS 0.0.0 02/06/2015 > [ +0.000000] Call trace: > [ +0.000001] show_stack+0x24/0x40 (C) > [ +0.000006] __dump_stack+0x28/0x48 > [ +0.000002] dump_stack_lvl+0x7c/0xb0 > [ +0.000002] dump_stack+0x18/0x34 > [ +0.000001] ubsan_epilogue+0x10/0x50 > [ +0.000002] __ubsan_handle_load_invalid_value+0xc8/0xd0 > [ +0.000003] locate_mem_hole_callback+0x28c/0x2a0 > [ +0.000003] kexec_locate_mem_hole+0xf4/0x2f0 > [ +0.000001] kexec_add_buffer+0xa8/0x178 > [ +0.000002] image_load+0xf0/0x258 > [ +0.000001] __arm64_sys_kexec_file_load+0x510/0x718 > [ +0.000002] invoke_syscall+0x68/0xe8 > [ +0.000001] el0_svc_common+0xb0/0xf8 > [ +0.000002] do_el0_svc+0x28/0x48 > [ +0.000001] el0_svc+0x40/0xe8 > [ +0.000002] el0t_64_sync_handler+0x84/0x140 > [ +0.000002] el0t_64_sync+0x1bc/0x1c0 > > To address this, initialise kexec_buf->random field properly. > > Fixes: bf454ec31add ("kexec_file: allow to place kexec_buf randomly") > Signed-off-by: Yeoreum Yun > --- > arch/arm64/kernel/kexec_image.c | 3 +++ > arch/arm64/kernel/machine_kexec_file.c | 6 +++++- > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/kexec_image.c b/arch/arm64/kernel/kexec_image.c > index 532d72ea42ee..db6fb8c599a1 100644 > --- a/arch/arm64/kernel/kexec_image.c > +++ b/arch/arm64/kernel/kexec_image.c > @@ -76,6 +76,9 @@ static void *image_load(struct kimage *image, > kbuf.buf_min = 0; > kbuf.buf_max = ULONG_MAX; > kbuf.top_down = false; > +#ifdef CONFIG_CRASH_DUMP > + kbuf.random = false; > +#endif > > kbuf.buffer = kernel; > kbuf.bufsz = kernel_len; > diff --git a/arch/arm64/kernel/machine_kexec_file.c b/arch/arm64/kernel/machine_kexec_file.c > index 410060ebd86d..06f38866424a 100644 > --- a/arch/arm64/kernel/machine_kexec_file.c > +++ b/arch/arm64/kernel/machine_kexec_file.c > @@ -94,7 +94,11 @@ int load_other_segments(struct kimage *image, > char *initrd, unsigned long initrd_len, > char *cmdline) > { > - struct kexec_buf kbuf = {}; > + struct kexec_buf kbuf = { > +#ifdef CONFIG_CRASH_DUMP > + .random = false, > +#endif > + }; This hunk is pointless. Will