From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEC3521B9D2 for ; Mon, 15 Dec 2025 02:11:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765764670; cv=none; b=fHlRHCkZ2anH6xsHNfaMa2UTpGnhIj0oSF7+R+Eu49/oi2xPqxY/ZA3C39LPIR3rM8ytM4Mp8eyL3vOFWjebcmjkGfYeohkLLj1wx6536P8q/hlxO4Tw2224838dGzLess56KO31RDXO8z9sMvIR2Gr4bktwXzVDquig3NwRDV8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765764670; c=relaxed/simple; bh=RQpJgAFNddWw7AyF6f5NtI7ueKumtL9CkbkvTEzcXjY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nXmx+CvKzwirSxzRK8ALwcjwwDzgQfaahCeCTsEJlvz3GgXqvp3nQIqdNKoH8aR26KNJTwBQsryjQpxf6635Wxl+YPBZ0JPf8FbPeA7rtJYqNweEgrHYI6lr1xEWHaO06XSWqvKfY2RA0ZhSyknfGjv+5G2zRtI4kvAX2Onn0zQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=dg6+FjWm; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dg6+FjWm" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-7e2762ad850so3032275b3a.3 for ; Sun, 14 Dec 2025 18:11:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765764668; x=1766369468; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Qgsg75s3qAHMgvIkSidcSt/1Y3c1SrFas1wQzevvAw8=; b=dg6+FjWmBM2KLJAucT4cRyf1H/DFgQHWMeFhxDdbm7ZfYseAOYS+csy016zzq3lGvQ x2HuJc3nXCxjmcyOtNNwIYLXzE4folJOGlbeYiuL3NC0SVyDhb3+XdMwgN+9DqOW9evD MWgDYJI51bbm51NmLxWUmkGqjU5dCsTTljjvVp65n2iPyM45KXzuPN6o2R1Xz4qaBu9H vlL2yPPJyp/+9JNEmpfl8HR/myGNgWGkUAtFhKDglV1Aty4nBJDELbxAktZj0P/3SFqQ wqaGyBMyakZUfF8fsfrHIZb1SaNe/LSVq3C1GTs4R/d+qpoaqAtk1lS5JE9Zcxnv7sF1 HnmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765764668; x=1766369468; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qgsg75s3qAHMgvIkSidcSt/1Y3c1SrFas1wQzevvAw8=; b=BsiwYOM9cf9fz35dFuZ2ycccfAmpbljkBLYAqeTSBFN8iSnnC3B7932ziDRY3MmH18 l/n2iKzjunTMBdTJJFlC/Xz8V+/U+TMHdDMkaSp87Ew/K8Oww/T2mYaSDn6iA13WUS6i cngnO8KRMbKmUS5F4VWC7Rq+EODdmepg8vWkfsDuJMc+LEvS5sq4NARR1tCkChGuPHfR LUcpV/D2FKFzb+iPdHOO66gHoSgS7fObfn8t6UzOKvAmlwSiZB0QWjhmskjQiCpcyZ3B k++JWZgUyhhoThtfZ6JNxGQe3IdVVKnCnaFBnR1aNUySFpU6N11PnyRLklYPIvP6FOPl aJLw== X-Forwarded-Encrypted: i=1; AJvYcCUVgZvvro6jT/Sg6i8aTEOGUTAwsD426wsXLWNLpT+O5qhzhHQ8aClQHm3xQER+gBpPG1REMd42nFIFPHs=@vger.kernel.org X-Gm-Message-State: AOJu0YxZ6kcQslVjPAMz6F1oCm1V8B78avU79nIsFa56msu02r9fHhwb 6PL0pK7x0XMZBd3aA3IwyXQ10SgJGxzhFzf/CzOTglqKGWcXhXRG93EsPQRlVtwtcGc= X-Gm-Gg: AY/fxX4iCVS+G2A5D2e4v8sYmxs+bqWH4lzAjMK0YFvJTDgIpiyjBcSkxFnhi+WG2qv wzc56OoUboD+VNldkDbjGc0dthvm4rBQu0lPRJQcV9/+Gp6bNnHXD9zonC/fNT4Igl5Y8SS1+3Q 15T2UiaiOEciqkZ2NI5thegVLuM0BpBEHIxNgeqf2URoDScKNxqjWEQFwRN3ggrwGdH1i1B1uUy vl48a17wbaKJhfNq1RYvRsA2yeBlszVpejxZcY9AGzLQWQuMvLK+u+RrjL4c1ojMamq48yIkq8D hRYvCoTwmDTedYl43vqOW3WRmYMr22VUL8SWsGcZ8pNxmLEoOec0+OmQPQx8TUUap/ooBXOKhht nyS9VPc3BiVu304qHfz8Qhz8Ac5zsrzbNZ1dZ61OhKLKQ//hgb6YbY7J2H5rbvRReRRIoqtepK9 WTuaBwMy8l5W7Ol7+cOrWEy4iOrsXRbAiHXZx4HZnTSw== X-Google-Smtp-Source: AGHT+IFshcXVNij9zJ81B5WuJafD0T1VgLx62XssDHNaTIpACeotR+RQvJl07N2kvTSSjnWlXbJGOA== X-Received: by 2002:a05:6a20:e210:b0:366:14ac:e1fc with SMTP id adf61e73a8af0-369b0999301mr9246879637.78.1765764667976; Sun, 14 Dec 2025 18:11:07 -0800 (PST) Received: from p14s (p7838222-ipoefx.ipoe.ocn.ne.jp. [123.225.39.221]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c1361b76c4bsm3021918a12.35.2025.12.14.18.11.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Dec 2025 18:11:07 -0800 (PST) Date: Sun, 14 Dec 2025 19:11:01 -0700 From: Mathieu Poirier To: "Iuliana Prodan (OSS)" Cc: Bjorn Andersson , Shawn Guo , Sascha Hauer , "S.J. Wang" , Fabio Estevam , Daniel Baluta , Iuliana Prodan , imx@lists.linux.dev, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Pengutronix Kernel Team Subject: Re: [PATCH v2 1/3] remoteproc: imx_dsp_rproc: Skip RP_MBOX_SUSPEND_SYSTEM when mailbox TX channel is uninitialized Message-ID: References: <20251204122825.756106-1-iuliana.prodan@oss.nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251204122825.756106-1-iuliana.prodan@oss.nxp.com> On Thu, Dec 04, 2025 at 02:28:23PM +0200, Iuliana Prodan (OSS) wrote: > From: Iuliana Prodan > > Firmwares that do not use mailbox communication (e.g., the hello_world > sample) leave priv->tx_ch as NULL. The current suspend logic > unconditionally sends RP_MBOX_SUSPEND_SYSTEM, which is invalid without > an initialized TX channel. > > Detect the no_mailboxes case early and skip sending the suspend > message. Instead, proceed directly to the runtime PM suspend path, > which is the correct behavior for firmwares that cannot respond to > mailbox requests. > > Signed-off-by: Iuliana Prodan > --- > Changes since v1: > - Wrapped commit message to 75 characters > - Changed dev_err to dev_dbg since this case is normal behavior > --- > drivers/remoteproc/imx_dsp_rproc.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > I have applied all 3 patches in this set. Next time, please consider adding a cover letter. Thanks, Mathieu > diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c > index 5130a35214c9..f51deaacc700 100644 > --- a/drivers/remoteproc/imx_dsp_rproc.c > +++ b/drivers/remoteproc/imx_dsp_rproc.c > @@ -1242,6 +1242,15 @@ static int imx_dsp_suspend(struct device *dev) > if (rproc->state != RPROC_RUNNING) > goto out; > > + /* > + * No channel available for sending messages; > + * indicates no mailboxes present, so trigger PM runtime suspend > + */ > + if (!priv->tx_ch) { > + dev_dbg(dev, "No initialized mbox tx channel, suspend directly.\n"); > + goto out; > + } > + > reinit_completion(&priv->pm_comp); > > /* Tell DSP that suspend is happening */ > -- > 2.25.1 >