mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philip Li <philip.li@intel.com>
To: David Gow <david@davidgow.net>
Cc: "kernel test robot" <lkp@intel.com>,
	oe-kbuild@lists.linux.dev,
	"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Daniel Gomez" <da.gomez@samsung.com>,
	kunit-dev@googlegroups.com
Subject: Re: error[E0560]: struct `kunit_suite` has no field named `suite_init`
Date: Wed, 3 Dec 2025 22:23:49 +0800	[thread overview]
Message-ID: <aTBH9UjSHKOGihaY@rli9-mobl> (raw)
In-Reply-To: <86d2ea1f-810b-45a1-9ce0-ef571f6da0b9@davidgow.net>

On Wed, Dec 03, 2025 at 08:58:48PM +0800, David Gow wrote:
> Hi all,
> 
> Le 03/12/2025 à 7:45 PM, kernel test robot a écrit :
> > ::::::
> > :::::: Manual check reason: "arm-randconfig-r121-20251201 results in various rust failures"
> > ::::::
> > 
> > BCC: lkp@intel.com
> > CC: oe-kbuild-all@lists.linux.dev
> > CC: linux-kernel@vger.kernel.org
> > TO: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
> > CC: Daniel Gomez <da.gomez@samsung.com>
> > 
> > Hi Thomas,
> > 
> > FYI, the error/warning still remains.
> > 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head:   3f9f0252130e7dd60d41be0802bf58f6471c691d
> > commit: 818783c804bc051f7faf0ac226b5597f8259c6f8 module: make structure definitions always visible
> > date:   4 months ago
> > :::::: branch date: 9 hours ago
> > :::::: commit date: 4 months ago
> > config: arm-randconfig-r121-20251201 (https://download.01.org/0day-ci/archive/20251203/202512031957.BoFx2PMx-lkp@intel.com/config)
> > compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project b3428bb966f1de8aa48375ffee0eba04ede133b7)
> > rustc: rustc 1.88.0 (6b00bc388 2025-06-23)
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251203/202512031957.BoFx2PMx-lkp@intel.com/reproduce)
> > 
> 
> The current best theory for the cause of these errors (which, alas, I've
> still not been able to reproduce locally) is the following bindgen bug:
> https://github.com/rust-lang/rust-bindgen/issues/3264
> 
> bindgen 0.72.1 has been released to fix this issue:
> https://github.com/rust-lang/rust-bindgen/releases/tag/v0.72.1
> 
> It looks like all of the test robot failures are from builds using both
> clang 22 and bindgen 0.72.0, which would meet the criteria for that bug. Is
> there any chance you could upgrade the bindgen version used and see if that
> makes the issues go away?

Thanks for the information, I will update bot logic to use 0.72.1 from now on
to avoid these kind of false positives.

> 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/r/202512031957.BoFx2PMx-lkp@intel.com/
> > 
> > All errors (new ones prefixed by >>):
> > 
> > > > error[E0560]: struct `kunit_suite` has no field named `suite_init`
> >     --> rust/kernel/kunit.rs:291:21
> >     |
> >     291  |                     suite_init: None,
> >     |                     ^^^^^^^^^^ `kunit_suite` does not have this field
> >     |
> >     ::: rust/kernel/alloc/kvec.rs:1244:1
> >     |
> >     1244 | #[macros::kunit_tests(rust_kvec_kunit)]
> >     | --------------------------------------- in this procedural macro expansion
> >     |
> >     = note: all struct fields are already assigned
> >     = note: this error originates in the macro `::kernel::kunit_unsafe_test_suite` which comes from the expansion of the attribute macro `macros::kunit_tests` (in Nightly builds, run with -Z macro-backtrace for more info)
> > --
> > > > error[E0560]: struct `kunit_suite` has no field named `suite_exit`
> >     --> rust/kernel/kunit.rs:292:21
> >     |
> >     292  |                     suite_exit: None,
> >     |                     ^^^^^^^^^^ `kunit_suite` does not have this field
> >     |
> >     ::: rust/kernel/alloc/kvec.rs:1244:1
> >     |
> >     1244 | #[macros::kunit_tests(rust_kvec_kunit)]
> >     | --------------------------------------- in this procedural macro expansion
> >     |
> >     = note: all struct fields are already assigned
> >     = note: this error originates in the macro `::kernel::kunit_unsafe_test_suite` which comes from the expansion of the attribute macro `macros::kunit_tests` (in Nightly builds, run with -Z macro-backtrace for more info)
> > --
> 
> (...)
> 
> Cheers,
> -- David
> 

      reply	other threads:[~2025-12-03 14:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <202512031957.BoFx2PMx-lkp@intel.com>
2025-12-03 12:58 ` David Gow
2025-12-03 14:23   ` Philip Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aTBH9UjSHKOGihaY@rli9-mobl \
    --to=philip.li@intel.com \
    --cc=da.gomez@samsung.com \
    --cc=david@davidgow.net \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=oe-kbuild@lists.linux.dev \
    --cc=thomas.weissschuh@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®