From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from honk.sigxcpu.org (honk.sigxcpu.org [24.134.29.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C93522BE632 for ; Thu, 4 Dec 2025 10:23:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=24.134.29.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764843798; cv=none; b=csWmCqpHIJxdmFBFkp8n5HxsPfvx8j6DIqp9NYIlpPqH1EoChUefVVpl16qZ0mCegcpoSgSGjx+XSTpmMIo781PSLVQsZrvlj2jUV0jygVDvXNC1/4gpw/K+zEdMTTcxbaHrRJLO5TevvuRy41YMZCKhuyMfqVRDRSogztst87g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764843798; c=relaxed/simple; bh=UeOw/ARrHPv6xrGasuUY7S88OnbZfA31zOs7DVv9hag=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Y4hSNdfe8UkWZuJ4UOq5WnZl/G5w8uxBZ3RPOw03igdMpJB8EQuPpvO+SQ/7SWSofgrrvx9Eg0CDhdMSy5O0KwEh2Fxw8brbIHoTDV8PbqajanFZeAoH4L8vSBw5tF3FyeZGhoiy77my0pKMvop6Y++kFcYS7oc5n7qCBwUwPDI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sigxcpu.org; spf=pass smtp.mailfrom=sigxcpu.org; dkim=pass (2048-bit key) header.d=sigxcpu.org header.i=@sigxcpu.org header.b=XFx14s3O; dkim=pass (2048-bit key) header.d=sigxcpu.org header.i=@sigxcpu.org header.b=b/D8pXTl; arc=none smtp.client-ip=24.134.29.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sigxcpu.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sigxcpu.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sigxcpu.org header.i=@sigxcpu.org header.b="XFx14s3O"; dkim=pass (2048-bit key) header.d=sigxcpu.org header.i=@sigxcpu.org header.b="b/D8pXTl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=sigxcpu.org; s=2024; t=1764843786; bh=UeOw/ARrHPv6xrGasuUY7S88OnbZfA31zOs7DVv9hag=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XFx14s3O+agBfLWStyMI5xyBEhX5K2ZytHWOErrY7hpMd0vwLhHcDMR8ND2VcEz+f FsyIr4133Bb/9AlrQkcCKKFfYqzKkOkWLfpBtzF+DHQ3Ee6GhT0QjeJH0wHhSC0Bli KPv8YFFYYfTF6XzSWuhWdHbx585zE3GGl0uFrJKBwfgobg32E0i3XsuXCrEO5UDBip tuCw+qwV2Uia3EpaU7TYRuj2NRMUqRXID9M/Ssh/pIFwSaQjalg7nottRm37FL8i4I G+KTTzNtv/e1KNhZ0xovsFok4IC9Fv13c9fXRcITIFR1z42ulzjgpn4uhbkffbvoBA wejifch0NzbEQ== Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id 3B181FB03; Thu, 4 Dec 2025 11:23:06 +0100 (CET) Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0LezK-AyUMc6; Thu, 4 Dec 2025 11:23:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=sigxcpu.org; s=2024; t=1764843784; bh=UeOw/ARrHPv6xrGasuUY7S88OnbZfA31zOs7DVv9hag=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b/D8pXTl17XvvMe8Cf8/8UIkoNMvhjGFexhoFqWxMi1iUnb+ksTLjG6RZ90jMzy3H 9P8jMovI1/5fUkAiwNKGlrr6S/+ZXV/dR5iXHZJKwgPB+/UOyIrGstAoANOeWv9dTP nK3SW5HDn8jfcxwcxv9E10+XwbWfvnfg4HYfiiRMyt9IshOs8HMzkGnQ/zkHjmcHvJ sMPxo0xfsmi8HEsuc4ozusIwfKMlPeva+11iShy7jKYGFvkoEyaGXBCmWlBYpSTkXE f1LWnQbkXt9m031v24rhVhfPRWQDAVbZl2m9dC8lkCEBxt3jmHbbS9ZqmqVN9xkG1F 4aJn3i8VMBJig== Date: Thu, 4 Dec 2025 11:23:02 +0100 From: Guido =?iso-8859-1?Q?G=FCnther?= To: Arnd Bergmann Cc: Neil Armstrong , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Baryshkov , Arnd Bergmann , Jessica Zhang , Svyatoslav Ryhel , David Heidelberg , Linus Walleij , Kaustabh Chakraborty , Maxim Schwalm , AngeloGioacchino Del Regno , Colin Ian King , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/panel: visionox-rm69299: add backlight dependency Message-ID: References: <20251204094734.1031114-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251204094734.1031114-1-arnd@kernel.org> Hi, On Thu, Dec 04, 2025 at 10:47:26AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The recently added backlight support breaks when CONFIG_BACKLIGHT_CLASS_DEVICE > is turned off: > > arm-linux-gnueabi-ld: drivers/gpu/drm/panel/panel-visionox-rm69299.o: in function `visionox_rm69299_probe': > panel-visionox-rm69299.c:(.text.visionox_rm69299_probe+0x92): undefined reference to `devm_backlight_device_register' > arm-linux-gnueabi-ld: (devm_backlight_device_register): Unknown destination type (ARM/Thumb) in drivers/gpu/drm/panel/panel-visionox-rm69299.o > > Add the appropriate Kconfig dependency. > > Fixes: 7911d8cab554 ("drm/panel: visionox-rm69299: Add backlight support") > Signed-off-by: Arnd Bergmann Thanks for looking at this. This is a duplicate of https://lore.kernel.org/phone-devel/20251017-visionox-rm69299-bl-v2-1-9dfa06606754@sigxcpu.org/ though, idk why it didn't get applied. Cheers, -- Guido > --- > drivers/gpu/drm/panel/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > index 76f6af819037..2923148dcf07 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -1163,6 +1163,7 @@ config DRM_PANEL_VISIONOX_R66451 > > config DRM_PANEL_VISIONOX_RM69299 > tristate "Visionox RM69299" > + depends on BACKLIGHT_CLASS_DEVICE > depends on OF > depends on DRM_MIPI_DSI > help > -- > 2.39.5 >