From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8008C70808 for ; Thu, 4 Dec 2025 16:13:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764864818; cv=none; b=uGLTP54Cu7lKUbausiVA7SAxCGQlXfURIPbPn4JPkrzEVzRli6Docd76UD+D2lThubBQdH3P79xO5QvvMel6B2lSPXl+4eFWVEU4hC3JlEUW43Aq6JrrCcHS6gJ9wZ+6SxgStSiNPtXELwKKyGQyPcLYaZsOStdGxPLVp5VJdbE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764864818; c=relaxed/simple; bh=dPa40n5AKnKlrNlskv/FUjA9yCvquwkpnHnyVW3i2pQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lzjqupunVTvEy5wOPvS3WS40MP3zxDCrJFFJPdzKPr0i1c3oJuvqxXm2+fyYlGGj1xgJ2f27zOhHWPnKvtKVzYO2PV9fFF9qOzMTMHmcrGarHW5RiDDwVL1eb2cc80vIsl30FLvOiFEOyzqsyBLj77LZ09UFcPkk94o5TC44kMk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=APSJURr2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="APSJURr2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8F52C116B1; Thu, 4 Dec 2025 16:13:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764864818; bh=dPa40n5AKnKlrNlskv/FUjA9yCvquwkpnHnyVW3i2pQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=APSJURr2VsYUmQRuuI7QLaGcGJGCE4vCbvyU3CQ244nrd3+qrF7qbKoAUZtFtMZHl GfLjSlT8zM8wC5tUOB4bxo1kHvJkvcLrCDbxaYYme9h8hLgSqnxcNncy5N7f5VkmHW KzU/6/Jr30FRLlpAstZFrujNt6Z6yCSUAyrY8qlZO5JBExfQJoqypwqkK1Zvr8VoCa vXz0agwnynKggj2VOkqvK1veO1D3VbfT1Le3pkW9e8nAcdk6niLSK2cYhW9BSSPZip afinCwdcFiE1TgYEGVV5gNGd5otFARDslNklh+K+06oVx/Pr7BicswcigIso43dME7 9VqAdNtwqwj/w== Date: Thu, 4 Dec 2025 09:13:35 -0700 From: Keith Busch To: "Heyne, Maximilian" Cc: Jens Axboe , Christoph Hellwig , Sagi Grimberg , "linux-nvme@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] nvme: Let the blocklayer set timeouts for requests Message-ID: References: <20251204-tests-bryce-8b3b2823@mheyne-amazon> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251204-tests-bryce-8b3b2823@mheyne-amazon> On Thu, Dec 04, 2025 at 02:11:50PM +0000, Heyne, Maximilian wrote: > @@ -724,10 +724,8 @@ void nvme_init_request(struct request *req, struct nvme_command *cmd) > struct nvme_ns *ns = req->q->disk->private_data; > > logging_enabled = ns->head->passthru_err_log_enabled; > - req->timeout = NVME_IO_TIMEOUT; > } else { /* no queuedata implies admin queue */ > logging_enabled = nr->ctrl->passthru_err_log_enabled; > - req->timeout = NVME_ADMIN_TIMEOUT; > } I was trying to think of any in-kernel path using __submit_sync_cmd with an IO queue, and quick search shows there's just one: zns report zones. Everything else uses the admin queue, which doesn't have a sysfs tunable for its request_queue's default timeout. All we have is the nvme module parameter, which is writable after loading. Since that's the only way a user can modify the default time for that queue, I think we need to leave that req->timeout value as-is.