From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85E1135773A for ; Fri, 5 Dec 2025 07:27:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764919646; cv=none; b=na/HM4WJLqcqPVx0qbVr36BHbiNAHa3tjOxj6XezB19kLGAZUD1BXOQKNVy10bWGs13uWJi9fqESMS+cBYF4ANEX+VL7HCEeUq+hHYQ8/jh9z40Bin3xlzTOoMeCmOTi2wbxNFTkbu0WizpOEz0eWFXqL8wlGBO4Fuyyr5P1iA4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764919646; c=relaxed/simple; bh=CZILDV4rp3fLc54B2oxY0hTvE2X2XCFxhFLW4l/1SRw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=usf28RFoY+d/REbqYM03AmSnNqNk1R5giVB+V6xGyUNSr+cbaDg2SuCak3MIazj57gR1p9QYeWnNKorRiLZhDVxJXPAVzcliS6ZG1TNVVDxgcKi7B7uuwdI6D64Ejy2fFbsx3cH9u/nXZTby8LIOs79iUesteoaspzh2xLJIhEk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=aVAwvR3/; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aVAwvR3/" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-42b3c965cc4so840090f8f.0 for ; Thu, 04 Dec 2025 23:27:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764919630; x=1765524430; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cmdMp8pUxPj98ZnQAz0LAJJcQfL1Jq/MIx9tUtAqMG0=; b=aVAwvR3//XR32CYoRlZzr+FtqbslLXyBdiEgA5GUAsBujcyS+bIGQYha2zxDpw6HK+ J5QDZZ0oXF9wm6MYvMAMrItXOZzm7bw0qOc1RElYDnc3bI+60PRvBfAhli1/9lT5IGMF 3c67Nop7MAfjUn+S96vTiDdF0w8YGsy7IY9opHVtGl4cXh+KdIcOpdE+l2LwoQJeU6Jj ZKN8D7RwFZsiHlkM+Z6FsJ70tl+AFo3wgJYEcwyGTl0p3/sI+iTSlpJ7lhbykff9tbwb pW0u9ItmqmARV/S2frinxIsmWoRbmYs0FCz+lStN9mIBosskBHDFLuuQtK+21VZprFyA cbrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764919630; x=1765524430; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cmdMp8pUxPj98ZnQAz0LAJJcQfL1Jq/MIx9tUtAqMG0=; b=RorIfi9AH080zc19nKXC9E06Y8CVTWG0vUhXXf6DOWGVhwiwv4d7vdVSJMGi4WMTdv dISQbRmuvA9HcEHIPJvuqP0eEluihcZ9T+1JdYBSvYJnDX/1HfWReFIzuFLKWfOLLeMA qmY1ZSLLgiqCVF1ciw3sUdM4IjwJV5kvH8hUcvC3avB9CEdZBMWo/1ACo9QeBeZLDaDz TKAQIL5YdrzPOiwId9dhHyQmq32/Qn2XkKb8AmuFbJ1Bjdq8Z6otFBRKr6UmOxnxg9ex PayFhUZ7fdUnZV+3dGjFZLOt+MVtrcxDebkLkx6YF8hLS2pS5rO9nUj/K309c15wYLwT 4bfA== X-Forwarded-Encrypted: i=1; AJvYcCXq9r47fJguKt9hSHORlDSFD6Jxan41iwRn5hLu+co2kBW0HaioTSdJe82o6R6HM7i4Q1+VJfhuJwjJzoE=@vger.kernel.org X-Gm-Message-State: AOJu0YwdkzOG6UZ3wE81oYUH1hlCF6WCKsvpyqTctp1LI7eQx0qouTQU XihBx/iN5ciZQtNtm0ZhsqSAd6BvFojTrQEYN6509OPItxjaQbao19y/5Yt7wWAqldo= X-Gm-Gg: ASbGncvvSHdDaYkel9uPRC2rJMsC42PJNzUDvOimpZoZa7BfHPzUPKEF5CwDL6PZtnJ MwhF6JAQGjUZHY+v00yI16/2+v7m+EYrYabu8y8Pmuq47CCdVm4p+cBxvAnidHsBoV8c3Nu7Nle 16M+aWk3vF6F8wJnLn1r64qQYdJZcG/4ncldBwDUzOX2n3axdRH034w2a20rmC1/5ugnZ4Ey+JB 3q+zOOgCSsS4aVFoUWKAZwc9xiFb3kGkZRWCpYexA75BOyTNp45Ox+Bnmc4EDWvsP6mW9JwfLJ4 WiplwBdO3KlXuuHY7PyAtG8RF6n5ybU33rw2VetpOtjxDX53oenI2fd9UEPYzKkPVOSOdUGmzye QBWdcUrJRufxe/rpjNXXYR22GjLNKhq7Iw58JtEtwVHKC+cbsdYoPSLTFijjkhYMI//tQZBavfa Cn29ENDQHyClPzMHZQ X-Google-Smtp-Source: AGHT+IFBK31HtXZveFNyUwIRCfd9avIi+htsMbaBgOkfxItSOeqhFcRvaUxPxjnEtb200nCr3ZDiJg== X-Received: by 2002:a05:6000:608:b0:3e7:6424:1b47 with SMTP id ffacd0b85a97d-42f7875f62dmr6797375f8f.6.1764919629821; Thu, 04 Dec 2025 23:27:09 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42f7d3319ccsm7010344f8f.34.2025.12.04.23.27.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Dec 2025 23:27:09 -0800 (PST) Date: Fri, 5 Dec 2025 10:27:06 +0300 From: Dan Carpenter To: Julioccps Cc: hvaibhav.linux@gmail.com, johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] staging: greybus: arche-apb-ctrl: switch to device_property_read_bool Message-ID: References: <20251204231753.66229-1-julio191096@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251204231753.66229-1-julio191096@gmail.com> On Thu, Dec 04, 2025 at 08:17:53PM -0300, Julioccps wrote: > Switch from the deprecated of_property_read_bool() to the common > device_property_read_bool() API. This makes the driver agnostic to > the underlying firmware interface (DT or ACPI) and simplifies the > logic. > > Since the driver is no longer strictly dependent on Device Tree, > include directly for the struct > of_device_id definition, instead of relying on implicit inclusion > via , which has been removed as it is unused. > > Also rename apb_ctrl_get_devtree_data() to apb_ctrl_get_fw_data() > to better reflect the agnostic nature of the new implementation. > > Signed-off-by: Julio Cesar Carvalho de Paula Souza > --- Same comments as v3. regards, dan carpenter