From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Dragos Bogdan" <dragos.bogdan@analog.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v4 2/2] iio: frequency: adf4377: add clk provider support
Date: Fri, 5 Dec 2025 17:07:44 +0200 [thread overview]
Message-ID: <aTL1QB1hPOkU0MJG@smile.fi.intel.com> (raw)
In-Reply-To: <20251205143848.989-3-antoniu.miclaus@analog.com>
On Fri, Dec 05, 2025 at 04:38:46PM +0200, Antoniu Miclaus wrote:
> Add clk provider feature for the adf4377.
>
> Even though the driver was sent as an IIO driver in most cases the
> device is actually seen as a clock provider.
>
> This patch aims to cover actual usecases requested by users in order to
> completely control the output frequencies from userspace.
Now LGTM, thanks
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
...
> #include <linux/bitfield.h>
> #include <linux/bits.h>
> #include <linux/clk.h>
> +#include <linux/clk-provider.h>
> #include <linux/clkdev.h>
+ container_of.h
> #include <linux/delay.h>
> #include <linux/device.h>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-12-05 15:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-05 14:38 [PATCH v4 0/2] This series adds clock provider functionality to the ADF4377 frequency Antoniu Miclaus
2025-12-05 14:38 ` [PATCH v4 1/2] dt-bindings: iio: frequency: adf4377: add clk provider Antoniu Miclaus
2025-12-05 14:38 ` [PATCH v4 2/2] iio: frequency: adf4377: add clk provider support Antoniu Miclaus
2025-12-05 15:07 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTL1QB1hPOkU0MJG@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=dragos.bogdan@analog.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-clk@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®