From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB9DD27A12B for ; Fri, 5 Dec 2025 17:33:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764956009; cv=none; b=NiYhgxzFJJa2leYCbztcXemnNuKB7iPFZhim63/8R5mVeNGe/LCXvSxwRm3P+/Yet58acj8EuGKEyPyrfrP/V1ozqayzwcB1vrJdJZKu1W6QAUC5mSDUKGNwW+ljBrJIlGaqXn7Qw8JouMPu5jgOFgFNF/+Or8m5jTzHkLlCRrI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764956009; c=relaxed/simple; bh=eB9+/Eym8/sl6sVLo+TtE0s7XKYj4AnzHDQpqXfgiDA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fc7t8/yWohiao1bxc74tOdR2bOEAv1EqWfVEQZfo45nmhGsigGS6GqnIzNwuIQszegIrJsmOBfAaOWvHJujkc2a6YMwhL4NFx9jtAhxf1XqRlFbaPa+ITy4aVZFsUd9zJBuJ3k8htgqPXyvHGYsIkdmmeLzBtaBsCvsPFjEg22o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=xdFUrQpE; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="xdFUrQpE" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-42b32ff5d10so2254149f8f.1 for ; Fri, 05 Dec 2025 09:33:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1764956005; x=1765560805; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=amtNQuwco1BO2PnhLkDFqIyQgPKVg/vOsmaYbePwmG4=; b=xdFUrQpEygW9kfCFezSYsTLHAgyOhGlvJzf0GuG1tHvN0OS3w2IkkGNJFuFRz9IrKX 6bUIy/YBVP3wg+oa2BWbEmP0uvk3Auu+1VOtgY6UtJx3yxzi29uH8D5oCVIBX+pgTq1+ UwfoPTQMx+yx7/W7hpiTkzV1WXwHwKVi5V+iWurbSUZnra+H6ZrRJ7ldVEr2LZV2qSdb oVX+fdRZ3LKF1PoftqN8oPBTxhVZNViBqLn85vN58rm4phKKPhUCF7m6OtQogtabvsot rgx6GjHujpCfWK2DAWi+fTS1jUeNdFbpRapgFzs0lleQc7MPXf9AqET2gSogEKpwcw3w ejqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764956005; x=1765560805; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=amtNQuwco1BO2PnhLkDFqIyQgPKVg/vOsmaYbePwmG4=; b=fj7MfQcXhxErU6D2VaS2lHAFPkpQnLzkIYP/5D37Lka+7kWVcTBcrFlnUkFG6IV0Pe CzMnziIFuCh/KHPGHA4hXq5FsY3TX7B/FRqPKEvLwPYfZFG6JTFaVlkQ3727fei7DpUU IMDDp7WcHafQOVkxwgQgfrJkfjuDFhMt4TKJsOSXOccIDsXQa2gaJmSvunktZcIJ6oVN lEbSoeM/kLgoQZmNWO49OvnAJu0JSVbHlRqhWmzyqqjriJ3Gr48x97NCNVlY7q5NHPus hdxSyt4RhvvoUETViBNXYphzqp0xMhALOkXs+Hb7xww1goGFR4yxWt3TFX712ratChkU NJUw== X-Forwarded-Encrypted: i=1; AJvYcCVEy4e8x70N57KyxN3ZVXjf8CiolOZK6vQTAaeBKXhpKQBX+Jk6Psdky1cFl8IxIr7PzCxdNwNbfqi7vIQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1wx1+FUQt+H/UQIqlTCHltrjvS9y31qPjNxSDtGkEA9niNW6E iZPtx8m4pbUP5OaBYBXcgd4tbfEhCXWe6IK0wJ2FpFEcHfaL8PCBE2PQPzu3knYQog== X-Gm-Gg: ASbGnctmL301qX285WLlc9Y6XiZxmtvcbPPfzcvGE1FV3hhwhYRyQwhSUATh1gX+/2L k+hZYdcjvNs2tiTgD1GqajYz9DawWYky4Vs5vuAVgHdfXLxkMh7Uob6fLqxyQsbp5zaWGqlxJ2m e/pnVDsEiO+1ioc4RS0U34/9pxsmzpKiG33Z3rpZk1/fou1ydQPF5pDHkaJwgyQKiXuIN/LpNi3 /7BWP6gex+MWUIt7BTrpHLeenU/EIOr8RFctPqewxwZbRLXpFQX80jfk5AEr2mo7ee6nXDCaB+k XZMIRKu7tdoJPHnDDNCNMMCKZuZTBBx3UlAtTddFFOavmDh9tK7P2jhDeTk5oHFCzlTyNCX/8mV fdvykgtiy+331qxeHRM5r5RuaNs+rWi8/OFeok156LW2LENNJ5aIBqv+3RAVKmYac19eYsMBNmx xglLLkCxyy8WM1Z9Y8+LHSfrW6yxQGSI6KwtHs3nziKHclHcG0QQ== X-Google-Smtp-Source: AGHT+IG7GHbywu/ls/wVemuOmr6xVx9MQPax08/Ei7Uq0ye9NoSzMgiNsTxCLJQTc1fcXLx9fTdYtw== X-Received: by 2002:a5d:64e3:0:b0:429:cf03:8b2e with SMTP id ffacd0b85a97d-42f89ecee3fmr43760f8f.13.1764956004866; Fri, 05 Dec 2025 09:33:24 -0800 (PST) Received: from google.com (120.54.38.34.bc.googleusercontent.com. [34.38.54.120]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42f7d2226d0sm9793222f8f.21.2025.12.05.09.33.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Dec 2025 09:33:24 -0800 (PST) Date: Fri, 5 Dec 2025 17:33:21 +0000 From: Vincent Donnefort To: Jack Thomson Cc: maz@kernel.org, oliver.upton@linux.dev, pbonzini@redhat.com, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, shuah@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, isaku.yamahata@intel.com, xmarcalx@amazon.co.uk, kalyazin@amazon.co.uk, jackabt@amazon.com Subject: Re: [PATCH v3 2/3] KVM: selftests: Enable pre_fault_memory_test for arm64 Message-ID: References: <20251119154910.97716-1-jackabt.amazon@gmail.com> <20251119154910.97716-3-jackabt.amazon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251119154910.97716-3-jackabt.amazon@gmail.com> On Wed, Nov 19, 2025 at 03:49:09PM +0000, Jack Thomson wrote: > From: Jack Thomson > > Enable the pre_fault_memory_test to run on arm64 by making it work with > different guest page sizes and testing multiple guest configurations. > > Update the test_assert to compare against the UCALL_EXIT_REASON, for > portability, as arm64 exits with KVM_EXIT_MMIO while x86 uses > KVM_EXIT_IO. > > Signed-off-by: Jack Thomson > --- > tools/testing/selftests/kvm/Makefile.kvm | 1 + > .../selftests/kvm/pre_fault_memory_test.c | 78 ++++++++++++++----- > 2 files changed, 58 insertions(+), 21 deletions(-) > > diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selftests/kvm/Makefile.kvm > index 148d427ff24b..0ddd8db60197 100644 > --- a/tools/testing/selftests/kvm/Makefile.kvm > +++ b/tools/testing/selftests/kvm/Makefile.kvm > @@ -183,6 +183,7 @@ TEST_GEN_PROGS_arm64 += memslot_perf_test > TEST_GEN_PROGS_arm64 += mmu_stress_test > TEST_GEN_PROGS_arm64 += rseq_test > TEST_GEN_PROGS_arm64 += steal_time > +TEST_GEN_PROGS_arm64 += pre_fault_memory_test > > TEST_GEN_PROGS_s390 = $(TEST_GEN_PROGS_COMMON) > TEST_GEN_PROGS_s390 += s390/memop > diff --git a/tools/testing/selftests/kvm/pre_fault_memory_test.c b/tools/testing/selftests/kvm/pre_fault_memory_test.c > index f04768c1d2e4..674931e7bb3a 100644 > --- a/tools/testing/selftests/kvm/pre_fault_memory_test.c > +++ b/tools/testing/selftests/kvm/pre_fault_memory_test.c > @@ -11,19 +11,29 @@ > #include > #include > #include > +#include > > /* Arbitrarily chosen values */ > -#define TEST_SIZE (SZ_2M + PAGE_SIZE) > -#define TEST_NPAGES (TEST_SIZE / PAGE_SIZE) After applying on top of the base commit 8a4821412cf2c1429fffa07c012dd150f2edf78c, it does not build. That TEST_NPAGES seems to still be used in delete_slot_worker(). I believe that's because of "KVM: selftests: Test prefault memory during concurrent memslot removal" Related issues with the pre_fault_memory() prototype. Is that the correct base-commit or shall I use something else? > +#define TEST_BASE_SIZE SZ_2M > #define TEST_SLOT 10 > [...]