From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F9ED2DCF61 for ; Wed, 10 Dec 2025 09:51:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765360269; cv=none; b=Ic4OZm6imKfszQneoKPyNN6ax3nWYGmACxfUADzStC0JFaoO3yHQMk1jpX+mVQm1XTctmrQf+eyj+2UHAzOrcbgwUq72YqPY3hy32kPiBVXAmBoN4/S782CyeiKEeZAgNVFMMQKyLFW0TMGrOX5Pu52SDgUC0X9sUmEyfe8nvaQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765360269; c=relaxed/simple; bh=x0Xy004ajIQ6LdE02hLKph2/qBXwTL7ZBVlAQEUVqUI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=H9d4Xbu6IE5dQ+IQH8R5Kg+GSze0G8aQUAR2adXOSRzfpkkZ/lKTVoWSIdeFmFoRlhRWbnDCvCBkzcUuSjHz6djP3Szsgc6+wN2zjbSnHsX8963rhX5pRVMUawlB1kaI89OMoMyzQmDQ3hH421/VTicFzNpNXYUj+m0qXpnil14= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=qpJA70vh; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qpJA70vh" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-477a1c28778so80985005e9.3 for ; Wed, 10 Dec 2025 01:51:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765360266; x=1765965066; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4B06qbhBhVCFFua5ibBTjFTdBd800LgTE6bPjUyYBuc=; b=qpJA70vhLdFTCvydBBvkwTE6luZk4XWwWvxrse3RKjaAsQghF05bPNfP2pQeUTmZOd L8D5WlNHrxEWU4yW3jNFrQU+ewnjaQAh4mUoFe31Tr2FnFe9JxXPi1uSs7mST4Xvnkpr yIvKu/SdBA0WY5tf3W8JcosovQM3iOnEpwKx2H8BToqVO2q+SbYDn9FnuNmPL7D7bGQQ /LnpE/klDfJ1XzL1sZExNJMEbymKr/houDI+oEV+K1Ic9EicJ4fKzzwsSmZSa/qrpyg+ VwQDpNeqEEsTgxw/7wGf5m38zuzTgLd21LbJRdZ1fUrZTItw/fXlwvCeIs8QIMK4VPCn yKAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765360266; x=1765965066; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4B06qbhBhVCFFua5ibBTjFTdBd800LgTE6bPjUyYBuc=; b=XblboiwRy8ui9sk2A/LOsi0J0dhRyrztRIzQx1rtTZoyfvRHVh9jkrYBNQjiLuYWqP Vww0ov0LN/4nRXV65zB7xmPPnyueMonQT5iyjghU+LPqom83COyPNpky52bzaFo93AfC exnlAaWJa/h9HMO0SfCuOA2tUS51EQflNp0AcCh1s7pHuqNU+M5Js3auALwikfsstcyU UmEBelej22dZ2AOEEdFsr6sMSQ08a9i5XD5DdnFZm8ZUu9+Hy7NV3wIVcuaz/9wZ6cwp LnTXje8DcPozrzTyEnOoGvcA7qgzPDZtJH/6FLQRBl2oQSyxWrahNf6yHPTkEIfo0dKn sFpg== X-Forwarded-Encrypted: i=1; AJvYcCWUbF8QmrmPmQt+ItjdQrfcq9IuTb9NTFUAkB1prlUYtppwGoQ3upK2/wKZtw0cz5JOnwd6oaloVzwU0pc=@vger.kernel.org X-Gm-Message-State: AOJu0YwTMyOKpsYEEaJUU8RNSFg3hTKX60DpNG3CAwSGWsuAY9bj3akn MiPvDHxx1QRfY53MQxlQNAAxyg58/6Ge3I72WpVLwAgH0Ow8IOsi8cjn7g7Q4ksmZeE= X-Gm-Gg: ASbGncuvxHgJKWCCa0LiygmBWtJjajKQkbK8CzTIy2rOTQgnlKwlvBoWE3vkuythvwp aJnCMjnXt4kZk2BvXjXhb58vDgKdXsrKpMXc8fuXjQriO1ZDnaLa0BO0lQv88src4YIB/vepk9w e9bw4Ah5V6HT2RQLQ9R3wd9a/s5i/VsCZ2wR9ttjL5v7vDtVEZSsVo1ptPZe6rFepHCu5nw/+Vm IL5YgUGsMdxcbBQoHAnFnwBTIQte6fEGTED+M/C/SRM7zNZ6yEQImS29FOqAhuWq/S45X+4Zy2J +dHOwPQmGtnglHQ1/TZsKkIO2bKGKB3AuXxJi8Pfxl4J+k1XhDdAtqEYqNuaIll+Ub0/YUxO8sy UrDcr7mcTf6YRTe3Wpksb2tfMUTHgxXK/sUaPvvt/Gj3SVRQDZlJYBFyxIIvCWkM9mVh1UQvf8K JY3WhHfiBukl0F47ok X-Google-Smtp-Source: AGHT+IFa/d2xPjcJ3GR9qiSLMDjzB7aq+qWaEk40sAjfzUvXODCPSHM38QrBJnIpCEE25wsU6L4OLQ== X-Received: by 2002:a05:600c:3e8d:b0:477:b642:9dc1 with SMTP id 5b1f17b1804b1-47a8378ce43mr15130005e9.20.1765360265752; Wed, 10 Dec 2025 01:51:05 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42f7d222478sm36232021f8f.20.2025.12.10.01.51.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Dec 2025 01:51:05 -0800 (PST) Date: Wed, 10 Dec 2025 12:51:01 +0300 From: Dan Carpenter To: Dharanitharan R Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, david.laight.linux@gmail.com Subject: Re: [PATCH v3] staging: vme_user: simplify bus number allocation using ffz() Message-ID: References: <20251210094207.33671-2-dharanitharan725@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251210094207.33671-2-dharanitharan725@gmail.com> On Wed, Dec 10, 2025 at 09:42:08AM +0000, Dharanitharan R wrote: > David Laight pointed out that the loop in vme_register_bridge() > is effectively searching for the first zero bit in vme_bus_numbers. > Add a check for vme_bus_numbers == ~0UL before calling ffz(). > > Replace the manual loop with ffz() and use BIT(n) for consistency. > > Suggested-by: David Laight > Signed-off-by: Dharanitharan R > --- The patch is corrupted somehow and doesn't apply. patching file drivers/staging/vme_user/vme.c patch: **** malformed patch at line 204: return ret; regards, dan carpenter