From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 649402264BB for ; Wed, 10 Dec 2025 11:17:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765365469; cv=none; b=oBZPXYKmFuu5lMMDHbhkPWAj8mwcB3wlCkUL1cwaOHQB81XFsmeyhiyAMTNBRQDxAt1CuWF9ymZvRWxgAb5jR0cG+fWoaRBajTayKwCP2jTDeZ6x/Qv9L4RbTebUprLmnopF6lFZ79Yo8BunsePsOV7jjOQVyviSzlP0DzZZEoc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765365469; c=relaxed/simple; bh=VhhskE+UrPrQZfzGKLnNT8yvDHfR+4/N3Neta1ivHII=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nzgPkMgE/MNg8VNiNX/a1KOEkofcBh7ZDOu7uZRSHJLIf9CvEmwLc8TktDvg4Z+Hi0fQ7wvqsUqdGRWMpxe46IgXTgFiEEQ6NdQiDWIaVRN+jHQayamZlva/FoFTgs5cu+fyNrtUB4pfpzJ67vykEnkcr9l2ByB0FDhTRbwFg6E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=XBqx0gmA; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XBqx0gmA" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4779cb0a33fso89330745e9.0 for ; Wed, 10 Dec 2025 03:17:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765365466; x=1765970266; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tWMTnjoX007imdOqG+awD8ZozCQofkYnKJOG9L7fHGw=; b=XBqx0gmAK0OeHruAi1pEly0IBT+4TKbTN/9QG3NiKCc4ANSRUeEjL1tGYsnYbFWRhY 8dLblpZWQ+SkcKRud0k8nXSkwWn3U7jAmBbzkSsTsu0QIfUjmbLvcOjK3aMX4Xs+Tt21 64OYlKlCGcCR1tHtjCUHof6SmFG/qx0gHezR5OjioltbodRQdfPC6kzVI+aWlS+3uAtM MU1e8K0yvZFcpISgZbFzR00RM4L5l0ndiPlEtHF3ufZqJvhlilu1kgL4OW8x/MAcC2Y9 gOxq0WicPuqj9mO9CkPtp8GF9zy67QVCbsq4moik+KfVNnvmQvKjgcmORuI+y1w99I1L YmTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765365466; x=1765970266; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tWMTnjoX007imdOqG+awD8ZozCQofkYnKJOG9L7fHGw=; b=q7dp5alqMaJxxpz/QdYE8190ZcR7/61KmcZozdqwOYlMsYLjQgfvvikISTUc3+nnxT yB2J7dzo84na2MbL/DqEU/Ro+u2L0UT8a51u2UWzqA9f0yo5Hmg8baabyiG7UQocRHm0 3xozligHjIJ7oS/HZAFSHyVRpkuMJgLJzFjNTtcKh+kv5Akz7or679hY0uzQ5WkM6Bb7 2tX6rcqbqyIziVmdLuk5bAZj5vKOg2UcpuvE66vZkfJqrM4zZrmFHdoOm/nfTEn1TmrE NI1+6bXctSN5/jTG6AenN7WVXbauiHEM3+q4zhi3kMDwP9LDt8HPlczEN2r8POmibvn7 4i/A== X-Forwarded-Encrypted: i=1; AJvYcCUYhwB/IzVfocIbbkRpIV4GZCQfl2EU/afiVDNoEm6+ZgRb/JJa+g3+TfWwBsPMlqJrZKOhV2K67EdqXfA=@vger.kernel.org X-Gm-Message-State: AOJu0Yxtpn+3toyfdH+15lI1f8JeD0PRqP6dQ3GLKNECpqIrl83PNJf3 xMAg7zHpuhvE2CXVc/XElJ0ng6wkjh5vTaJLBShZgz/NztgVJ+5UmjzzAMwGy9I/KmI= X-Gm-Gg: AY/fxX7/eA2tmcz9TiwVwx/rNrO5+gHZduzOt3FJBaszYzB61ielFYLC99dJ6HfdLb/ eMi+vtnSBpWB7xsYj1H8k589x0cAuOlFMv2mfSIAaERYiPG2TMq+/XDOqXyHDhURuodQzDl3slR aalVGtgj0K9Uirmvt7b+GNpM8WjbTvMiAVLb7M5wmFeGryFZh9rMi0fKgSQkQLw6WMY6iMmzVh7 UZL3+XKoPGmIGvB70u2mnJFdsHvKWdHNC1uSquO21eKCgsTmhE/EKJoWdHSLd9fnRGM4Jwsil/j ePcfLQU7IxMcnzqZq67M5xsOZbp6WgSZBQOR2UwNSUBo2Y16K+EzyDb8KqxENAl6cZnB3t2NbRD yH+DotkTRb14hmkIPshv/YulNy0miq/v4zcDDAOxYp7+0wh+l8Bg6RJ8BGoxmPA03nXeOjZB3Ey YlwGahJdVgMip7RmDv1My1W7+Nq7s= X-Google-Smtp-Source: AGHT+IEkRitI5I6hXt/urNtM+ZX+S1SPKkUgxhsTnx2X1xj7hPM0gkF/kDMzUw20uPJaNdugGPHSXQ== X-Received: by 2002:a05:6000:2002:b0:42b:a40d:713d with SMTP id ffacd0b85a97d-42fa39d1d4bmr1813897f8f.21.1765365465633; Wed, 10 Dec 2025 03:17:45 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42f7d222478sm36672778f8f.20.2025.12.10.03.17.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Dec 2025 03:17:45 -0800 (PST) Date: Wed, 10 Dec 2025 14:17:41 +0300 From: Dan Carpenter To: Dharanitharan R Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, david.laight.linux@gmail.com Subject: Re: [PATCH v3] staging: vme_user: simplify bus number allocation using ffz() Message-ID: References: <20251210100023.33753-2-dharanitharan725@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251210100023.33753-2-dharanitharan725@gmail.com> On Wed, Dec 10, 2025 at 10:00:24AM +0000, Dharanitharan R wrote: > David Laight pointed out that the loop in vme_register_bridge() > is effectively searching for the first zero bit in vme_bus_numbers. > Add a check for vme_bus_numbers == ~0UL before calling ffz(). > > Replace the manual loop with ffz() and use BIT(n) for consistency. > > Suggested-by: David Laight > Signed-off-by: Dharanitharan R > --- You need to write a change log here after the --- cut off line. https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/ This still doesn't apply. regards, dan carpenter