From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 379A227703A for ; Thu, 11 Dec 2025 23:29:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765495767; cv=none; b=It+BkrUB0r5WBHsF74HLXpZilVWz9t3hcDAlgwgRSbTzSIVQZIlHXjIrv5AnfwwDkXT3AikYGpDjeKVqPoMKW2+TFh20JgFtUkW2iY2jx18mJ8sx/HFl+gqWmBPOK2qXmDzs3/YuPMsOL8rkqOlaDEE52iwg7i9hcxQaYv9hkhg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765495767; c=relaxed/simple; bh=1qzwV02bV09dOmCeHlRCyTatMjj2+lK51O7j6el49HQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KzzsWmvND9V5AH8Z2vjxLntJl71SPz+15L5bhLLIqKQoZ8CcF0odnbEXDrePbTmHjQOL7b/o2MVCSbV+ZN4w5UlAW7BbrWrETcnQiuaZYyWXZbiyZ9v+t2uvcMzZsIUVf1ImsK0eq+suq/D4Fc0uNoD1M3ND24dkjU1on+Ol0fQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PhkK7YBn; arc=none smtp.client-ip=209.85.219.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PhkK7YBn" Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-888490962d5so6668916d6.3 for ; Thu, 11 Dec 2025 15:29:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765495765; x=1766100565; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :feedback-id:from:to:cc:subject:date:message-id:reply-to; bh=dbJc1OJNTPxtfWwkX/KBFBuJPaakfzFAHuCWrkILadQ=; b=PhkK7YBn5IgtpJ28YHSi67JqKJNB0PE+VvmIgGve15qEGboy4vF3cJ5rsHYSEJMBzm rSELR21YINhV0KnLNFXakrwWyQLS1oi9vw4uk7pyw4xOZc8vsQE3ty8/gb6A6YtHe6Pc NVhbth5/5Se6/E/m8BmY0CRaWIFBiQggm55lhmuy1BZ6Wlac7e0z4XDWJ2BwK4W6qhG7 PiI1Gn22FRxRLG9Ag6HG0QtUCdBF5YYib5zESa8d5Nxzaq0G6nySVzOnFqFzsjUJ1/sw 3LFPLZFdOM3paK14Ktl1bVc8BB2FgH+ttCVVq50wA/qMbNV2ZpphtBgwSDdAM+zDf8Pe OWrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765495765; x=1766100565; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :feedback-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dbJc1OJNTPxtfWwkX/KBFBuJPaakfzFAHuCWrkILadQ=; b=G0QVa8pBHWtUpK4VgGA0stGt4/Dm809dN7KJDFgynDXIIosF3RtYKY5IZXuCqUwMfj 1YYC51p6PP1kEAvu6iLXBaVwH3EtUJyQQ9k06n2Un6oGnxjv9VGS7UZ7N9HaTjTMU4Ua pmyJdejhLjk774yH/GHZm1w/FGt6qtoYPQF+Qc/zsUkRXua6KXTAvlUeLadMsijwzeV3 D3dOs/mb+eGbB8PWVRRDdUcbyDW+TvzHYpKhdTB5CVWZ+lpRwWIcJ0TWJ2EZCLvYtDmK gkoyb3xwsltww0f3tCTxca4iug4E1/aWJBo0diLp/7dpwp34dCJUNVr6KCtZ7ovuDVSo LYGQ== X-Forwarded-Encrypted: i=1; AJvYcCXAVzyjiMxvRBrFeXr0x3Ao+H9b5NcwgxT7GcXNLxfIodZnA3hytfZgnT6eS/YhMxpHGiJWdO8nnvp9LKY=@vger.kernel.org X-Gm-Message-State: AOJu0YwH21XgpGSh1AKrI6TUIIgxRaYKQqQEfxIho1J/UnvbQK3g9NiY ATQUlW9LZh2Z3j0ma8ZkqHqg3SOsv8Sp25A5mNkDAqb7bDANtDulNK0h X-Gm-Gg: AY/fxX4fF3Y1OaSWljh7Mon0rs4sy7aPuweQzrE6eH/BRF6kfGUVVMn8UWkU1Ylsf9j b5F32Aj3OBFdYcbQDkd6UNmHE8sJURYRANyE6psMZrqdWatBL+EaYKkPiZrPG6BwAmvAZTBtw6e XLdH+4kRyAQh96AH7DIRPSvMBawMTPuMtee+hNwWUu26vFcNHAOu4OM+iIZSgCrDKr5T0mCN9J7 0/H5esyVQzDhfZ9wL4IsItESkLYTmfh1SGHuknaiD8v/ZTIGKEVvKzecDYpC23YJaT1zZ4GVQyL VV4lumWrgGI3YDtIKPEybfYeWiTVdEJf8utRxl8EXkKvTzuvthfuCDJGZgEVhIL8up55SVys6ky b2E/EhWRuGnftzxAPmwplJlDjZ3Co8qIdZmTWcIvDfvjTaqoGTiJYGS4K5uem2JmoiaafUXMMYC c5ynHnDUGQUB1pZUUtIIPxohhdJQNNgp3JT5Ir7GZOTzJh3Me80mT/GMiq6juzlwxH1okpgwTaX tt75+5RgQ4XhXrzgKqDAKX6lw== X-Google-Smtp-Source: AGHT+IHFf2LFvbLGYxx6dXxdC8TeQEz90eXcCSaH9CyHBqDy90aL+WQS6Oeg098hvM4Hg4X8L4RqsA== X-Received: by 2002:a05:6214:766:b0:882:437d:282d with SMTP id 6a1803df08f44-8887e0454c6mr7085056d6.30.1765495764727; Thu, 11 Dec 2025 15:29:24 -0800 (PST) Received: from fauth-a1-smtp.messagingengine.com (fauth-a1-smtp.messagingengine.com. [103.168.172.200]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8886ec5506bsm33737486d6.18.2025.12.11.15.29.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 15:29:24 -0800 (PST) Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfauth.phl.internal (Postfix) with ESMTP id 9DB57F40076; Thu, 11 Dec 2025 18:29:23 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Thu, 11 Dec 2025 18:29:23 -0500 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddvieeifecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpeffhffvvefukfhfgggtugfgjgesthekredttddtjeenucfhrhhomhepuehoqhhunhcu hfgvnhhguceosghoqhhunhdrfhgvnhhgsehgmhgrihhlrdgtohhmqeenucggtffrrghtth gvrhhnpeejhfeikeekffejgeegueevffdtgeefudetleegjeelvdffteeihfelfeehvdeg keenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepsghoqhhunhdomhgvshhmthhprghuthhhphgv rhhsohhnrghlihhthidqieelvdeghedtieegqddujeejkeehheehvddqsghoqhhunhdrfh gvnhhgpeepghhmrghilhdrtghomhesfhhigihmvgdrnhgrmhgvpdhnsggprhgtphhtthho pedvvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepmhhighhuvghlrdhojhgvug grrdhsrghnughonhhishesghhmrghilhdrtghomhdprhgtphhtthhopehpvghtvghriies ihhnfhhrrgguvggrugdrohhrghdprhgtphhtthhopehmihhnghhosehkvghrnhgvlhdroh hrghdprhgtphhtthhopehtghhlgieslhhinhhuthhrohhnihigrdguvgdprhgtphhtthho peifihhllheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepmhgrrhhkrdhruhhtlhgrnh gusegrrhhmrdgtohhmpdhrtghpthhtohepghgrrhihsehgrghrhihguhhordhnvghtpdhr tghpthhtohepohhjvggurgeskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheprghlvgigrd hgrgihnhhorhesghhmrghilhdrtghomh X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 11 Dec 2025 18:29:22 -0500 (EST) Date: Fri, 12 Dec 2025 08:29:20 +0900 From: Boqun Feng To: Miguel Ojeda Cc: Peter Zijlstra , Ingo Molnar , Thomas Gleixner , Will Deacon , Mark Rutland , Gary Guo , Miguel Ojeda , Alex Gaynor , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, oe-kbuild-all@lists.linux.dev, x86@kernel.org, kernel test robot Subject: Re: [PATCH] rust: sync: atomic: Fix fmt warning Message-ID: References: <202512110753.8B3YlvtX-lkp@intel.com> <20251211213133.56265-1-boqun.feng@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Dec 12, 2025 at 12:16:45AM +0100, Miguel Ojeda wrote: > On Thu, Dec 11, 2025 at 10:31 PM Boqun Feng wrote: > > > > Commit 14e9a18b07ec ("rust: sync: atomic: Make Atomic*Ops pub(crate)") > > introduced an import ordering that rustfmt disagrees with. Hence fix it. > > > > Reported-by: kernel test robot > > Closes: https://lore.kernel.org/lkml/202512110753.8B3YlvtX-lkp@intel.com/ > > Fixes: 14e9a18b07ec ("rust: sync: atomic: Make Atomic*Ops pub(crate)") > > Signed-off-by: Boqun Feng > > --- > > Hi Ingo & Peter, > > > > Looks like I missed one rustfmt issue in the commit 14e9a18b07ec in > > tip/locking/core, here is the fix. Feel free to fold it if you want. > > Apologies for not catching this earlier. > > Linus picked 309e49039f12 ("rust: sync: atomic: separate import > "blocks"") in mainline a few days ago (but the solution I did was to > add a newline to separate the import "blocks" with different > visibility instead). > I see, I must miss that. Hence I'm happy to drop this patch ;-) Thank you! Regards, Boqun > Cheers, > Miguel