From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E240283FF0 for ; Fri, 12 Dec 2025 09:23:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765531430; cv=none; b=sCyZ7obD8TrN1YamXaPVBBgSWmj7sZ1f/66SnTjFQOl+sBKLaR5eyN7MlFnrHsiE8lNpJVMT0/IeKl/IxVvTQ3uzrZzCwh+6vdTlu1UGlGBg1BERB0KiJsbb09F8Hc+XxAvoNtoUmiheheFip3oipeym++o1z6zSNN0dsLzPn4I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765531430; c=relaxed/simple; bh=pUmu5YYgJZI53LKWuHsTZlhBNq17Yk013vZCURf+aRM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AaGItL4WbvKE84ydZI5OUZYDHUhCphJjJ+cwlH/iFmcWPwUE9g5Hg2DuTc45w+buIFRNz5MRV8tPPNzS50ruKS1uHVtk3jERPGEyEVb2Vp/BFlefcbAjskhaB0vJEAzk61bz80RNADH6MUohhoMh27px+cZIHxzhW9Wxw9UbaxQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=KOk+jd3k; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KOk+jd3k" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-42e2e5da5fcso666700f8f.0 for ; Fri, 12 Dec 2025 01:23:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765531426; x=1766136226; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bMc6iMu0ORBBPfwsIOc5/gxE4MTIOFMRwhH2GjIgDPw=; b=KOk+jd3k7lI+f4k9uWLcBND4JtJ+/h3IW764wc1g8QO58fABzovuL4TUsohlvH7X7H NvAYGZy/0nrpIXEsYVFZO4dAHCZdM+yCoQofNAyERIOqWDhsAGAgUQnCesLwRltxcDu0 ty8cktaf4/xLZzJ53J4eOtsdFD+xszJzMA+Ah3J2JCY4i+Pvd//1Z6XxkBHn0bRDqAx9 veDA99bhv7r/aoqwRUS0+I/fjkH1d+QkR5QWZBA98mx5dkgKRJQSfy3zbrt1LnSPnV5Y fGgcq7oDdBPhc499VM4j96QZ88QNx5s6lchL3fuwoj5s+cf1+/AD3sQPlkij5BBROLQy Y4Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765531426; x=1766136226; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bMc6iMu0ORBBPfwsIOc5/gxE4MTIOFMRwhH2GjIgDPw=; b=ZWfI/IPizBYIlhuED3tcQKxhh4Ias5fSfiys0sv5vmjahgpr2U/MnEWmbXVYzOrwYd VE+dMlnDMuyi5J83mtHk/5wnhKElV6PjHXSlyiGjJcIvTaglL5QZodz6H921ZduK418c tdkqn/FqtHiDkiWhUkv/j3k9iIVZ8MvdPeHdPAM8eFIUfMADyaC/Y70PSp+/ncoTWBg7 DfbteaqHw5fjgQ6P6eeHkrAwjw+m8BRdsqGX+4Zb/MqsUcGwCvhCfM6eD1MW77SQXvWJ +qr23pvhF5Dkc6OA0/p0vJqk8nUSqGH/JB1XJn6IyyesA+WLEts1AL48IoApy92CAeUx RscQ== X-Forwarded-Encrypted: i=1; AJvYcCWmm+KOyD1wCbeKxoNo5YWzDn08NtYS3ED/sqiieWKejKYM2ZwOmfHwvC2BY85uygRcR8DiuUgtxcUmJOE=@vger.kernel.org X-Gm-Message-State: AOJu0YxYrNEEiZ7QFWwoIGPUj8D/u2F1uQPYtMyAFIozd3GaSobqcQlb wwUwsAyfLPlIM55lFOSgHDv9yLJJUuFGSiZxu6Li1iKfZFKT7OgJeRM9kcVkAtvRRwg= X-Gm-Gg: AY/fxX7ciArJRjksG8SQmshptU5dFXZmFPNNwJnD3pY9+I34l6ZmB+ZIRmbTNewYoZ/ R1py4pzMgRxLpfkXB1MK4Ak+1ec4dcENiGFiBnA3L+Rz/e/Bxgm0xJstDioTvRopxq0qecI8zt8 +QInzg3B6CXbSjAb11X/E0yCF1POYPmt8d7gLZs40MkDfgU/my8/mVEnuYRFCiT/WSQbVc+OsCY JJZCtxwg2IocVT34vjCWevInykq5t46pzV9pt79mAKn/CNXxRhg37kN5gDoZAa/PlaHChRJ55ZP MXMGov+hkKOZuf57e0YWu+8seBqTDRgHUztpNdWUnnXkuctvOtXfnuIbPJpiWX04wJYv4m0bFJT v3HNNBhRhMtl0g0ZrSBKWT3WfdDDzgCkrV2y8dTSdOkoGBCObEyrhk0Xe+BLQtGWr2gr+V0xWmp DTPAoScyX5J6dZBKfaD8V0YOlGLaQ= X-Google-Smtp-Source: AGHT+IGyGi6GtcanElUSbdpdBuCTCLxzjBEe65AwAMydnmnIMqK4IYKr9EV/HpJTdhOxZ7j6PM+wSQ== X-Received: by 2002:a05:6000:2401:b0:42f:b219:2f2 with SMTP id ffacd0b85a97d-42fb44bc2a6mr1461470f8f.25.1765531426398; Fri, 12 Dec 2025 01:23:46 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42fa8a6fd62sm11842098f8f.10.2025.12.12.01.23.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Dec 2025 01:23:45 -0800 (PST) Date: Fri, 12 Dec 2025 12:23:42 +0300 From: Dan Carpenter To: Giorgi Tchankvetadze Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: fix memory leaks on rtw_enqueue_cmd() failure Message-ID: References: <20251212090920.84238-2-giorgitchankvetadze1997@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251212090920.84238-2-giorgitchankvetadze1997@gmail.com> On Fri, Dec 12, 2025 at 01:09:21PM +0400, Giorgi Tchankvetadze wrote: > Add error handling for rtw_enqueue_cmd() failures in multiple event > reporting functions. > > When rtw_enqueue_cmd() fails to enqueue a command, the allocated memory > for the command object and its parameter buffer is not freed, causing > memory leaks. Add proper error checks and free the allocated memory on > failure in report_survey_event(), report_surveydone_event(), > report_join_res(), report_wmm_edca_update(), report_del_sta_event(), > report_add_sta_event(), and survey_timer_hdl(). > > Signed-off-by: Giorgi Tchankvetadze What? The patch is apparently against a tree that doesn't exist and it just messes up the indenting. I've reviewed some of your other emails to LMKL and I'm wondering if you're doing AI stuff or something? What's going on? regards, dan carpenter