From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 251A22F49F0 for ; Thu, 25 Dec 2025 09:37:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766655437; cv=none; b=YLYqKcpGR3wlRHtfLWyyCsvA1/CZAAk9GVlUcyMefAwe3SwUG238Vyors93R6P46XpGrbwW3P73BoXlr0IsJEcwXGZgHqteqDLTtyI1TUXzuxrYR1XlsiG03pTVkf3jPgIepPiSqFi6p19xkD+ELEdHirNWZjBMj4QXtNFa4baM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766655437; c=relaxed/simple; bh=VxBqnPDdnIHjfcuIiI4D7oNyQ73l/jfjo2YNl08bqJE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GbKXwQDqq9feek8zMGyUYrDcIB6V7U5hadp+swxmzF5vaf/CXcD9vvQ8toogihge8w7ZC8Nkak7Lw9VyF7gjNfaYfCPFko83DI8ccEbeeDNxgCn1hl1ClkQEz0HAm/Y0rs3gbV5bxncm7EanOhTH4WMlPC/FID/Co+sUbQ0eOaI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bYB4Kp3d; arc=none smtp.client-ip=209.85.222.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bYB4Kp3d" Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-8ba4197fbd4so689670285a.2 for ; Thu, 25 Dec 2025 01:37:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766655435; x=1767260235; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :feedback-id:from:to:cc:subject:date:message-id:reply-to; bh=nVJof1x/tXOVIVA84B6vueb8075E7eaQsUaC6CPaNX4=; b=bYB4Kp3dOCIKNZUpZacJP3WH3RWh6xfO55jGEMS21uqATakjZbASrCK4Dkil01nui1 w+Hvviky4beOmYefTkqi2qQb9qaGV4+VOU46bybMMdiZ6iq1/T9+jU4f9cXBS+15qEmT EsFu6gNn++hM83JqlLhZI8qYNOmxzYoMZmx8brw7i3A+bmSbn1lJLbGhs/59CI8rjDM4 IvljAzzuFGW9PkWfZZlMAzqmn4zz1CewJFFBFQiu32iAZHbFtYtH8QwwrIZsFVM3Kt35 BjdtlH3EgTH8Ay9vhIS8muTxxRapDQi3dnj2dnXQtt1j7KZtYr2ebGu7j4x/hi+9w0Tq rt0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766655435; x=1767260235; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :feedback-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nVJof1x/tXOVIVA84B6vueb8075E7eaQsUaC6CPaNX4=; b=UTisgTbGX52Kn90MnEt9nzjqE9wZcWj5bQQ4F1VIanxZCvSIXXXuT43sMCBE6AQqME +7JkULka8LBGto9gMqjeFWuBvR6iGrbGpv0ivb4u2qe66o0j36qyvzoN4jWlg0gvSa5d 2HIZjSNfOgjd6CN0S0a3HF5P8CoSJr2n642yiURevdm5nxtsSdP8MjHtbsvENsIH7rnS fuNiU1X0qxmTShm1YYAdDUFKucK55ks749SgMlc3RfpRnYWx76RfTiVqOkIMtUkw2Y5F 8Ra5xdk0sGInW04vEgTL9NfOVMIYmGoP/uq8pPRKCeU15tKZTqORnhAOcsArqhgMfGHH Rfiw== X-Forwarded-Encrypted: i=1; AJvYcCXhu1BbYSmu12hRsWixu28xiZ3eNjOBRelh4zNo9D7Zfd6CA5gwBeuqdPcCq+OwS8P/Xbp45pN2SSlZ/ok=@vger.kernel.org X-Gm-Message-State: AOJu0YwCKgRvyzzpdl6/Td+mz/FSJCdNfcrtxSIA+3KGt/80ma90se+g ZIyXKM2NRO9WhElDWqJPGYqGVbnAw3v7QX3QKRNHH7rvAoc/D8o2dUX2 X-Gm-Gg: AY/fxX7oIu7w7gCxfU/BCM4kNLLyBbky2lzNVLuJ+w4EnoBIEQyYxoj0Mvl/xkrV5pF jlovvh+elh8X9zbO6NVe686tWS6nWgbHXTulVPOWFzEJG0bPUo6meA63FGU6Iph9g68kLYLRnN7 O2lMU/2t0vgp0zq7DX7Fy+QguMawxjPUuP2iFEQMRq4AxL0L+J2shYN2MJSEOnqtraxqVYoEXp5 1L7Uh8eETCOuMax3Yrl56DLjwFmeCMaKJoBMdJAexwq1XvGt4nIXeeqsq67wGLnp/XT+zkBlw1g BbcpwEcqcm7co6C0Smt1JwacEKlab/PXBlXfreuXiWE3y1PVm8EHsmrn/cQcHMSe9JT4pr4s8DH /qKOkdRWEFsppAER0ACGr3VwZZ7JDdtkUxYZwqSe5IvYpzMxY0+82dexzohdWUIrT2mg+9ki1oW xEtsVD5MkDozG0I3pueLoX0qGooybOo5D9cnFdBLPoop2mKNOa0gpIGslbWUX5+W/TuujTAwrLm HTX8kOW1jag1dM= X-Google-Smtp-Source: AGHT+IEbRRGZzGujWcSUy0xGCmvJO9s2DIM/tr5qJ7KrDMoaQ6oVqoSAy936oz6+khGEi3m+dJtBJg== X-Received: by 2002:a05:620a:31a8:b0:8b1:adfd:f850 with SMTP id af79cd13be357-8c08f657bddmr3283688685a.18.1766655434938; Thu, 25 Dec 2025 01:37:14 -0800 (PST) Received: from fauth-a2-smtp.messagingengine.com (fauth-a2-smtp.messagingengine.com. [103.168.172.201]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8c096783922sm1491700085a.7.2025.12.25.01.37.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Dec 2025 01:37:14 -0800 (PST) Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfauth.phl.internal (Postfix) with ESMTP id 081C8F40068; Thu, 25 Dec 2025 04:37:14 -0500 (EST) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Thu, 25 Dec 2025 04:37:14 -0500 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdeihedvgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpeffhffvvefukfhfgggtugfgjgesthekredttddtjeenucfhrhhomhepuehoqhhunhcu hfgvnhhguceosghoqhhunhdrfhgvnhhgsehgmhgrihhlrdgtohhmqeenucggtffrrghtth gvrhhnpeejhfeikeekffejgeegueevffdtgeefudetleegjeelvdffteeihfelfeehvdeg keenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepsghoqhhunhdomhgvshhmthhprghuthhhphgv rhhsohhnrghlihhthidqieelvdeghedtieegqddujeejkeehheehvddqsghoqhhunhdrfh gvnhhgpeepghhmrghilhdrtghomhesfhhigihmvgdrnhgrmhgvpdhnsggprhgtphhtthho peduiedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepmhhighhuvghlrdhojhgvug grrdhsrghnughonhhishesghhmrghilhdrtghomhdprhgtphhtthhopehfuhhjihhtrgdr thhomhhonhhorhhisehgmhgrihhlrdgtohhmpdhrtghpthhtohepuggrkhhrsehkvghrnh gvlhdrohhrghdprhgtphhtthhopegshhgvlhhgrggrshesghhoohhglhgvrdgtohhmpdhr tghpthhtohepohhjvggurgeskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepghgrrhihse hgrghrhihguhhordhnvghtpdhrtghpthhtohepsghjohhrnhefpghghhesphhrohhtohhn mhgrihhlrdgtohhmpdhrtghpthhtoheplhhoshhsihhnsehkvghrnhgvlhdrohhrghdprh gtphhtthhopegrrdhhihhnuggsohhrgheskhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 25 Dec 2025 04:37:13 -0500 (EST) Date: Thu, 25 Dec 2025 17:37:11 +0800 From: Boqun Feng To: Miguel Ojeda Cc: FUJITA Tomonori , Danilo Krummrich , Bjorn Helgaas , Miguel Ojeda , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Joel Fernandes , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org Subject: Re: [PATCH] PCI: Provide pci_free_irq_vectors() for CONFIG_PCI=n Message-ID: References: <20251215025444.65544-1-boqun.feng@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Dec 25, 2025 at 10:10:04AM +0100, Miguel Ojeda wrote: > On Mon, Dec 15, 2025 at 3:54 AM Boqun Feng wrote: > > > > Commit 473b9f331718 ("rust: pci: fix build failure when CONFIG_PCI_MSI > > is disabled") fixed a build error by providing rust helpers when > > CONFIG_PCI_MSI=n. However the rust helpers rely on the > > pci_alloc_irq_vectors() function is defined, which is not true when > > CONFIG_PCI=n. There are multiple ways to fix this, e.g. a possible fix > > could be just remove the calling of pci_alloc_irq_vectors() since it's > > empty when CONFIG_PCI_MSI=n anyway. However, since PCI irq APIs, such as > > pci_alloc_irq_vectors(), are already defined even when CONFIG_PCI=n, the > > more reasonable fix is to define pci_alloc_irq_vectors() when > > CONFIG_PCI=n and this aligns with the situations of other primitives as > > well. > > > > Fixes: 473b9f331718 ("rust: pci: fix build failure when CONFIG_PCI_MSI is disabled") > > Signed-off-by: Boqun Feng > > Related: https://lore.kernel.org/rust-for-linux/20251209014312.575940-1-fujita.tomonori@gmail.com/ > Thanks! I was missing that, and I should have replied Tomo's patch. > I guess it counts as a report, so we may want a Reported-by (Cc'ing Tomo). > Tomo, how do you feel about two fix approaches? I think providing dummy pci_free_irq_vectors() is better because it's easier and aligned with other pci_*() APIs. Regards, Boqun > Cheers, > Miguel