From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FE171E572F for ; Thu, 25 Dec 2025 13:38:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766669895; cv=none; b=c9FN4qjvEX56sLiabowVVofYhm+PWoGBi65wjzqK7bUWJiqNFYrky+hlb907EzpO7YfayXD7yTmP3URxMUTVAs2hqnvvRsNzQuwnpU8ZDHRlB+n0z2obgE5leeE9DojhtJ5OTxWjorW8kXUfm6e7J/V/lbivkvzBPikQxAPhkF8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766669895; c=relaxed/simple; bh=pmnz0oGl2vjflMVXwJDwVUMJcljdGcnjC9a50JchBI8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VvqFt8PyeTlyakyKgOrji9RbvHKRSdf1pw0fp/ql2rT7B1Ln8eMw8hHTOdbBcgyINUrxEAVId+NU5p1flW+FHuyAYYr4HCcDh69QVJ9mNTn0AV0Zj+taiSLVu9gbsnkrqh9zXKz3dFtQfQ3u3Nx06vExlD3mFtM3HTjMiMXN+64= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jeEClWCY; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jeEClWCY" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-b7355f6ef12so1265753466b.3 for ; Thu, 25 Dec 2025 05:38:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766669892; x=1767274692; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=awCVuvgAZaXJOt5osuiXjNYZyCIOZG2/wfsfiJqr6tY=; b=jeEClWCYiOd/l5tak/gH7EbJE8IEqVUumjxISpRE7ZAAM6+Zj6W7Vd1sNN3D6Km9aP jKkpF+UxuQ1FsaBpi/U8nN92FYmw490G+ySeWKMQ00uIglDQwL02qaUe1eXuPkCSzxN8 FXVLW+dfpplfsj4qMnorOw5AOZ4ImVu6c8XMBA2fmB7vG0KMpWjaEYCk7tUMjMuYQFio nIFHTZUeqEXFC6zWzTgfZ1UT7hIV0bMNjp8kDK4Qvg1QJDGx0rdbaQh+vB7cIRHbEFLW fELL7isDNmd2vU8AhsuRGFmg2UFBLMhY+mxv/kAva0LAE7aQsMYBMLURMrij9RHf31hO lrxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766669892; x=1767274692; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=awCVuvgAZaXJOt5osuiXjNYZyCIOZG2/wfsfiJqr6tY=; b=mbPWS7jSMmyGBm6zyZ9vT3cF0ZooO2N5ypC6snDvwIGKj+Z/onE/f/tWw1Nem7Sf4x b7/G29DPslqMR5c6pCHQlUcOHR0cd9YcM9DXRKlUn5Crl9j4uA7yv0fXW1PV8NE5YSe2 NMvEwW6X6IYjmagXDO6K/76gZKd7k5DigVOtaWnRuyI+7TQtH7q3H70cnxIHHQgm/wN4 Y3js3pS//24HGaQ+QytnCrqV1NJ8EoAOLeishXzRoWfdelP/VtpOAYuamRIEsyLBeRvr MMo1h0SXeli1IWl/XNmMao7ZiYvUrrp34wUdVYAwgbre/9U9S6kOq+gjAQou7uPnZvXY 8I6A== X-Forwarded-Encrypted: i=1; AJvYcCWNU9bnd50suh/pabcpwiMh8+hlVrCqWQyNiVuUHFYizm+w27LioUlVnaDp887g+e4LpWKiVLIPmDwP900=@vger.kernel.org X-Gm-Message-State: AOJu0YwRPW5ekky8LuOrgsyUANJJ1Kti3G1KB+BFPjM9USaufjBHvUG+ wdCoEciMgP+Y/Wt2hMY9G7WvIn6b1vQd/2g4tdPRx7rFSxU2Zw6FUwNM X-Gm-Gg: AY/fxX6M+RPc7j/6fLFoN9DT8wvCllvlrWHXnlhmNh0TNPjKG+YqglKH5n7PvNaGUpj 8GQPdlPa3GXZ/tjYCQM19D9YP9sRPGJYgvpijROrvMtEMnkQFdkn+FXj+vAy7sw/Obc+a5lnG8l 1Q0UjVltCLb8Xv464n3dG5tS7tCAyMIa1VylyHjm9vCP97lKmDV8ZTt+ZgiPZiej1Eq6xuqB9n6 0YGojHFc8a3Pl8DEUMCLD4q7Op7Fj2O6tMhYMqTEWFdw4aBZdQfwXMjQ876O0xepvlJMV9lWhgQ zYY7zhl7uR/0qcCcM4I7v7tL1s5K0hpRhWh0fuFxRemQI+s5ea4EEoAx1OBGRQmETFeXLRts68h V8u4RaYtMTSXeun4LUUfJ9LDSka3VZo67T/zyLZw6s1O0Ka3XoE98ZjY92KJP3E3FyFzNQj0z/2 UyI+hRiuYWglQENUO+Frki X-Google-Smtp-Source: AGHT+IEILxAdqeW8O+YyFkQZdShOQv9nnTYoXvE6RJmcyl/wZHptGG6yij3umskXKM+Yy2R31pQoAg== X-Received: by 2002:a17:907:6d06:b0:b71:854:4e49 with SMTP id a640c23a62f3a-b80371d4462mr2161942966b.56.1766669892248; Thu, 25 Dec 2025 05:38:12 -0800 (PST) Received: from mail.gmail.com ([2a04:ee41:4:b2de:1ac0:4dff:fe0f:3782]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f519c0sm2052208766b.71.2025.12.25.05.38.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Dec 2025 05:38:11 -0800 (PST) Date: Thu, 25 Dec 2025 13:45:41 +0000 From: Anton Protopopov To: Xu Kuohai Cc: Yonghong Song , bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Puranjay Mohan , Catalin Marinas , Will Deacon Subject: Re: [PATCH bpf-next v2] bpf: arm64: Fix panic due to missing BTI at indirect jump targets Message-ID: References: <20251223085447.139301-1-xukuohai@huaweicloud.com> <15c26b1f-b78d-45d0-b5d2-e8359ddf5bbc@linux.dev> <4287f839-d713-44d5-afa0-918f2a44c5c3@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4287f839-d713-44d5-afa0-918f2a44c5c3@huaweicloud.com> On 25/12/25 07:46PM, Xu Kuohai wrote: > On 12/25/2025 7:04 PM, Anton Protopopov wrote: > > [...] > > > > > diff --git a/include/linux/bpf.h b/include/linux/bpf.h > > > > index da6a00dd313f..a3a89d4b4dae 100644 > > > > --- a/include/linux/bpf.h > > > > +++ b/include/linux/bpf.h > > > > @@ -3875,13 +3875,32 @@ void bpf_insn_array_release(struct bpf_map *map); > > > > void bpf_insn_array_adjust(struct bpf_map *map, u32 off, u32 len); > > > > void bpf_insn_array_adjust_after_remove(struct bpf_map *map, u32 off, u32 len); > > > > +enum bpf_insn_array_type { > > > > + BPF_INSN_ARRAY_VOID, > > > > > > What is the purpose for BPF_INSN_ARRAY_VOID? Do we really need it? > > > > There seems to be no need for a name for the default case, > > but BPF_INSN_ARRAY_JUMP_TABLE should be != 0, so can be just > > > > enum bpf_insn_array_type { > > BPF_INSN_ARRAY_JUMP_TABLE = 1, > > }; > > > > Having only BPF_INSN_ARRAY_JUMP_TABLE feels incomplete, since there > would be no enum value to indicate an instruction array without a > specific purpose, like the insn_arrays created in selftests [1]. Yes, but it is also never used explicitly, right? The only usage is in "x != BPF_INSN_ARRAY_JUMP_TABLE". > [1] https://lore.kernel.org/bpf/20251105090410.1250500-5-a.s.protopopov@gmail.com/ > > [...] >