From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26DD6188713 for ; Thu, 25 Dec 2025 14:48:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766674097; cv=none; b=sk9hizKAWUJbVXlt8EHwNPlcmukOvKfgMSetaXQnqQoU+bo4w4BAt4LoYL2lAGMiD/I6BEy0op86G4mXSOp4lf5ncTmK/bJ5XqswCDmCu25EtEB51rdEDoQge53dXTJLIWhbtWKmhfgqsqFzGIb2v9z+i3lD+1rgG4B2G6tcG60= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766674097; c=relaxed/simple; bh=aSQ8BpuuBmFT8oHn4FrTJLS/OjU8EYxuYiOgNG/hUyU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HKXUn6nwA+yg/FHN53cKGHvh319yTgBhwKIfUMIrMMbb2y7ZOolx03SrR11R5eMNcP/cyGORxqjddwmgTnQpBYZquQmOo4qQAJ3i88EN7/tkl+rUbuD10wj0cOgJ2aWzk6Pej5OdLSS/vBag7o2krZZ3K+1ZFi/NNkBX05AcZHs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net; spf=pass smtp.mailfrom=minyard.net; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b=IBxm773O; arc=none smtp.client-ip=209.85.167.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=minyard.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b="IBxm773O" Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-459ac2f1dc2so301696b6e.3 for ; Thu, 25 Dec 2025 06:48:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minyard.net; s=google; t=1766674095; x=1767278895; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=FyjGbxSEKFRKSdOhl1fCBfFEUUx7tM9xVkea9Y3mrL4=; b=IBxm773OW1X2/bvbi6tmzd3IjGYeTLSgYPnDB/KyYZDW4kjASkf9WdMBcOfCiRU0kq dUcKmqyu992s2ZBhvsRrDqxuJcJBaLHZyxjIU11XCwOdVoowDYdALVcVWxQ/1Y2gnedt RFbwxD/jwOgX02qcCWkmISE3I2Pf8PORpM81cq2/xcUNk1lOnbgVSK5XXZOxjGPj7SgL Gr+bnKfwo0mUMr9wRUeyLMbXUWlP9oJQ6ELbVKJMEZp1xZ6JIAgpheslcbxXu51bP9dh vjjp3W2TJz0aL3lv3Iv3AJGtZ/pPawQd2iV1sc5M99iCVIIbXJe80/UNyyIfuzlsk+En /SIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766674095; x=1767278895; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FyjGbxSEKFRKSdOhl1fCBfFEUUx7tM9xVkea9Y3mrL4=; b=p5TQdD4aVgiiVpSTlBNGNuf8w7JFuaSuT5nzn5mYviWSVeJeL44esKuds7LBtJR4ro 4LKXdVnITqcVqE7EknxFBq0c5Ts5GDgquXmgyLkZcV/xE5c7GOKf12zNdUZJ3GRK7wb5 4G/9gtjp5z3Kpo16/uu0VZ59XqF7+0+IWP4WKpwGgt2YUHkSojlmPN/xtLHGvH2ttuzX sQS8RnW/2NnsAOPshUQfrh+SEN/4nTK7+9k048bBwu4CPUzaGy+7fv0Dh44ajwXjm8Hv w+eNAEk1Zajr6PNpXiIc7k9WyXHt0dzW8vyRFECSKt60nP5x9LPAOHETRdFRHTlbE4lR ZJqQ== X-Gm-Message-State: AOJu0YzrcvqaHTbtf3lxbmiRRAWuQCyQUI9TBUt8FbDQrnoXHVTq06qj LeYJMWQH2ZzHtsEl5DSgwJ6gBIG0lfZFD0EceVtdELUxeJA+8qNFR+FN3VJJgHjDwUI= X-Gm-Gg: AY/fxX4YynQau/6LfOfVLGiNYeyqCDPgVpqummMt9C53tzAnrA44Ds8OKHGdrfboYD+ AGaVgRWXz5udfBTrVJK4j/TSpKyxHPS8XSESFSrxeuoEKO4gd73bhzH/VomJ0BtL8ZUwfnJPxkD cAJ6JGtiv0kwoNISAWKGYm3IwQcCqR72yBBhd4nkaQiJo9WSkug76UDvGPk6T+jxP0Ms4hGFjnh rh11CDGyRs/9j+sx0op0BtRdbgii58cslnWKRIrFPdhE13E7eMRkixFuV7Ua2nm8P4jTAid5OAq GlRIAGCt4teuxpFDu8cdPCBBJNhrXN+UPngvflikUJkSzrpLEdQpNlM+KPMKErAIofnGG9Ow4T3 BrW2JMqj3mLeXSxANhYV1ndHQuQnCVFdmkcOHrIZgannMhOqWP/lYDOP8Xp8b4O6ramENXWNDL+ 72x9GsuyZ/SpSs X-Google-Smtp-Source: AGHT+IHq/HII7KN4ZM4/mdYV9j3XHwJ87+/D/0t+YfkekNTNAMJ+pP5SEsQB0rX1lXZ5FKBnLzw3DQ== X-Received: by 2002:a05:6808:1b25:b0:455:f286:707e with SMTP id 5614622812f47-457b21bcde4mr9211923b6e.63.1766674094990; Thu, 25 Dec 2025 06:48:14 -0800 (PST) Received: from mail.minyard.net ([2001:470:b8f6:1b:f542:2e3e:ddd:4ad5]) by smtp.gmail.com with ESMTPSA id 5614622812f47-457b3cc114fsm9786352b6e.11.2025.12.25.06.48.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Dec 2025 06:48:14 -0800 (PST) Date: Thu, 25 Dec 2025 08:48:08 -0600 From: Corey Minyard To: Marco Crivellari Cc: linux-kernel@vger.kernel.org, openipmi-developer@lists.sourceforge.net, Tejun Heo , Lai Jiangshan , Frederic Weisbecker , Sebastian Andrzej Siewior , Michal Hocko Subject: Re: [PATCH] ipmi: Replace use of system_wq with system_percpu_wq Message-ID: Reply-To: corey@minyard.net References: <20251224161301.135382-1-marco.crivellari@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251224161301.135382-1-marco.crivellari@suse.com> On Wed, Dec 24, 2025 at 05:13:01PM +0100, Marco Crivellari wrote: > This patch continues the effort to refactor workqueue APIs, which has begun > with the changes introducing new workqueues and a new alloc_workqueue flag: > > commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq") > commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag") > > The point of the refactoring is to eventually alter the default behavior of > workqueues to become unbound by default so that their workload placement is > optimized by the scheduler. > > Before that to happen after a careful review and conversion of each individual > case, workqueue users must be converted to the better named new workqueues with > no intended behaviour changes: > > system_wq -> system_percpu_wq > system_unbound_wq -> system_dfl_wq > > This way the old obsolete workqueues (system_wq, system_unbound_wq) can be > removed in the future. This looks good to me. Acked-by: Corey Minyard > > Suggested-by: Tejun Heo > Signed-off-by: Marco Crivellari > --- > drivers/char/ipmi/ipmi_msghandler.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c > index 3f48fc6ab596..ebdc8f683981 100644 > --- a/drivers/char/ipmi/ipmi_msghandler.c > +++ b/drivers/char/ipmi/ipmi_msghandler.c > @@ -973,7 +973,7 @@ static int deliver_response(struct ipmi_smi *intf, struct ipmi_recv_msg *msg) > mutex_lock(&intf->user_msgs_mutex); > list_add_tail(&msg->link, &intf->user_msgs); > mutex_unlock(&intf->user_msgs_mutex); > - queue_work(system_wq, &intf->smi_work); > + queue_work(system_percpu_wq, &intf->smi_work); > } > > return rv; > @@ -4935,7 +4935,7 @@ void ipmi_smi_msg_received(struct ipmi_smi *intf, > if (run_to_completion) > smi_work(&intf->smi_work); > else > - queue_work(system_wq, &intf->smi_work); > + queue_work(system_percpu_wq, &intf->smi_work); > } > EXPORT_SYMBOL(ipmi_smi_msg_received); > > @@ -4945,7 +4945,7 @@ void ipmi_smi_watchdog_pretimeout(struct ipmi_smi *intf) > return; > > atomic_set(&intf->watchdog_pretimeouts_to_deliver, 1); > - queue_work(system_wq, &intf->smi_work); > + queue_work(system_percpu_wq, &intf->smi_work); > } > EXPORT_SYMBOL(ipmi_smi_watchdog_pretimeout); > > @@ -5115,7 +5115,7 @@ static bool ipmi_timeout_handler(struct ipmi_smi *intf, > flags); > } > > - queue_work(system_wq, &intf->smi_work); > + queue_work(system_percpu_wq, &intf->smi_work); > > return need_timer; > } > @@ -5171,7 +5171,7 @@ static void ipmi_timeout(struct timer_list *unused) > if (atomic_read(&stop_operation)) > return; > > - queue_work(system_wq, &ipmi_timer_work); > + queue_work(system_percpu_wq, &ipmi_timer_work); > } > > static void need_waiter(struct ipmi_smi *intf) > -- > 2.52.0 >