From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f45.google.com (mail-yx1-f45.google.com [74.125.224.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BC213FC9 for ; Tue, 16 Dec 2025 00:23:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765844585; cv=none; b=X//o7vykApnNKjxPEGnZcWSxO4Z2Q845YXNrAF+4qpqgWWxYGEiiI39mcBswbHi7uR/ggADNcI2xBhF2BzPm67rvcS5sQN+KUTnCpeo1MeIGHKITkfDvoF0pJJjLXNu/Q4MM76ymzS1EcwFAS2EVrQBK5jubIJycWno+M8NgjTI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765844585; c=relaxed/simple; bh=p9c38O+ZzwcCwCko1W9Erys+leH1B1bgjOYAbZU/TgQ=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NNc3NskzZKHUDOu10lCJKew40drrg2dMwHW7EXbo5yFx4ATqPriLjm+Jz093w910nDmlDMJ7gnrDTUPEXp2134FG205lJsvO9UwGh5y19YRJI7naQmicP1mLeHjP4gJNqAna68QQOcoIjpm8IxAFfqeHm4Frn3ZCPo9L8lR7PWk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a2CAdvhF; arc=none smtp.client-ip=74.125.224.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a2CAdvhF" Received: by mail-yx1-f45.google.com with SMTP id 956f58d0204a3-64306a32ed2so3810173d50.2 for ; Mon, 15 Dec 2025 16:23:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765844583; x=1766449383; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mTxqZCzT0UvzKw9dCcrvmpbxlfqmuHmyHFmqYVWd8jA=; b=a2CAdvhFjry9QO3KTNbi8RjRGxXHxSbethMZOYtn+sfNTxM7/lJStq2Rfz0imFdpK0 YGUEgWgnNGjOuA9C8GTG+ZPEMHRevzHfmvVqP/Kq3SjKs/Gx+bE2b8T7wm9KCeHlTUv9 mqGMpqOIzC8ndOrBu6Js1Q01LyrlH62A+QZCvzveL5mEPrZ5JZxUep9F99FLT5GHQ9to KvYzEzCkvii1NZMw+p26CRyd9fXqFLDBMOUuD4ri5qBj7hvkc0EBjjL5U3fQxHhOWMLY vfXN9X3/iULJ34l05BL3SsAvQsgzAQQJ/ToeYwdB2cWLXg8E0vb5vR/fsLDJ2YshjMNq d/4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765844583; x=1766449383; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=mTxqZCzT0UvzKw9dCcrvmpbxlfqmuHmyHFmqYVWd8jA=; b=L/Qd88s2EBV7TsMmcH0Prry6L0h/lOxc1b00niWaqcaCdeN957PownzYLEn6pwb0e+ gTxt5FqXB2YhzT9o6x94Pwjb8AXryximzJXMMQLTJDioqKi9x+Vj/HzBHtulaoGm2+nq expQL7ep9bg0mB8q9vZTbNkgg5ofqLRPhCl/Ii6EkbICQJBA9mYQP8ZHOV8yE94YPJp2 PDGjk9oJ6zhZNrER8PgsbEPiBFEM1DHmpLoV0I6Q/TsK80B57ZclhuxejPrdLTf9p1s6 jXFy6MbMrK/6+Wnt6xTgs+ci3dA6n+wcLujP7aONQ3WxvixR9OF/ORdWCxV5+0wuIlz1 kzBg== X-Forwarded-Encrypted: i=1; AJvYcCUme0UnX6h6yHBYEJIeRi6cqeL5Jn+9FKXGPLVfpFnjTtsbrgcgXO0PsQSdj19f6Lwsk+A7Q5wLV+ILq8Q=@vger.kernel.org X-Gm-Message-State: AOJu0YySbOliM9iJxxu+WhpgRCji4RJ2P/8mJ9ps/oO2QGdZe6Wb1hxQ 28/Mw/S8+pZmYPdCv/VdKpeNps2pvngVyp2ejYo+ZCBNF4qZVt2aXcPQ X-Gm-Gg: AY/fxX4PijDbZg0LSwnbMf5fJ1yODucpOEOrjrxH17y0bfuKB2mBxl0IWV0AqG0WfHt lXOm88fQWiHHByUsB4mVumsTbSJ/7F4kfZ+iLfv4jSZIIKXloS5c4Qp1A8ZGHq195U6nGyjqOjo wS3NDYBF1p3+mhzg64Kd29xB6E0KdeKs4bW4O9SaavPB+YwOwBBU8GgDLb95Tq89V9KfRHZXhiB 00/XZAirT8ULLtwNAW69qHAcEtUjuu/u1ZwFVrjKg8O2QmFQA0Dt60bMRF7nWNYRb+SJusjPIaT exxPnejIDAof1wdZwDxdqDnq3vV70e4alqZffcBYbc2rzdzucIhCcHkoph/ZTUksROGkg+HuEQM wEt+h/nqoRSE1bjoipgpL8QiF+8efLWTCY6SCQONZwaiRy5gGgpt8N40lmpbnkY6XjkFtNJ8UZC q1yijQuw== X-Google-Smtp-Source: AGHT+IElwuJ+Kc7oSIcguUHOwDg3yTr/Hr6n5BIFbziQ3BcagWQ4NV+UAcCv4fPA1bVGgRR+Tqb+dw== X-Received: by 2002:a05:690e:1187:b0:644:60d9:8678 with SMTP id 956f58d0204a3-6455567deb0mr9120011d50.93.1765844583125; Mon, 15 Dec 2025 16:23:03 -0800 (PST) Received: from localhost ([2601:346:0:79bd:6b0:1f10:bc87:9bd7]) by smtp.gmail.com with ESMTPSA id 00721157ae682-78e74a28c67sm33231597b3.47.2025.12.15.16.23.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 16:23:02 -0800 (PST) Date: Mon, 15 Dec 2025 19:23:02 -0500 From: Yury Norov To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: adc: ad7606_spi: use bitmap_full() in ad7606_spi_update_scan_mode() Message-ID: References: <20251216001808.333053-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251216001808.333053-1-yury.norov@gmail.com> On Mon, Dec 15, 2025 at 07:18:06PM -0500, Yury Norov (NVIDIA) wrote: > bitmap_empty() is more verbose and efficient, as it stops traversing > scan_mask as soon as the 1st set bit found. Ah, please read this as: bitmap_full() is more verbose and efficient, as it stops traversing scan_mask as soon as the 1st unset bit found. Sorry for miswording the commit message. > Signed-off-by: Yury Norov (NVIDIA) > --- > drivers/iio/adc/ad7606_spi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/ad7606_spi.c b/drivers/iio/adc/ad7606_spi.c > index f28e4ca37707..7e17ccbcedd0 100644 > --- a/drivers/iio/adc/ad7606_spi.c > +++ b/drivers/iio/adc/ad7606_spi.c > @@ -345,7 +345,7 @@ static int ad7606_spi_update_scan_mode(struct iio_dev *indio_dev, > * has no way of demuxing the data to filter out unwanted > * channels. > */ > - if (bitmap_weight(scan_mask, num_adc_ch) != num_adc_ch) > + if (!bitmap_full(scan_mask, num_adc_ch)) > return -EINVAL; > } > > -- > 2.43.0