From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 554FD1D9A54 for ; Tue, 16 Dec 2025 21:10:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765919411; cv=none; b=VVUEiyvjQnEl2ErfNgMUdtezZna75L+sHS8OZvSuaxyyiPmJBuQccm4+Ylxm20K93bwL2aUpLCDKn6X4RNF/PXX/owH6T6FN3A42js7PYL8Lm8lIYMBqEn+z86p+4SKHmdMbJhdMTtDTs/k6DpIDiguCtlV/sCL0tlcbrGf+4co= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765919411; c=relaxed/simple; bh=q5gwEcnbCpg1FDNtmQu7iR30Xpj3kC2vWvUR+k0AUeA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Wj8Zu/YZAPwPUpgC7MTvtmiD057A6nUnznd8ExzBEI3UYqVh3OmzCnezHdD+2gSYqmqov9yXavqQsiKOwliaMDTCiv/uez9DRVtKQEQeYqGBNyhchbveiT5Umon7xHCHz//yb3b7NLiMK6WGHMOzpohpe68oNx1x0zjdlgx+JfU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MxI0X18f; arc=none smtp.client-ip=209.85.128.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MxI0X18f" Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-78ab039ddb4so51314207b3.3 for ; Tue, 16 Dec 2025 13:10:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765919408; x=1766524208; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zVJfuOebmMjqQEX/P93zGyEJr1l5oTAgkmx+aqBYaHc=; b=MxI0X18fwUYGHiHbHCh3GJ0o/2kBIBVmOaUMrEiP6CeRBhiN0eiga20gUafPA2VAkX cECOjmUHHhJlyqYK5J5eyv+hxcvU7yinWHAx+tw3PseLGwAp38bG1s8NUZiB+gGbjOTi h0ceHcBtmEJmEQlSYA1ZQWzThQn1aafFB7OfDreF3LDivCk3XdCd0KxH9WdtZJMMFzPy gkUMJ2G5UMI3XkJ1XLO0MDfSQtTK09zbmbVDJ/ZMCIDS6jhgRMHfQmmdc9jj9s7Im4aU Nx8f+dEZZrqq+29dAAidaFCOWmYL7kMeVJ9iRo8VEz0Hbfys9x1qn9sGvGkAK9ADHuMr 8AOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765919408; x=1766524208; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zVJfuOebmMjqQEX/P93zGyEJr1l5oTAgkmx+aqBYaHc=; b=JPTCXO5KhR/ZMPjAYYdYCYu4Fj642TTWEYCCCxnYYZske8GF4H6gkHw4fXecpEhd8A z05UYu7HlZIYbcyCpk2VcSbNrSbXSFwZT6s1ohVkamQKCQ4TqRBiazkdPUboEjWZXlh+ R/6hOdbP85bZ6YzTs33tBnELxG6/9+gaQ5K18PCkyoq0UBJ5F+rspS0p6x9iHktPPwbn YSPpi+cybqizl5SGG/Ey7Qj1ROwndRH8vZ4qRhpNlszb/q3Jos6NMn61EPlLo8HIakpj xSnXN5gDGxJ7xU6E6fssSJ6tXXlKUOo8Axm2Yjyc3ZH0PSzT1wMVIiPiscRwAcyKZLk2 P4aw== X-Gm-Message-State: AOJu0YwXzvc5nALSHxXJ/zbNDtrgabky+5fgSQloG+gbKbm+BFpAITqz 9cJRr5amfB8jobtN5uoPk+APslZwgbG8Nmxw0cmmr+gRatedl1/Fsq3h X-Gm-Gg: AY/fxX5Oi3Ud1/UAR/9JDRxjFwROZRoJTyISHh34XWpAQFKHvqTMXKfw2rEYaXE3fT9 dzXaOhnMhsYhRls2tcaiVQuRP0+T72F8WqExNqD4hMXjCno1q3X/BEEU/tHtFxta3Vl3svo4Iel J6FMwFmuM/VyV+15nwMUgwPXadoqDhIthUP+Rg3hnTXvlR7+qgBxYKNGubJkqZZzaHt+hPsTKLk fSDgvfimr+Y6W8HqfqvT8K506FKvxF9lU4LqQVgUYMiqUdO3P6tYpWMQwxMbTBWxfBHQys0po1J LCKXJ/9OdkMyEyLXdh/D75artEP3qOZq895nGk795jhFtnp3t+MUD5ZoHj2eIk+/flgXZas0JU9 a9hGHAd/kwgxizOP1ruILU3dhJ/T6AxHUAtRGQfDaiqMbCJkZTL5bx8HqRJMciu0w3r3D12GRIY KEfPDvr04+wYdyXIZJIg== X-Google-Smtp-Source: AGHT+IGzh1xap4Ts7q/qMwDjFomKf68cbQiuV45oqs8jNdcHh03hAWs8FkCgLB54aOlILoZlJx2myQ== X-Received: by 2002:a53:b20d:0:b0:644:60d9:752f with SMTP id 956f58d0204a3-6455566db73mr8588618d50.97.1765919407789; Tue, 16 Dec 2025 13:10:07 -0800 (PST) Received: from localhost ([2601:346:0:79bd:7f3c:658f:3c84:2aa3]) by smtp.gmail.com with ESMTPSA id 00721157ae682-78e749e59c8sm43191507b3.31.2025.12.16.13.10.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Dec 2025 13:10:07 -0800 (PST) Date: Tue, 16 Dec 2025 16:10:07 -0500 From: Yury Norov To: "H. Peter Anvin" Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Rasmus Villemoes Subject: Re: [PATCH 1/1] linux/bitfield.h: replace __auto_type with auto Message-ID: References: <20251216205238.1241694-1-hpa@zytor.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251216205238.1241694-1-hpa@zytor.com> On Tue, Dec 16, 2025 at 12:52:38PM -0800, H. Peter Anvin wrote: > Replace "__auto_type" as described in commit: > > 2fb6915fa22d compiler_types.h: add "auto" as a macro for "__auto_type" > > Cc: Yury Norov (maintainer:BITMAP API) > Cc: Rasmus Villemoes (reviewer:BITMAP API) > Signed-off-by: H. Peter Anvin (Intel) Thanks for the work. The compiler_types.h is included via build_bug.h -> compiler.h. It works because there's plenty of BUG_ON()s here, but it's better to include the compiler_types.h explicitly. Can you please send a v2? Thanks, Yury > --- > include/linux/bitfield.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/bitfield.h b/include/linux/bitfield.h > index 126dc5b380af..ecdb8e66dbbe 100644 > --- a/include/linux/bitfield.h > +++ b/include/linux/bitfield.h > @@ -243,7 +243,7 @@ __MAKE_OP(64) > > #define __field_prep(mask, val) \ > ({ \ > - __auto_type __mask = (mask); \ > + auto __mask = (mask); \ > typeof(__mask) __val = (val); \ > unsigned int __shift = BITS_PER_TYPE(__mask) <= 32 ? \ > __ffs(__mask) : __ffs64(__mask); \ > @@ -252,7 +252,7 @@ __MAKE_OP(64) > > #define __field_get(mask, reg) \ > ({ \ > - __auto_type __mask = (mask); \ > + auto __mask = (mask); \ > typeof(__mask) __reg = (reg); \ > unsigned int __shift = BITS_PER_TYPE(__mask) <= 32 ? \ > __ffs(__mask) : __ffs64(__mask); \ > -- > 2.52.0