From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E717733B95B for ; Wed, 17 Dec 2025 09:31:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.67 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765963900; cv=none; b=la7XpGRhrcXsUZiSUaJeCrmwAtTVPGvzdOVNEqeX1OBZHdY7WVsqN6C/w4uXNbRBK/eNkWVWRUHi2IIzY4TvI4N3XxYvKOIm0yLIidDQ4f9Q1/5gvMc6AeNbVk7lRe+WEfkpgq0+vONWpxgEZ2d0eXpxhyBnes6M2e8iTXXykTY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765963900; c=relaxed/simple; bh=Yt8k6jHem+sjqoJ9MdbYAJqiWv3kHqcoVBPkLP9hJ7M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oyqgB+2S8qThk4s1cHMN76eGa1Vtd2RSqbY8/xlkUtnuWu0u0PE96eVVbE3lkrq1lrq7HdBT4J8QecdDlWaFmBXY2v6mgEV2MIctLlIiwtb9/OViT8jh4TkjE+fNxUotVNJ9zr9np/5Ogar30mNdKSLKGya6Z74NYg2VsFXbPf8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Cgst9XJs; arc=none smtp.client-ip=209.85.221.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Cgst9XJs" Received: by mail-wr1-f67.google.com with SMTP id ffacd0b85a97d-430f3ef2d37so2717437f8f.3 for ; Wed, 17 Dec 2025 01:31:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1765963896; x=1766568696; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Zup+NREwv4bDGFbQ2A2HUXZHOK+ZTfY+5pUYXAKCRlU=; b=Cgst9XJsx2bHZs0IePYRFKgYK5zTf62alX0LSd+593nF9vY3cGUecJdb2GHmwqIxln W/D7+95R+VOE1Ao0yOf0rtmpvdbvdXFt+c1RaePfSriGhw3OB10EKX38LQKy3L5zhSB8 NKyMiw9KrJoEsqdT6HHi0YC+QcyfGTjtn/TsPgwWWAqeSJA9Yy9zueHuNR9a1owGB0Zn /TiO08EUmjyi/wRqfka4GWOpCUnkSnGwTRImgbFjvArYjmXBhivu/9+Iy2gh9LzYH8KQ mbdU+ZzTb8IXImXyvyallde2jtY9DJwk4C7GuxdhROaEM6WoovfHqdOvIUN63B8wvLpP ulzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765963896; x=1766568696; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zup+NREwv4bDGFbQ2A2HUXZHOK+ZTfY+5pUYXAKCRlU=; b=ZKntBoEEfe01CL4rdTSX0WS8gVYdN+ONexEPDI7ylfPtemTaBW2X3Xr6TcC4JBrJ3j 8ugxoVvp7sx+2Cr56EQNj5SW7M5nzvNhOOmbDwR1iRPmoBCLpvplHgCN3GKZyR52WzuP FxP71cMpEdGCXPB9Swel+6uR2bx+jsc0PCpu0JXhBjEbZZBkqOR/itCu755SkUXbGF8w 1KQ/NEYt4GIuzZEewZEsjcziRyVsgpnbGD9Kfzi9PCPu1KUkpngDErmpYb061IvB+cdO PFicQXmCaSG03HZQuEAuJtjLu49fJ5FGy1CroPnJ5Pzv3/XNILP/uZNfcSOlQ7KLwo2W AnQA== X-Forwarded-Encrypted: i=1; AJvYcCURGCQVnkAP4dQ3fTi/Q4L50c3x3AkpS56NYMGyTAnGxU7zcCi30aybGc82ApKH4fGXUVRd6vtBkwg4MDQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/3fqdCnpeAAL/bGCiD+j7SkGbDafWaSgs9L8XmBPQ1X4yLYta ulHVXHchODyJGkcfz8Ib9Rn/qTgff83wFIZnZp/XGcoAYcUnobVg94TdbGY3+6rTgls= X-Gm-Gg: AY/fxX5Z1Ct+WQFHAExnQ7QlOqRUYQOE3Mugygduo2pV9DcZx/hDMMw7NsZiKV1puaG ClDEeeyfBt3DB/++akZgEaxBbI4ywBDNbHD9ljPJkq5gtJQC0Q9+4j58DimaiuyR7/vkL0gv8+7 4pD5tOf9jf6QFGFdJW0C05C4OFAi2G8ETMTYqdeYs5RqROSF6OyAHPA1lb7AkVn8RKyUhsfV+yo jo+TPNhIEF/1bxywNsoq0SraNh0gCw5bks/RQekYUBfMRbdVaC/OxT0dl3HbfUp4Em8+UGRTdl7 5M9CbX8HUkKRjSGAfBKCotxqnShQf+RjO+sTQ6M1y0UoTUwhW2PXSAlKnwosFLFKQkYDBy2KsvC 8Kk0ZFVtZ9o4NhS99ynJJoGT2kyZWcSNrXIPk6K6lsQJZuWT9zxy+GLDW2zSpm5e5Ixq4xXoxDZ iaTi6hNhi5MJ7fy3d7n1ZBc/Gl X-Google-Smtp-Source: AGHT+IHUg2s9qNRy2h8qzqEF7qPvmz9s/zPHkKaoW/kuwR3Q+5QdFqNBmMhrQm4/Lja8vlq0ergnFA== X-Received: by 2002:a05:6000:4285:b0:431:3a5:d9b2 with SMTP id ffacd0b85a97d-43103a5db00mr6698510f8f.39.1765963896012; Wed, 17 Dec 2025 01:31:36 -0800 (PST) Received: from localhost (109-81-92-149.rct.o2.cz. [109.81.92.149]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4310adad05fsm3888033f8f.15.2025.12.17.01.31.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 01:31:35 -0800 (PST) Date: Wed, 17 Dec 2025 10:31:34 +0100 From: Michal Hocko To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Roman Gushchin , Muchun Song , Vlastimil Babka , Meta kernel team , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chris Mason Subject: Re: [PATCH] mm: memcg: fix unit conversion for K() macro in OOM log Message-ID: References: <20251216212054.484079-1-shakeel.butt@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251216212054.484079-1-shakeel.butt@linux.dev> On Tue 16-12-25 13:20:54, Shakeel Butt wrote: > The commit bc8e51c05ad5 ("mm: memcg: dump memcg protection info on oom > or alloc failures") added functionality to dump memcg protections on OOM > or allocation failures. It uses K() macro to dump the information and > passes bytes to the macro. However the macro take number of pages > instead of bytes. It is defined as: > > #define K(x) ((x) << (PAGE_SHIFT-10)) > > Let's fix this. > > Signed-off-by: Shakeel Butt > Reported-by: Chris Mason > Fixes: bc8e51c05ad5 ("mm: memcg: dump memcg protection info on oom or alloc failures") Acked-by: Michal Hocko Thanks! > --- > mm/memcontrol.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index e2e49f4ec9e0..6f000f0e76d2 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -5638,6 +5638,6 @@ void mem_cgroup_show_protected_memory(struct mem_cgroup *memcg) > memcg = root_mem_cgroup; > > pr_warn("Memory cgroup min protection %lukB -- low protection %lukB", > - K(atomic_long_read(&memcg->memory.children_min_usage)*PAGE_SIZE), > - K(atomic_long_read(&memcg->memory.children_low_usage)*PAGE_SIZE)); > + K(atomic_long_read(&memcg->memory.children_min_usage)), > + K(atomic_long_read(&memcg->memory.children_low_usage))); > } > -- > 2.47.3 > -- Michal Hocko SUSE Labs