From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C074154BF5 for ; Wed, 17 Dec 2025 08:55:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765961704; cv=none; b=SXYAG6kLHL0pvlyQhmmnzdre79iS8GDlEb7Le8xJcA1Pid09N9JV6zsD8354YoTo/ZWwWe8lI3pw38rSjshUV6eNioI2OF2grF7cEyhV87zdVylXPXm7CdIktk5k2MESdKS/hPHEWf6euKQ5jrW6wyKiz/4E5NoTkfxlMqxDS8Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765961704; c=relaxed/simple; bh=w0FHTFGg4YSiCaetVCfXl4zOuMdFaSwBO8Kt5cjfOZI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EnSCkzMFyJnw7v8Ju8XTg4G0qI9tNA5hHrP8eYoKXmTCx9ZDu8SCiKPy346XEooarfIgWSadDSAOGZ9hVK4NGOJBphUJ3YxWaxehVxEVZ9O7b2+HaGlMbdlfUBANGtnjt5fMOXyc6zqE3zFJH3UBKTIKa0RnkSJ5AkBK8/oUNPQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=I+DOCDEa; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="I+DOCDEa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 015BDC19421; Wed, 17 Dec 2025 08:54:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765961703; bh=w0FHTFGg4YSiCaetVCfXl4zOuMdFaSwBO8Kt5cjfOZI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I+DOCDEau51zTc0zDQcWycQX9b8AHhkOS+LJR1mXf1yOM37kFup+tE+cTI11QkucS PhRN5Hub2zbmrMbHLxBpWbXYgna/q1btxI2z5k2fMS3JBsTRUHGcKP8/uOvraWtgkH D/SNKV7eZUrp+wb5j2oAsMmkgPkmnrjxt3YiCBCjS8FmPl7Us+3yPuwvIz+ISoJNw4 g7cWGzIUudLHyaU+6c8ktrr7eeB/xwFW/7WesoV9DYum/RNuNPa8Uzq4HJbg+Bkipj 90ypIkpIyNDlf2iW9iFe6MntDwIvWTcsE/qluzedOqO6NDhHtQDiaXsIIEdLa14Al+ 1gPri9NLfRr3g== Date: Wed, 17 Dec 2025 14:24:55 +0530 From: Sumit Garg To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Jens Wiklander , op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 02/17] tee: Add probe, remove and shutdown bus callbacks to tee_client_driver Message-ID: References: <667477a172a4296ee060508a5778be7b0d2ca375.1765791463.git.u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <667477a172a4296ee060508a5778be7b0d2ca375.1765791463.git.u.kleine-koenig@baylibre.com> On Mon, Dec 15, 2025 at 03:16:32PM +0100, Uwe Kleine-König wrote: > Introduce a bus specific probe, remove and shutdown function. For now > this only allows to get rid of a cast of the generic device to a > tee_client device in the drivers and changes the remove prototype to > return void---a non-zero return value is ignored anyhow. > > The objective is to get rid of users of struct device_driver callbacks > .probe(), .remove() and .shutdown() to eventually remove these. Until > all tee_client drivers are converted this results in a runtime warning > about the drivers needing an update because there is a bus probe > function and a driver probe function. > > Signed-off-by: Uwe Kleine-König > --- > drivers/tee/tee_core.c | 68 +++++++++++++++++++++++++++++++++++++++++ > include/linux/tee_drv.h | 3 ++ > 2 files changed, 71 insertions(+) > > diff --git a/drivers/tee/tee_core.c b/drivers/tee/tee_core.c > index 51379f7fc5d5..a015730664c7 100644 > --- a/drivers/tee/tee_core.c > +++ b/drivers/tee/tee_core.c > @@ -1398,19 +1398,87 @@ static int tee_client_device_uevent(const struct device *dev, > return add_uevent_var(env, "MODALIAS=tee:%pUb", dev_id); > } > > +static int tee_client_device_probe(struct device *dev) > +{ > + struct tee_client_device *tcdev = to_tee_client_device(dev); > + struct tee_client_driver *drv = to_tee_client_driver(dev->driver); > + > + if (drv->probe) > + return drv->probe(tcdev); > + else > + return 0; > +} > + > +static void tee_client_device_remove(struct device *dev) > +{ > + struct tee_client_device *tcdev = to_tee_client_device(dev); > + struct tee_client_driver *drv = to_tee_client_driver(dev->driver); > + > + if (drv->remove) > + drv->remove(tcdev); > +} > + > +static void tee_client_device_shutdown(struct device *dev) > +{ > + struct tee_client_device *tcdev = to_tee_client_device(dev); > + struct tee_client_driver *drv = to_tee_client_driver(dev->driver); > + > + if (dev->driver && drv->shutdown) Is check for dev->driver really needed here? I think we only reach this stage if a driver is associated to the device. Also, it has been dereferenced above too. Apart from this, rest looks fine to me. Feel free to add: Reviewed-by: Sumit Garg -Sumit > + drv->shutdown(tcdev); > +} > + > const struct bus_type tee_bus_type = { > .name = "tee", > .match = tee_client_device_match, > .uevent = tee_client_device_uevent, > + .probe = tee_client_device_probe, > + .remove = tee_client_device_remove, > + .shutdown = tee_client_device_shutdown, > }; > EXPORT_SYMBOL_GPL(tee_bus_type); > > +static int tee_client_device_probe_legacy(struct tee_client_device *tcdev) > +{ > + struct device *dev = &tcdev->dev; > + struct device_driver *driver = dev->driver; > + > + return driver->probe(dev); > +} > + > +static void tee_client_device_remove_legacy(struct tee_client_device *tcdev) > +{ > + struct device *dev = &tcdev->dev; > + struct device_driver *driver = dev->driver; > + > + driver->remove(dev); > +} > + > +static void tee_client_device_shutdown_legacy(struct tee_client_device *tcdev) > +{ > + struct device *dev = &tcdev->dev; > + struct device_driver *driver = dev->driver; > + > + driver->shutdown(dev); > +} > + > int __tee_client_driver_register(struct tee_client_driver *tee_driver, > struct module *owner) > { > tee_driver->driver.owner = owner; > tee_driver->driver.bus = &tee_bus_type; > > + /* > + * Drivers that have callbacks set for tee_driver->driver need updating > + * to use the callbacks in tee_driver instead. driver_register() warns > + * about that, so no need to warn here, too. > + */ > + if (!tee_driver->probe && tee_driver->driver.probe) > + tee_driver->probe = tee_client_device_probe_legacy; > + if (!tee_driver->remove && tee_driver->driver.remove) > + tee_driver->remove = tee_client_device_remove_legacy; > + if (!tee_driver->shutdown && tee_driver->driver.probe) > + tee_driver->shutdown = tee_client_device_shutdown_legacy; > + > return driver_register(&tee_driver->driver); > } > EXPORT_SYMBOL_GPL(__tee_client_driver_register); > diff --git a/include/linux/tee_drv.h b/include/linux/tee_drv.h > index 850c03b2cdea..e561a26f537a 100644 > --- a/include/linux/tee_drv.h > +++ b/include/linux/tee_drv.h > @@ -315,6 +315,9 @@ struct tee_client_device { > * @driver: driver structure > */ > struct tee_client_driver { > + int (*probe)(struct tee_client_device *); > + void (*remove)(struct tee_client_device *); > + void (*shutdown)(struct tee_client_device *); > const struct tee_client_device_id *id_table; > struct device_driver driver; > }; > -- > 2.47.3 >