From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00D3127A442 for ; Thu, 18 Dec 2025 14:07:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766066846; cv=none; b=FzHQF3EnzS3/Gh+nSovhIQiPfuuxY2vlFR3cNbSye5upgFwbmxQ4ynJnuZIp4KjThlgHgllcr2UUAN/mWPY2jh8eWiwW08DFW2v+vS+5FCFxfY1xYtfr4TTtvO/xRMtOeIt8yvXHaiYhoPQGxK2qZm4PdlIKIC0JUEoBuM2MYXU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766066846; c=relaxed/simple; bh=cyRkwkcif+K+CsZdzk1eOhaZBfXb1enbIIPQ/KkKAqc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Mxj63d4ERWo/++EHUfJvUgZ1D6B/Z9ZphhT3T1OI8fgEAivzc6ltvHGo6H3KHWvY5pLbIJlnDgDOg/5PnVEYnbULAYreetatglVJ8e5aMcApBwP4dMyV+lbNzgZfJrvuZ9eoJujGCrAVxrfUt3JdGfQknCFVrjbcZGd3coZFpu8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=rqBlpTi6; arc=none smtp.client-ip=209.85.160.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="rqBlpTi6" Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-4ee158187aaso6677311cf.0 for ; Thu, 18 Dec 2025 06:07:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1766066842; x=1766671642; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=o3Yk/IRp6Zp7DBqOloMlN8iycWBryyxsjXHj1unL15o=; b=rqBlpTi6gWCjzaKJVc1hWZc7WLEa3cozNhHEue9Yu9Knzgo5QWKNtlj+J1G0R6laoT NRnbuwoWUDDqZLz0TwNBWADsVTu88KNRXaleUHO1U37zZCZjCyiuhYfCzM9mReHCpYqJ qFHbXU/nRKDdY/HCgzwJamyNDTxTfGBOjdrlUjOXauJNLeFLGvYMKw6qqCAw02mB3LB8 qAqnA6seun9tZXPLPnt5iy16PszzMHjdRD67J3rbPYONuhQELRNJSiU2GBVoDSeSRE+A 0EQO1KFhS5c7/HOL3oXGoQ8nqPoR/hHQ7kHwnYVBZCzZ2IICBxVVHb9SfzjLO2YMOcm+ PnYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766066842; x=1766671642; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o3Yk/IRp6Zp7DBqOloMlN8iycWBryyxsjXHj1unL15o=; b=QAyTa4d1PLywEtIkYr6wlfeEXzJMazrkyGmUUdsWJndN6srczSVfa2CPNu/XPEQw9l VB6wy6XvHnCvK4p/+GJiS2x5dbGW1ag4F73dxfSw9vkUoJ81w+EgnwbTuD9PVq+5CyYK o8lFrvW81K6sM5AJTCklt73ES3AAzL6mvEy3PI4yoG+zSbq8ZAZuwPDrmM7TPew/YXZp 2HAoHt3mF9EYhMyobw8TPGqwHPPeOFqUEF7gpwy+/BI9C8qrh7ddcvcnpNfEF35EMKOH jG5sPLrGAUyphHmNAiar077N4uk7pJpYi7C8AZ2nRfbou5E4Sj6KO3dN3eBm7O4z0VgC AGQA== X-Forwarded-Encrypted: i=1; AJvYcCXmapCpvUXMM1gNgl0C2v/yKFwrnJtdXM8HP8IdXRcGvjghy5grhGAEgFZhbYLvfZKcUq4vvpW+iar/p68=@vger.kernel.org X-Gm-Message-State: AOJu0YyTqd4InJj3h18kvbsb17R9a67XbmAsPIcWfOyVZ9po6RRx9Kwg zZR8+3uuYAF906jDvpJdq2rbwhpQWd9AmZ3dEtjOeumUKZRgVpS+L7o+7/0JSB9h3LA= X-Gm-Gg: AY/fxX7AIahkH+DQ4+ROzc8csjeFlSLZqGMPypsjDtOgD4sC4wNR/2BhCCeioqipzfb I/gWtnvH+aSn0+qTPS0YnoRgVdQajV2UkeLJWtAY2CLC4FYARNIgTYlNDDBVpxj6fKvMhmOMyht /I5lYRUfOvBeMnh1u28ZTnKy0S/T8WOSs8uFF8rLe6Z3ydeG6ebd33ipEDXKO+0YVVdCzIdNLzj eOjUsrexTwXPmbng76OSvZoH46S1zd6RgqX29WtvyYodPuevB1PhKjjwK1w5KKoaScMUxPP6C2D EKeluDRHuE1zzN9EhTbk2wsrYS/wepOf0Slv6pJszZg1e1Id1sOsjstkLgSsbSAw5iM2g2b5yhy YMlLtMDK8ODz2YInSA2aTWWMs2/vXG1Pdyp5dfnKZM2zsvLlhdqn7jjIB2RP7J1zM5CGIlEN1OY BVCQgWaoANXA== X-Google-Smtp-Source: AGHT+IE662eUXVCxzedx+R7CP6z1+RBNmbFjm/pj4Sw6Hxp9pdtcZdIHfK528VnH65h3sOZ1zf3hCg== X-Received: by 2002:a05:622a:1650:b0:4f1:c66a:f36d with SMTP id d75a77b69052e-4f1d059c8cemr279117411cf.42.1766066841750; Thu, 18 Dec 2025 06:07:21 -0800 (PST) Received: from localhost ([2603:7000:c01:2716:929a:4aff:fe16:c778]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4f35fca94e9sm15687941cf.11.2025.12.18.06.07.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Dec 2025 06:07:21 -0800 (PST) Date: Thu, 18 Dec 2025 09:07:20 -0500 From: Johannes Weiner To: Qi Zheng Cc: hughd@google.com, mhocko@suse.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, david@kernel.org, lorenzo.stoakes@oracle.com, ziy@nvidia.com, harry.yoo@oracle.com, imran.f.khan@oracle.com, kamalesh.babulal@oracle.com, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, chenridong@huaweicloud.com, mkoutny@suse.com, akpm@linux-foundation.org, hamzamahfooz@linux.microsoft.com, apais@linux.microsoft.com, lance.yang@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Muchun Song , Qi Zheng Subject: Re: [PATCH v2 28/28] mm: lru: add VM_WARN_ON_ONCE_FOLIO to lru maintenance helpers Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Dec 17, 2025 at 03:27:52PM +0800, Qi Zheng wrote: > From: Muchun Song > > We must ensure the folio is deleted from or added to the correct lruvec > list. So, add VM_WARN_ON_ONCE_FOLIO() to catch invalid users. The > VM_BUG_ON_PAGE() in move_pages_to_lru() can be removed as > add_page_to_lru_list() will perform the necessary check. > > Signed-off-by: Muchun Song > Acked-by: Roman Gushchin > Signed-off-by: Qi Zheng Acked-by: Johannes Weiner