From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03F3434BA4E for ; Thu, 18 Dec 2025 15:16:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766070999; cv=none; b=MncoExyMPzR4SU+3EWtLGPQ3YBPqnfG+cFw/di6wXmdPWBRGVHkI2VaiW1f56w9JTBC6QJ9vK+hp2Ga+1xeqev67tz3fmY4jurwZQPb8NvfxIF8TslmwsOgyZY8kg7SJ+U8Hvd4/eLuYaMkNYd46uPxC2I3OAlRhMi1remEDqD4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766070999; c=relaxed/simple; bh=ffSKSXXWSRpI3xx9H/itO7rvifidsrztH8orFHjfVHQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=C3DGMrlCmTgQE4ONavv8+Aorhksyz0CiPwRLmmUEnyOd01LRLOKzoqeD10PRIriTs1Bs+AuNVc023jHdXSgISBzpkfHyL7Zwou+ObUzn9DshZAbDbMoYNKWSYqEQpQuMBaMYTUp8YTyc79x/rbzir6RqQ4LHGZJrdlgom3CX7u8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h0lWPtZY; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h0lWPtZY" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2a09a3bd9c5so6691695ad.3 for ; Thu, 18 Dec 2025 07:16:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766070995; x=1766675795; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=V4YgC8/woMPQ+Xj9m7PS+PcfWejcCQtxAUQpAaE4ZbE=; b=h0lWPtZYVADkGTZc8MIJ6KbOuFbtWr/CEXOluJHEz2yZ1bAjk9sGW779lPFLgXI1ng w6g53qq5sVXBeMTAe9FeTcWlLkX4usFrwpYYQVZJHb/OvY4wc0BMaXtKd+lA16mcX/sT y+9bs6Qv0uyw0Zkw6/0xrNTBG3NQbndXsBmbDQWVHIxtF/QRrcGix0EQBrGysq3s0EDG LRE9j3HkILsaev3RfwXtZf1bWR3yk3PPfML3rKhHwmwiFIIvLq64mFrlxjzXlX74eJFK 1PQfelxdp0P0h+G0nTn7+lYIQHlQIKG4RK/K8pA6uEiyWSBHfOFEWkA0CUUlOMmNe5uw mMmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766070995; x=1766675795; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V4YgC8/woMPQ+Xj9m7PS+PcfWejcCQtxAUQpAaE4ZbE=; b=rK2JKAuomQnpCgXlqG4wtDO1r34lZf8ElCnIDAmqX7aa2gAWo5/P44lgjqe6TUTvMI mj/FO5YMTR4Wt2NlVs9NxSJ31tJapP7hbJMt5gMB6q40sx1HfpECtbaRZFL8C6jVPPk0 eQ1qmVjRf1jf6wmI1ePyc0bnUtuHLz5FJ2kDkpvAt1RV9tg5PriP1hmjF2JmOjrF7824 lqKqVvLQVKNSOm2NvwaYz47/h4P8EvOt3EFQ1Ga1m8TOzEpvsil4Okwi/eNWEH+yZc8D syKXA5/lBuHdTbIndACYgU5tpsW9HG9q5MpqyUTWupdNzrsmfC6LK1MEZK2zH6Lt/Oom Lbmw== X-Forwarded-Encrypted: i=1; AJvYcCVrHS3XveX/AHgRv/WfQW4A4ng/x2xjKmxvswdN2jsHKwjfx1K6pfkN1zbmfE87DByak+itq+tUck7cfmU=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2qI03Yk9tfAgrtBqPKJ7Re9NxHDEIZPnoZdr9MX4bNdkLZKTj jb5IpsZ/mM9jwxOdSnM1L408TMs7drEAIFV4TenMOZD03sfks9mR6Yom X-Gm-Gg: AY/fxX4RXNZpZ2+b+n+2KSS3NYPlhrTsJJaQ8niDGiUzVlWOEkEdoJvaQmsmQt8UPtP puQz+Z+EVmr24lk0PqyZrSxfnmR0CrttGavsxKIpBQn8hyhN+CGdo10DX4vjEEb7B3fDCdiDv5F hyc0yqAesbVvxQ+1EndFdgvg77u4TUQpG8WGgHVcyEwTQxCqBExm4G3GqHKQ8XnVqaTaoH4bzJ/ wpNf2zh+IVpzdMXXEkLPJAIbdJJnUVkG6MyWYNiscApyriWzTpPKTXehGUABgFJBnJT04pahfDo Ml6krbYXAfaUffACeF+ZurI91IN0s3qqtNZ4TW0l/OGoWLMkHHPXQlgHCDMJ3v0Jzw7RCs2QGHy 6Ih5X3RSLvdq3k3TZ1QdIs9KJb4doAe6LZojAxTu/w1MZ9HB1QH9ZIPh1qCxnz1qyb1TAumyV4k pZd24rQ9XuO4h6gowS63ACDFPLxCYCNLAo+vJfGK5V5y2oufkX0BrvZwAjAIuzIe4PFjeVFldH1 8VooX3VqNtdPMf9UASbB3gSYWJcqUdpUBwRC23+vycfuqrJNzKz3BEMmMMqtLTQvYFm X-Google-Smtp-Source: AGHT+IEFIRglE5Bb+2e+0uum5FO1qaZ3iQ7LMvzkffpqPwvsjCl32isCjpg6y5tRTxoVDhkYEOmzfg== X-Received: by 2002:a05:7022:1b0c:b0:11b:ceee:a49f with SMTP id a92af1059eb24-11f349a17bdmr15451076c88.8.1766070994721; Thu, 18 Dec 2025 07:16:34 -0800 (PST) Received: from localhost ([181.191.143.42]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12061f5412esm9195941c88.6.2025.12.18.07.16.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Dec 2025 07:16:34 -0800 (PST) Date: Thu, 18 Dec 2025 12:16:32 -0300 From: Tomas Borquez To: Marcelo Schmitt Cc: Jonathan Cameron , Greg Kroah-Hartman , Lars-Peter Clausen , Michael Hennerich , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 2/5] staging: iio: ad9832: convert to guard(mutex) Message-ID: References: <20251215190806.11003-1-tomasborquez13@gmail.com> <20251215190806.11003-3-tomasborquez13@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Dec 18, 2025 at 11:34:05AM -0300, Marcelo Schmitt wrote: > On 12/15, Tomas Borquez wrote: ... > > - mutex_lock(&st->lock); > > + guard(mutex)(&st->lock); > > switch ((u32)this_attr->address) { > > case AD9832_FREQ0HM: > > case AD9832_FREQ1HM: > > @@ -203,22 +205,18 @@ static ssize_t ad9832_write(struct device *dev, struct device_attribute *attr, > > ret = spi_sync(st->spi, &st->msg); > > break; > > case AD9832_FREQ_SYM: > > - if (val == 1 || val == 0) { > > - st->ctrl_fp &= ~AD9832_FREQ; > > - st->ctrl_fp |= FIELD_PREP(AD9832_FREQ, val ? 1 : 0); > > - } else { > > - ret = -EINVAL; > > - break; > > - } > > + if (val != 1 && val != 0) > > + return -EINVAL; > > + > > + st->ctrl_fp &= ~AD9832_FREQ; > > + st->ctrl_fp |= FIELD_PREP(AD9832_FREQ, val ? 1 : 0); > > st->data = cpu_to_be16(FIELD_PREP(AD9832_CMD_MSK, AD9832_CMD_FPSELECT) | > > st->ctrl_fp); > > ret = spi_sync(st->spi, &st->msg); > > break; > Since we now have the mutex unlock handled by guard, why not returning directly > from each case? > E.g. > case AD9832_FREQ1HM: > - ret = ad9832_write_frequency(st, this_attr->address, val); > - break; > + return ad9832_write_frequency(st, this_attr->address, val); > I think the last return (outside the default clause) won't be needed anymore. Wouldn't work because we need to return len too, so it would be more like: case AD9832_FREQ1HM: ret = ad9832_write_frequency(st, this_attr->address, val); + return ret ?: len; Which is a bit more repetitive than just returning at the end ret ?: len, but lemme know what you think. > > And, since you are touching the lock, you may also update to use > devm_mutex_init() (that would probably be best appreciated as a separate patch). Yup, sounds good :) Tomas