From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8254228506A for ; Thu, 18 Dec 2025 19:37:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766086625; cv=none; b=PdS9PQCpvmWVDDuGMp8SYX/m+3nt9SHZLvrLRZf7mn5HbA11aimDQZQRxkReIkiqaYyUsmw1NhafW/KvbEYZu9UJsLdVqDi0WnLk1DNlRna71vn3Hh/UCFqvi8qMcsrfZl8kPoqlmaENjQdvIYwg59q+c0HI0CkS3BXrEhfygCQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766086625; c=relaxed/simple; bh=w4ijCxv5nGSdlsC0Jn4air83tfFljT1G/MgpGFT8x2c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GEyXvy3btHipAJVM3pI/gTbjyBIx0Y/74zOFOmOah7JRLT9f3tsxKLApwIIt2ejxNfo4Wz5JM0s8D7+FdZMJF2QuSF0A29OJMdZyaaz1SAi5lDmLfADWniE+m/hQCpgttjESB/znfvrE3g8iEbryvxltZXG96xb/n+YdUAD+Tj8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V3mDVdpz; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V3mDVdpz" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-42fb6ce71c7so804205f8f.1 for ; Thu, 18 Dec 2025 11:37:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766086622; x=1766691422; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=k+3WA68tbyaWMaCBDkCMe377aB/ts6/EjKX02uXHPEQ=; b=V3mDVdpzRde0aL5+DL8MHZFbB+/g9/XS7RBj/PrMLHpNF7ysCDLOfqAGAE4644/g+r nhlykoxKxQ94DhCO2p1Jl6wsuRjfAD5T9/36DsQjHKjwRMyw2bm6SJj8zM4lEXv3XHLX DRpsBQ9IJvFYDmbEKz9UmesYhHoqsUXeNytmPXQ9x13Tf59WTjTUCgpQlHSWJnB4vR7T 63B2Ec6dlyy6JynhjHH+jJQCMSchIugzcGbdA08YPdseYqHxNxIs+rjfpfP0Vyt93WXq 5LqpzcbVZVk2fSihpCsKTcWH2pF+wxvcP212ync+LlhWw4XRV7vS3IWebewzgKNBq+X6 w2VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766086622; x=1766691422; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k+3WA68tbyaWMaCBDkCMe377aB/ts6/EjKX02uXHPEQ=; b=KTK+lgJ/zjTDIPGpsVg5vAbX71E0MPoHu1LPkUbhAheuIUz2dFwyrs6b1y2EEMUK4f bRZIWrLs0nEhR1ijGCpYmQpbdiYMPzqrRL9m4PhztfVJIIZS1yv1//tjHA+03hc/CL1P N58uPtZILI2IY8aqpspdUGH+bh9+kpzpNxMKl37F2tAjT6C8YVzMec1W70DZa1DrPWer nvwZdvJ4lxbnTdBolpmZ6cTb6KVxH0UQvODQc9HZFIsc2Jc0dJ4hoerBw/8cypnok8+A maJJ4JDSGkd8L45js3Vg1rxAKVHum8TSJkyp2o0jpJg9kOZR1kij1IxZDCBFKjay6UyU kUFA== X-Forwarded-Encrypted: i=1; AJvYcCXYCFCxDg3hNr+Fs83Q8gVdC9rYRuM1bBgCTv00wNFH2zanE/3JNVUabbYkwscA+gRF4Zmxy2jYsN0k4AE=@vger.kernel.org X-Gm-Message-State: AOJu0YyrJfMSqhYsYZQUFTzEhHYTiUqKT3EQx2y3XGzYNbpI3dWGKJ1Y MrJgbrMtJaT4cvhnw3Xk41ZNAUquItgTEMnP4GF24GuNBIg1frNMBgvp X-Gm-Gg: AY/fxX5vjjNYvoks2YTNuGsZ2zxUkB0r8Dc1Vt/eFZ3d7rrw/E1qhM7mh2+y77AOqWb 8oot+fOLKbmPI/qo31iNIllLWMF9wvJCzbppqR2dg/a9XHtib+IYm9lNXHMxuCQLHF1+rIR3c8X vo2FWtz1VvUiScOqvLP3ENlZrqEafZLyGAaPH1JHdCk50JIDZi64zyWYBjx1xuJJdTNOY19uFWX xJdXPi1fZWPz9l+mi+RuIFKHtDD5ekCqeF2liJoxvzqCHhr6WkyX0rXrtC5SDX0mETmTc88naxu 1lj//Q1tkDHEXz6sHi8i7nSWoCeOIciNeC77MeVQqvd2cIzqP2vrvn2yjBIryiQV+R0iHZJ4rNS jzLApKkn8PdY75TjpZkVZojbbvmgU8L+lJQMGpPKpzZ6TMpTiCiShZeig8dFn6FlCRnf3VXB4oh IwTL/UFxWGcsqrj8fvrchMg2toyG5gOQTT/jgQWP271qgHz/9Q2bIRyB4NsETNSKUCkbNPRu6Ql PVfSxS9yJMzLOYyjUkmgg== X-Google-Smtp-Source: AGHT+IHrRzBlIY+FRB9tFL8aSm3apHXMpPAzl6Tnco5Z8RZxNW6uXBEK/NYhBHMWetr8sM0EXHXAfw== X-Received: by 2002:a05:6000:220b:b0:431:701:4a1a with SMTP id ffacd0b85a97d-4324e4d0f68mr746833f8f.26.1766086621517; Thu, 18 Dec 2025 11:37:01 -0800 (PST) Received: from Lord-Beerus.station (net-5-94-28-5.cust.vodafonedsl.it. [5.94.28.5]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eaa2bdfsm555186f8f.32.2025.12.18.11.37.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Dec 2025 11:37:01 -0800 (PST) Date: Thu, 18 Dec 2025 20:36:59 +0100 From: Stefano Radaelli To: Fabio Estevam Cc: vkoul@kernel.org, neil.armstrong@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, j.zink@pengutronix.de, linux-kernel@vger.kernel.org, xu.yang_2@nxp.com, jun.li@nxp.com, Frank.Li@nxp.com, haibo.chen@nxp.com, linux-phy@lists.infradead.org, imx@lists.linux.dev, Stefano Radaelli , Pierluigi Passaro Subject: Re: [PATCH v1] phy: fsl-imx8mq-usb: Fix PCS_TX_SWING_FULL register configuration Message-ID: References: <20251218174920.359282-1-stefano.r@variscite.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Fabio, > > The change looks good to me, but the Subject is a bit misleading. > > It gives the impression that PCS_TX_SWING_FULL is a register. > > What about: > > phy: fsl-imx8mq-usb: Clear the PCS_TX_SWING_FULL field before using it Thank you for the review! You're absolutely right, the subject was misleading. I'll send a v2 with the improved subject line you suggested. Best regards, Stefano