From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58C3025CC6C for ; Fri, 19 Dec 2025 08:03:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766131411; cv=none; b=BqyWZyWdQRDRS6imiN6slQyZpaBr3EpzlbsAi+hlb6ifNxquI6t17ag85ptS6guXGbdHupoCx/AWwZnv+eboDPKy9BoDfuR7leisplA9ruwenu4hxGbqIDIwofGvJo8HAmSUWqUl8wqGiJxnsI2WT7w9XSfa6ELkbITlfr1Ggfw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766131411; c=relaxed/simple; bh=/bGIY46cuc38cb1abi/sHCeSyn+CEKg0h0yfcmVi7wM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PmrZhZxTT6Ixb349cCZzMKB7j6WuT09Xdj5/5d89h9CT3JPlvBbbYXn+x2eCD1EkPVxJ1oQnNgu8JFN1Yq82k2FQUtQOL4Lrzp2NCJC/XvNLVLd1bo9atTUknmP9YuqJKe1e1CLyD7VAwHmhB8628y/estJxByimS8+yGl7uP+o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=iLmpEgbr; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iLmpEgbr" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-42b3b0d76fcso881769f8f.3 for ; Fri, 19 Dec 2025 00:03:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766131408; x=1766736208; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=J+/ZRMSQfz2Pe5W3+kCSEEPyZ++ydw0qjFUACnxc7Hc=; b=iLmpEgbrNkqpJeLCyEr9TjVU+3Jd3Tf/BfK6tpxbTLl0EFjGPuuIFWWF4DM8I209KD Y36n73zfJ2AcLx7QWIqk0y2EQh70ls8vhkZJiecwfTON/TwATsW/x6B75KKUl4ojMwnD JwEqH1HkDuYf5RhndIQTQ2yyVBdt6SxnGpxZHnNJBIMFjfl4eXNggDN+hjZ1kVN0YuwA 8u37BLy1JNLPQ5MLFNT5rYS+cTjbq6wM2KSTy2YK1a0AWi1EP6imoZTLNCj+6imfImaX FtzE9SRZl1MabzIX+jIJr0Yt/sUJYbX84TR3fKb4MvqcHI+cJil0CN+1U1YmmrlqLtJZ z48A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766131408; x=1766736208; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J+/ZRMSQfz2Pe5W3+kCSEEPyZ++ydw0qjFUACnxc7Hc=; b=cLgCRTInAGRS3IqMFFj2+U2EnlzVoT5YHkAITiAHvcTJu5VvVyK0zZAthAYW7qY3Cy sfIfhPHKdIV2U089gF+NMsjSLY/msYSu6YERiNgJYSYzVqVnQiS+UaX299MRYtFySHzV dTUPen1t+siXEKiSeDBhehefG+bKDIGpVik7+TotV0GsuWvd+vQLf7LZMl27ZE1r4bJv LSnyiVhTZfczkm52FsNXbCS4Yda9J0Yd1Byead7o/RD2N9afTKex9S5wdbht2hzVY5xr C/7F1JeAyzzANp69DH2jHCsdoXoS8AWQPsWeIIVcMINy/VfrWaJf4CKNZ8qxsyARzBjG nn+A== X-Forwarded-Encrypted: i=1; AJvYcCVU3bmuaz6wADGs/RWMMdsqWmD0l1lm2rMDmzqg7fc48rjyQtdEb1qvw0N4ReIzgP/p4roFF1vfQl2nRIU=@vger.kernel.org X-Gm-Message-State: AOJu0Yzq46n/iLhZzHlQ8U5bQTPu5nqn/vycW+P7+M7HzrJykmnEf67F LYEoQrK7WlULU2JkoB0LP4H0nblrP1i6y8ASpefAZEMS1/7rYqOxibKzh8vCBhzegKVpQCcmfzY PiTMo X-Gm-Gg: AY/fxX6/36gyt4Y0dxIppx1r3N3glf2uEdISADR7seJmdfrxfhd15nUKXHtDwIuYX/H GZb5yYARzNMle1u4WtuhVfLuM+pBg1XreSveXsrSItA6j2Ps9rtL8ibR0LMXRxk3D4JSkuHt55Y Y1rDzDdE50WMGcPK1a/NHqTeI6ui3Rdlw6n7OXR+Q6wlReGHKpoWztyVOmWx5H9+BuE9LToxWQg n4n//dVqvGupz0eHrKU4oAAlOtTHOLzpPaw1IOpJ6qBfjiw6o8QyNhMXdy1lwy0xp3wYfk5tRUe 94crmJ5LvWFTNLIBlUQUlvZSbq+8R0wvoBiS/zNHWN0gOxow1QzHfYyUn5xN+2PatE29XtICJIJ RuobtpDlLdmE3Bq9fipD+RJ6bSqcDZ3SLIdTou/4+tgKS8YqPSAaLjHMK7oKYXPWQWV3h0Vajuo lMRZUIWW/ScwvUXRE5 X-Google-Smtp-Source: AGHT+IF2eEWgioDzK9v88hc7zvDgUmt9tMsxScJV1o/NErRD5qEO8zTzXYks9Hy32CtcRV+DzuDAtw== X-Received: by 2002:a05:6000:2303:b0:431:342:ad42 with SMTP id ffacd0b85a97d-4324e50d6d7mr2001778f8f.44.1766131407550; Fri, 19 Dec 2025 00:03:27 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea1af2bsm3644036f8f.1.2025.12.19.00.03.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 00:03:27 -0800 (PST) Date: Fri, 19 Dec 2025 11:03:24 +0300 From: Dan Carpenter To: Vasanthakumar Thiagarajan Cc: Harsh Kumar Bijlani , Jeff Johnson , Ripan Deuri , Baochen Qiang , linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH next] wifi: ath12k: clean up on error in ath12k_dp_setup() Message-ID: References: <1fa108fc-a06d-a9cf-a56a-c905e4982b41@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Dec 19, 2025 at 10:18:02AM +0300, Dan Carpenter wrote: > On Fri, Dec 19, 2025 at 10:54:03AM +0530, Vasanthakumar Thiagarajan wrote: > > > > > > On 12/18/2025 1:14 PM, Dan Carpenter wrote: > > > Destroy the rhash_tbl before returning the error code. > > > > > > Fixes: a88cf5f71adf ("wifi: ath12k: Add hash table for ath12k_dp_link_peer") > > > Signed-off-by: Dan Carpenter > > > > nit: The next branch in ath is actually ath-next. > > I'm working with over 400 different branches, right? I can't keep track > of them all so I just put "next" if it's in linux-next and leave it > blanke if it's in Linus's tree. It's automated. For automated QC, it's really easy to automate on the recieving side. In some ways, since there is only one place which recieves code and does QC and a hundred different people sending patches, then it makes more sense to do it on the recieving side. This rule started with Dave Miller. He was handling a hundred patches a day. Everything in networking except for wireless. Also Sparc and ata. This was before I invented the Fixes tag, so that wasn't an option. Greg and Andrew still handle that level of traffic but they just use Fixes tags to automate their process. regards, dan carpenter