From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11DAE2D6608 for ; Fri, 19 Dec 2025 12:59:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766149151; cv=none; b=a92XyeAF+EeRNFKW8jVydb7lwW504caF1GZqBuBEhUAtLmnhwIg9szakQxC+Rj/KgxtLUxMhhfrPhZckoVEsQaB/fQDSSDdM7Lg+kwWmf87J2vUKhdIpfFiAZSS4bC+CxCsVfx5ovB2CGd1ZwMnEnpWfqsZEI4svO3ZBzu6okXI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766149151; c=relaxed/simple; bh=IQiqP5ieYv07JRTlNyvk6XwLHvpcOoZw30QovOgFdSE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Zn+e3BTFDldXFq8CJkLYH3r7Iw+xb6NwA0R402tDByBJ4CdNRBEAgjQgayheWe9qnBnEVfK20Px69AAzMc/PdejZ+XXSDMiNUGUI3951KgZObRJqhqG3X9RoPQaLnE8EE2K2SJ5i8REy1B1ucMWiBMuGchK8AZGZQmyAAwYcObg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OUbzoGQX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MEIyuA/L; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OUbzoGQX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MEIyuA/L" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BJC0Unr091969 for ; Fri, 19 Dec 2025 12:59:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=Efa9heFDzB8Tt0RbVtYLypJD IL8Ns1COcky8O0sAqRQ=; b=OUbzoGQX5AgKZXfWabRe0G0R/5LWL4IMDbhb+4nU 4gra9cqnQysAW5WwdaRkPTnKJEq0ZsiQG4ugxkzUmAUB8/yj4Pe19qCT0ZbAnXY8 H9j3ls0VmU6JOyhmVwLjvuEpeBvliHpdiZAHiRyLwhWCCy4I1Yx/Qp/mdHyMtVEk X7GyFvD6TL1frXwLvkCGnJBaAE9B3ZqGHBG8AHf4wRuB6lDE3vIrwnIaoztzi2o8 MxL4Dh27kxPqcFdCHp7fdCxgk2G1pfZXS2w29UQ+jOvku7e2aGnOQ/1/vF3/xCq5 Yl9EDU7lghLyo0kLlCVkuBSuXU3MuFGxiHAOsEp2bv0MTQ== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b4r2eapw7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 19 Dec 2025 12:59:08 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-7b2238eef61so287206b3a.3 for ; Fri, 19 Dec 2025 04:59:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766149148; x=1766753948; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Efa9heFDzB8Tt0RbVtYLypJDIL8Ns1COcky8O0sAqRQ=; b=MEIyuA/LCKGfBDxMTGNQmdLl8qz18jj5dW4keQD4m6VLUZ6IlJ/QMoLlwI0dD5DqXu bVso4He0J2Sa6INW2P2R8Yl0/Ji0q/Tvc7zC+cZqDINSr2x/2W2inbWAD8C0t1dftefA OjUeTGBLT4LUwtQtueke0Ywrvyfeou8JmKdqi5NSvL1FEQ48cnqBv4O2omWcGgFu8p8y tD0LHCvxsCSRmQ2C65yPSI8S2lxXg9+79UY/SxVZlFf5ztbOAQNJoTx0GFRkG/rFu2mo lUoY9CuOH5YaWoIC/EclM7SX7+VcCTuW4c6KChyYf/GPoCzgWpcesb5Y4H9pVa+YTVmN L7Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766149148; x=1766753948; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Efa9heFDzB8Tt0RbVtYLypJDIL8Ns1COcky8O0sAqRQ=; b=q5qCZVzuhkFYb5vjL8EyPkUsZoL2ysa+93yYhcdJY1PtxcnTCazB9nY9wquSRQDT9O X+T5GdETry7AWmyd/e/48o2mM+5NE8Yb+iF2YrdHu1VS0N7jLFamQTrszP2ztbIA92Hl YqzEvR/XX5r8HL2/zXXNLSfVg2ZoFMcyaHk2iwWm9pfdbmFPt3dQz/L81IBzMAqF0c2b sTUjTwdNCrivboMMFTkq1sdGrCG7Z+TkUhv3ZfGFQiyJJyqfxYK8tis2OX54ocGIWXty sZVHbpmrA4+mKzZNt4YKoeggy6+OMexHplwocvg9S+UOMzLJp2jAx/wh0/RIwbmyjHA8 W3/g== X-Forwarded-Encrypted: i=1; AJvYcCVLNSc0Cnsx/umv7K5NvH21CaWCAdsAMB4it21cvRs+GAEgwAms70Okeqq36Hc1aj5qPSInnzCwKfeemJo=@vger.kernel.org X-Gm-Message-State: AOJu0YwmXm2fbeQARef+Vy0BzYG5XtWJ5BW3/ATXtoBNb8wM5XbSjAP5 2Do4cedq9gjHSVjQnww9/pvmkrNmD3u4UuqQq/a/tecQw/AkKaWJ7cx1CWxgorR1rhI11+DbOEv rQeokXiNDfPWtp85nwWt0e205dYrdQZeEVtVxbs178rLl7xfkdA5z1frhd7itkW/++FE= X-Gm-Gg: AY/fxX4YhgsCe236L+edkGpN9xneUHlkwm9k1TEZ331W+/imkz81Teh4lR8HUTWSSIO Hd0W4hXSSycSXnUoxvbV9a8HE6KvQQRABvJIssuTE5+CmjHX0D8birvCTP5kUinOTrm81DXvlY0 IIzwodJrvw2ZghFOo7oSq/kczAavqDc9JuOUvJ2UMXJ91EfHtLKTaE5Ic0PsxxewR3KKD2C7jgh 0A4/mgxcfM8RLE7JVMpC/vi687fnPanXfhknrKveLepxxg9I10f77Ff7BAJ0jF/D4wug1XFNkab 3kghjJMTktKqeWmkNgdyXE/kOJsaVUGR1MwkuH7JB26A4RJ1ghYZNZAHy61jdOtox/bDNAXJ50x jznzPwsxcJdLLOVPPipYCvRvT7++G3y64ZY20gEQAm9Y9Fr39DEGg5b1n7Trv/1d15cYHyd4dpS kvvuBiWjfyatZzrnMVi2VbCtdfU/qrXg== X-Received: by 2002:a05:6a00:2355:b0:7e1:afd9:9a69 with SMTP id d2e1a72fcca58-7ff6706198amr1788662b3a.5.1766149148001; Fri, 19 Dec 2025 04:59:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IFSgNMamhujnmgcIp+ewQqPZhNznSmn1P30c0yQhGKIZPS0ijEUb9uQ7LwUlw6/SH0esiyi5A== X-Received: by 2002:a05:6a00:2355:b0:7e1:afd9:9a69 with SMTP id d2e1a72fcca58-7ff6706198amr1788644b3a.5.1766149147562; Fri, 19 Dec 2025 04:59:07 -0800 (PST) Received: from hu-vishsain-blr.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7a844d5asm2415421b3a.3.2025.12.19.04.59.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 04:59:07 -0800 (PST) Date: Fri, 19 Dec 2025 18:29:01 +0530 From: Vishnu Saini To: Konrad Dybcio Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vishnu Saini , prahlad.valluru@oss.qualcomm.com, Prahlad Valluru Subject: Re: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport Message-ID: References: <20251120-lt8713sx-bridge-linux-for-next-v1-0-2246fc5fb490@qti.qualcomm.com> <20251120-lt8713sx-bridge-linux-for-next-v1-1-2246fc5fb490@qti.qualcomm.com> <7d31f45b-1062-4118-8769-49209908f2ef@oss.qualcomm.com> <4112ba0b-6feb-4e30-a57e-50ef9e3d6b5e@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4112ba0b-6feb-4e30-a57e-50ef9e3d6b5e@oss.qualcomm.com> X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE5MDEwNiBTYWx0ZWRfX3el1OJqH8M2T scRZ7uwoDoqPUWTnk+38eUMEXsa67xz2ro3c0Tx1FnBz3gzbafq96qsqH+cUtAynW4EbP/Nzip5 fOpDipweEUjjGV9MXK4kjUUJlA2/kP7maVtx+IRXv0IQIjAW/zmDSbeZMtwFU9YqdSqjpJ3C+yD 1k/LANZ7YTchsNA+m4NMwkF1vKziBbtNhev9Qmf2Rs5rTDlRTyOnx5OsxzBHKk/og+gK3EKLEQe UK/B66Yq0+20zeoXahQaJgckMocwU455a93vUE5zlLov3RgVF8arWfGiDAwDhrWHYuxTKdSXlGM 3Uvh2nJay3fJLycz2jxdRz4uCMYwEuMjicqQkm9+cQ2hY88j47zekCYiVIuQmwrPRezHfSVlCUQ TiVKy6PKds9GlLP3xMIB8A6fOK6DU2W6Y+sXIzpoKXZgN2cmfU/8BrUIlxdlajEIf/nFbk/h9Kc yjhiZM5D6m66LTk9HVQ== X-Authority-Analysis: v=2.4 cv=W+c1lBWk c=1 sm=1 tr=0 ts=69454c1c cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=kj9zAlcOel0A:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=rT_Bp38etaQa0i48-N0A:9 a=CjuIK1q_8ugA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-ORIG-GUID: RsCquZ5cjoWFskDOCE5pVnbt16NQmkPc X-Proofpoint-GUID: RsCquZ5cjoWFskDOCE5pVnbt16NQmkPc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-19_04,2025-12-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 bulkscore=0 impostorscore=0 spamscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512190106 On Fri, Dec 19, 2025 at 01:10:19PM +0100, Konrad Dybcio wrote: > On 12/19/25 12:20 PM, Vishnu Saini wrote: > > On Thu, Nov 20, 2025 at 01:11:00PM +0100, Konrad Dybcio wrote: > >> On 11/20/25 11:58 AM, Vishnu Saini wrote: > >>> Monaco-evk has LT8713sx which act as DP to 3 DP output > >>> converter. Edp PHY from monaco soc is connected to lt8713sx > >>> as input and output of lt8713sx is connected to 3 mini DP ports. > >>> Two of these ports are available in mainboard and one port > >>> is available on Mezz board. lt8713sx is connected to soc over > >>> i2c0 and with reset gpio connected to pin6 or ioexpander5. > >>> > >>> Enable the edp nodes from monaco and enable lontium lt8713sx > >>> bridge node. > >>> > >>> Co-developed-by: Prahlad Valluru > >>> Signed-off-by: Prahlad Valluru > >>> Signed-off-by: Vishnu Saini > >>> --- > > [...] > > >>> + qup_i2c0_default: qup-i2c0-state { > >>> + pins = "gpio17", "gpio18"; > >>> + function = "qup0_se0"; > >>> + drive-strength = <2>; > >>> + bias-pull-up; > >> > >> Similarly, you can move these settings to monaco.dtsi and keep them as > >> defaults since 99.99% of I2C users will share them > > Is it ok if i update this in a different series, similar other nodes like qup_i2c1_default > > added in monaco-evk.dts? > > No, I don't want you to introduce something "wrong" only because you > don't want to run git commit --amend > > I see you've now sent a v2 just 7 minutes after asking this question. > Should I interpret that as you expecting me to drop everything and rush > to respond to your queries immediately, or do you not care about my > feedback anyway? Apologies, for quickly raising the new patch, i thought of correcting this in next V3 patch if you ask for. I am new contributor to the upstream community, just now i setup mutt and learned a bit about sending reply to the emails and V2 patch was already validated that's why i submitted it. monaco.dtsi already have below node except drive-strength and bias-pull-up. tlmm { qup_i2c0_data_clk: qup-i2c0-data-clk-state { pins = "gpio17", "gpio18"; function = "qup0_se0"; }; }; I will add drive-strength and bias-pull-up in monaco-evk.dts, let me know if this is ok? > Konrad