From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42E8733986C for ; Fri, 19 Dec 2025 20:59:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766177983; cv=none; b=mvdxvkuqM0ZIWciSIuuy7fg8V3b121n97h6+d5ioqxJhyc0rP90lJeQ+QuLBdSyBzIucCKoUr1ZEeV9Xjrm1p/wZjrZBPgxVseWG+AL1myFlN8/L3SMfqvZCV3w8+8JpDOXh2dKzTnR5upeVTtVWdPPNtaE8WS86+hqrMNQVOJA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766177983; c=relaxed/simple; bh=aDIP9aDyZsbXXRcuuO0Vag3AVoY4Yhs5gjUCh78O/Eg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Jh+LXkd8vNnD0RMoQ16gTg8FYFXRRsPQBj5+GJIkWuhO3S32KHYyLda1roagtpmL9T/sdhKYKW9e35Gdq83ICbjCuhDkeMPzIO6mvyq189OQpnEylLm5rQL0WLyO0IMcpv2FZlicU/OcH1T152rTp8HhuLitr/v1VFh06QEMSkA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=qistaGGn; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="qistaGGn" Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-8b2627269d5so231862285a.2 for ; Fri, 19 Dec 2025 12:59:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1766177980; x=1766782780; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=adTHpWU6QNV63deZGh87BKlrZQhBd61B8Pt320imYrQ=; b=qistaGGnp1H3Wn0QSZyBesqoyRdytJw5tdtZDKnCS/xgtpGOBh4WJ7q+pt8fcy+qiw xZk4M0Zv7AC3KARJUttUQUS92fKSCNnDwjSfDMn0k/At4JtUU8R9RG3zKpuMiQ2IWlH9 LDrHV3aD0G2jh9mtzVg7nD9rXJtnpB5KQ+3wxO/TN+XVKnw1EiIxyYYZtx1myxQXc1RI w9Q0XIrtG0PIi2ugikAsNVzJr075nsh4TMMaP+uDbfwjRMsw0EmDSobHJ2FgEppA94Sg XZ+9wMOdwPicVVFgXAFHn6xINzjvmv+mhe1f7rk5sGhm4GneMv1ngX0QJDF/frN9zt83 o+/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766177980; x=1766782780; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=adTHpWU6QNV63deZGh87BKlrZQhBd61B8Pt320imYrQ=; b=QDfckBDVSwzt1zI42mVL74Elxw5y4HezJMHct5Aa0Pe5yQsNx1lKStmoZfpy/wtUtD RhCr1PmCoh9PHgy2SiKk0bBr5mxEkRhFmVjoMWVuIX7H9djBeez5OMnoCTtBc/YKY3GW AapEXRV8Zn00wQ3QRe0tXNqAp70K7913+o4QqrXSypBWt1m6UYIDE2E8c5OYM8zWIByV k7Hj7NUHbNtM9h5XDo0xmnwhFRf2zKuJUArL5W/Z0aCUNnVrXdvivY916xQn3mvluqk8 L1Gpb9jyZbyGvyc6Vuj1zOWUOCMuuzshg2QN8H97kC9GI2HiQCmoolbEdGLW0/NnhaVc B5Ag== X-Forwarded-Encrypted: i=1; AJvYcCW129Vi/rQjqhmzteEs0kNvsq895jE36nJ6IMVJbDqDaiRbeyr8njoMx/P2oL8T4v1hcSUwm4SZgk8eQrw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0uyCXne/ssBlNVahuopGEzoAYtBn0OgynK9+cBPexz3opkmOk HuupmniRKowJIGwCI6CZSMm7Um+xkuzHZRFMufyFJnlkzo54xms03a7KK5lvy8g+yB0= X-Gm-Gg: AY/fxX5gYDGm9qWl3N6rW91nABaN9NqEE9VR9O+m2ZjGzbRi8saOVO+OMoYf5wlU9vL 6T8qEUHXYUJAsUFlQXrPPqK6sGQcldhocYfw8VRgrorQfuybZAkVtdVbJcpDL5X2ODSDC+RhyQ+ bcFreNq9MK/HUkdfLY/C+uT6Q5nme21z1xRGLrkx/0r9tgbsFI+nwNyuv32TYHG0WLNp06lgD7Y H4abX+4cGlgjlqS2MeW45OqYbBNazxPV1v9K+UUcBNbGR4m/gnpVrtZQIf2C2bUyvTDpNw8rJHJ NvRk4pqrU4mo9qhEOwf+IxB+UlurO2EG3nGP/ojb6tID/zHhXmWH27HcWutnai4+NWfVQTyA4R7 1JDpTIdQfz9XXvgumCS50c280gmR/lNPmhN2ZDrc+cbukdi3iqEibszDt1uyv4hf9y/Cue8+13G xzl4bQYxNfj6BiB4+sA3AdSTDlc59mdGdkO4LE99e8/nMUimG8o7ubPcNGx6ZRRvKcHNK8vajJh c2rzRGt X-Google-Smtp-Source: AGHT+IGdjIBQjfoPLIzlJZUXRz25M9TeKiAKaKT62Kb77A1OxDeEodfvFIQzywYpMhAdgvBvyugk9w== X-Received: by 2002:a05:622a:1314:b0:4f1:b742:9cd2 with SMTP id d75a77b69052e-4f4abd944femr65192851cf.57.1766177980102; Fri, 19 Dec 2025 12:59:40 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-96-255-20-138.washdc.ftas.verizon.net. [96.255.20.138]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4f4ac531df9sm23918341cf.5.2025.12.19.12.59.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 12:59:39 -0800 (PST) Date: Fri, 19 Dec 2025 15:59:02 -0500 From: Gregory Price To: Zi Yan Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, akpm@linux-foundation.org, vbabka@suse.cz, surenb@google.com, mhocko@suse.com, jackmanb@google.com, hannes@cmpxchg.org, richard.weiyang@gmail.com, osalvador@suse.de, rientjes@google.com, david@redhat.com, joshua.hahnjy@gmail.com, fvdl@google.com Subject: Re: [PATCH v6] page_alloc: allow migration of smaller hugepages during contig_alloc Message-ID: References: <20251218233804.1395835-1-gourry@gourry.net> <1E3BF4A4-C8F5-4FB9-A658-9D40804CDAD6@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1E3BF4A4-C8F5-4FB9-A658-9D40804CDAD6@nvidia.com> On Fri, Dec 19, 2025 at 03:48:45PM -0500, Zi Yan wrote: > On 18 Dec 2025, at 18:38, Gregory Price wrote: > > > + if (PageHuge(page)) { > > + unsigned int order; > > + > > + if (!IS_ENABLED(CONFIG_ARCH_ENABLE_HUGEPAGE_MIGRATION)) > > + return false; > > + > > + if (skip_hugetlb) { > > + *skipped_hugetlb = true; > > I do not know whether we should check if skipped_hugetlb is NULL or not, > since pfn_range_valid_contig() is only called by alloc_contig_pages_noprof(). > I have no strong opinion on an additional skipped_hugetlb check. > I'm fine either way if folks have a preference. Compiler might even optimize it anyway after things get inlined. > Otherwise, LGTM. > > Reviewed-by: Zi Yan > Thanks again! ~Gregory