From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f176.google.com (mail-dy1-f176.google.com [74.125.82.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F3CC156236 for ; Sat, 20 Dec 2025 04:47:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766206073; cv=none; b=Hz2JJQ8GHrQh/Y3aHVpqCQlywgaD+eCYUr6qdcQhQ3/1KDfYTlnl2TSvrBjhJ4ybdsfA9cHEbnAyqYf/aFZ5TpjRGKtM8lmAVjraNItM1PW8B1posJkJfX4HAJGjYvTuAJ+8yx3yLfFvWR+72R9+8MP4rmhIRkmF60ACHi+BTrk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766206073; c=relaxed/simple; bh=zYIclOZgCl0ZOfhFHStfmpDiNwAuEu81x0JVjxabh88=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HkgXM3U2IJHJNFewmn3gpI6oqceownsg/nREO0sNJFtHclGPW17pg5l3NJ5DFViQuJ9fM5aoa6KHnahqYyQY4akHt6+opQqjuWyAAVuwGVk84VEh+jKTlPHn2hPYXCDw6UGfIgkCzE/EfLolu2H1l+1Y4ZkMOplDqCoMI1w/fk0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VaXUAkWm; arc=none smtp.client-ip=74.125.82.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VaXUAkWm" Received: by mail-dy1-f176.google.com with SMTP id 5a478bee46e88-2ae24015dc0so3228901eec.1 for ; Fri, 19 Dec 2025 20:47:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766206071; x=1766810871; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bn2q8IIyeumrRPVac1dicPR7zPs8ygyeBmiVwFiJBoM=; b=VaXUAkWm6y85ib24JwNGhdiCthh2lZciDmzs/6dFaQ0ccGrFQV5SjmM49plfVHTFPO 4tTHcbdDJO6u84Tf8F4lMexiNOTqLA3rp9xmEhz+qwtcyP8k8hiw9XkO7pZddpWRFRyB HSCQzwP0QbLqgth2lWxM6tJsN3A4IIGeqsA0fvBeapwxcINkncqlLj4lkxJXaiIrY2Fe WgqX5qe5WdAJVt/ghS7zJ7eGiy+NIMB6UH41jHLiInovgiUNuQiugCvXtU+vLlnm/ike eWxM6MBCxY4EULR8AQbGiXiJROntVUqAsoBYazaQsowfUqNHQ/FwdeNM2elFlzQ0xcDC Rk7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766206071; x=1766810871; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bn2q8IIyeumrRPVac1dicPR7zPs8ygyeBmiVwFiJBoM=; b=tiwhuv8NJnUMjISqfpJadFdidum+RRwwLRmfzH+tbQARJv3wM3PNPMLg9//CjxL1fo QiXch447hXAQKVo90FnPQF2RlNnN2eOJzNQv9tNb/6Pl6BPKhqVSp9l5kEyFgbOoKwo4 uRQKdtmwyLZlQqb/3mqUlRS7dJ+ecuqO82LnQClC3Xcylol+YCMf7bpbLojpMvVqC/wB f5P42Zorl0NDMJDJyBLICrkXz2bEyuqBamI0E6KPRJ3LatkPzqDKb+yoAyuFRZu0Q/Il F8TO3JQQDg0o3beh6uGA28/e+T7ZIzy2OH+I6pnUw0cOqN0hpLl6X7hvJuNta1TVFda9 oy5w== X-Forwarded-Encrypted: i=1; AJvYcCXnuYXZS9t7ORgfEQMgvrq85nW20rk5ilGhVhFPmrg8FoQPQw/txLKYRz6QZJY9THJppXZZdXzCwcpW3vA=@vger.kernel.org X-Gm-Message-State: AOJu0YzJq1N0DmLf7b78GXNi/ieTDv74kaSo1vFm1gmVCFjw/GcYF0cN EMU+oRuAsEFJxlIWPhTWyRmfdaon10CEeBMj17K3HVLPR0iTsxxHHEyC X-Gm-Gg: AY/fxX7RnzN2C1fT0la7eECG12ey671jJIs6nn6BrF26/Iak9yJoZCf+YJekLvAWoNH 2IfaJmkiGdw2UgcZ9tsTY+L9HtS3sO63JFQKl70WvY2o3jWl+jNjD52sRfQNz9oB8uxZyEQ/9tL HZXlCQnCl8SqUs33frw4jzxHRle3em6dFVsOKTsSmmd+6H51v/36cVEkgIOT7C7NfJx7mZKFMzP dNB02Dyq78fFH+E0UmJde6Jt28duj/CP9N/8GqQH5iJ/j9H1lGzBALY2OSTBTgO+gTiIS4ZM9eK v8T5p3QH8Whr02TVdmHYNGKr26u4sMKTt5MoL04NyMhgmxonOommb4S3QaM6zDiuBwcQ3DF7No6 o9sP7KKMMuxVQeOoucTiU63wTPwmv4l5r70snZ/rhl37SynsWdwU+bHmJlEUeSkUpMjrPY6HK9W 1sBS5M/w4wycKPDI+ZaJM= X-Google-Smtp-Source: AGHT+IF+6E+AHWTkWnukA4AV2mf/MQyKZpOlD5h2Lh5FY8EVVYHcw2vf1TZKzquPq8oZQDv7ALq/ow== X-Received: by 2002:a05:7301:5793:b0:2a4:3593:ccbb with SMTP id 5a478bee46e88-2b05e591842mr6743671eec.2.1766206071103; Fri, 19 Dec 2025 20:47:51 -0800 (PST) Received: from localhost ([2804:30c:165b:7000:d59:b973:da75:f845]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b05ff8634csm11961233eec.3.2025.12.19.20.47.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 20:47:50 -0800 (PST) Date: Sat, 20 Dec 2025 01:49:30 -0300 From: Marcelo Schmitt To: Petre Rodan Cc: Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Andreas Klinger , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Cameron Subject: Re: [PATCH 07/14] iio: pressure: mprls0025pa: make ops->write function consistent Message-ID: References: <20251218-mprls_cleanup-v1-0-b36a170f1a5c@subdimension.ro> <20251218-mprls_cleanup-v1-7-b36a170f1a5c@subdimension.ro> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251218-mprls_cleanup-v1-7-b36a170f1a5c@subdimension.ro> On 12/18, Petre Rodan wrote: > Make the i2c bus write operation more consistent with the rest of the > driver. That's not the most appealing reason for updating driver code. Is the update meaningful for a different purpose? Consider squashing that with another patch that makes better use of the updated function. > Also move defines only used by core out of the common header file. Do the define thing in a separate patch. Commits/patches should be semantically concise (in other words, do one thing on each one). Usually, the word 'also' in a commit description is a strong indicator that the second thing being done should be on a patch of it's own. > > Signed-off-by: Petre Rodan > --- > drivers/iio/pressure/mprls0025pa.c | 5 +++++ > drivers/iio/pressure/mprls0025pa.h | 4 ---- > drivers/iio/pressure/mprls0025pa_i2c.c | 9 ++++++--- > 3 files changed, 11 insertions(+), 7 deletions(-)