From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0913F2FBDFD for ; Tue, 23 Dec 2025 06:57:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766473051; cv=none; b=mb9i0uAg7juLp9mub5FncsUReaeuYfzJ2zQvCPGFIiGVvgRXDy7weEcByQ7mRiD00uUnev3MtWTbdOuTGsFgDG0nB6KRDxlKEMY065CHgvzx1G8MhRNRzl4RYMR8Pm7rRdwKP49Sc2ARbzUG48Eymcf0bQFWVlzACRXjZVZG04M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766473051; c=relaxed/simple; bh=KThyX4nPO3vwi0+H838Sf01Df1D1wwlwyQZCv66F//M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bCzwX6SZ+Eht7/DYKYfIHR/YPAR/9GPAXcWYJJ5oHtNs/jZWnqsuxl1InggszSsjlatTj49Dk9vOLW7062KeZR/Lr60W2KHxuqbxLGIfnBu6hzHbHvgSLkax5LdKsaRQJskTrpZmduLZBJBrkD6/hbEcPwVyS8SxhRoQRO2CR1A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ozAyN51G; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GnBvhl0n; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ozAyN51G"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GnBvhl0n" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BN3emIT1357457 for ; Tue, 23 Dec 2025 06:57:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=H/WmUMHRKkdLejIUbo40s3wA GGdStqkFQIeDkcgbqKc=; b=ozAyN51G6ApnVB/sNRtoPgGGHkR+U5BZr7rGKCQJ yn/2gbGPvVEeeb99wAaEc33wwUEH67dCwEicY5AGRuIZTsMjtcz93fP8pPMNmRAO Y9M1rHtjqqcmvnXVxXiWc3+9OdIJ5qZm0SzHSVbkQw3y0BJbNJFIqcAe/0B2q0Fy rdbI4QIdCVSl9zxfvxhQRdt7a4oqgfWxgc7UQdC4ppDa6mO0ayVdYSlCEKRzhie0 vHw4ZXkXIgqTwb/H8qUsH5lyYota4FcK52/WYikFetvNhl/sYWpJ8lw3VhXhjqj3 rYPq0CR0i49TMuWjZH+gYzUg/GKo1OCbXpSDkfb/YY1Uhg== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b78xc252e-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Dec 2025 06:57:28 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-7ba9c366057so9725019b3a.1 for ; Mon, 22 Dec 2025 22:57:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766473048; x=1767077848; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=H/WmUMHRKkdLejIUbo40s3wAGGdStqkFQIeDkcgbqKc=; b=GnBvhl0n48ViT0mhi6CcZnQGgSXGh/aYYQMsrlo3DlAOKmnTvzlBhT2yuVECx/WVox fQ3uUx2OfmAwQ2lDLSQab9/1j4slF8mdnIpNC7kvuizRTvqpmXMSF/RZ6lyEW3enGJUR cNMABDvspsh8ADsil2WgXBcbpnMciQax1AYu1A1vAkR4lFq4jQMWd8kdDZodv5/Vwl7X GJTmE7qeNUgHvcee+OQCOrERjxI4wF+vv644wDUBhQDX7DTzvvpBOM5kpuvSClrDaN6T 3PeyRFPba1gC+fiWeZCyQRb26u8+0tU4bauexV+/S5PB4Zx9yMLWuYulCJiQK4OqAMeq eW/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766473048; x=1767077848; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H/WmUMHRKkdLejIUbo40s3wAGGdStqkFQIeDkcgbqKc=; b=CJwGyD9iViNGqcilvs9wzbw0rfgQk2MVVRPpraDV4xVYjh7u036IfuRWzJGGbHvaD3 BtNUbgYAVCZRoDHUZi8x/VzFtX3hgwuinNDXm4t4NUNIKB4mqVofhkn1whui81B6N+/o Z12+NQHlnuvm5BzgxNhkMl9r9vjx+hQ2yYWYEwj/WQpWJWvqZ7x7zdJ2UhYd6e1lRLXl qE/6Jvxw6PoDLw2fIl+7F9J4Z5G8RVGpB9l9ykIormY8t8gaodFZI9ms78/RTzStjUvi qMYPcEvD8r36ljWCaeWHAwQuuA8GfBRyT3/f6J5/9OyKHVLmsI62DyYzkr46lmIqudsv lsTQ== X-Forwarded-Encrypted: i=1; AJvYcCWYIuaO1rwvQkXPJeBQyw+60VriXo5HYxd/uo72cd0EfJNIYfaq4qb3gjY8u4YJlzPZ1lqNweM1A1JCgwk=@vger.kernel.org X-Gm-Message-State: AOJu0YzkNIiQjzakBNabPM+o2MF3bAjqsIlojMIkxccxsgRqqmXfII06 f0l1Ddp6yQTmwwKRLM+wviYnQIr9wRcjWG8Pqa9wGoNcDzEoLMI2V+Cocm8GJ+ri4DsZsEdCGDn /qDXwkXMThs1sNmfrIcZvcHaVhRjQt2PWWI+wyD709mQ6HSDKUSwtJzKR/pQI6xgpRQ4= X-Gm-Gg: AY/fxX6GnbIwd4WCbsqm7Gu+DDOTm7UsCkN/hbLEusnWH7sN4DnR3549k3CrRjU+m1i F+ej10lEjmIqhGN1njf0pkO0FitYGntM9Ch4tXmcrJVEQ38GIJPQQbye227qBuDFa1PdIt7rq3A d1E+qFeb4mHAewH8hv7M3Akjo9XRQQ+nEUN6LNknUYV0+dx6arcyo+24NUAzOAIlMxwcd2uNkec Qmc1BwtYdsljgrG5McS/BOw9CjHorZpHVoM/PKu93EVxz8Mrw9AAwcvtOr7SlvLPs8bJbq6HBsb +M9I498Nt8T4p8R4jMGWDBx5cP37Hf7PLW2wV1zWM92IX1prpa7tsX2rPXCp6SX96iUGjZbJesp DQbCynzxmM/k0I3VmlHOGeyFCsqvj8fkxe0m7iVsZp6oqQLg= X-Received: by 2002:a05:6a00:ab0d:b0:7e8:450c:6195 with SMTP id d2e1a72fcca58-7ff66479a6bmr11612245b3a.44.1766473047976; Mon, 22 Dec 2025 22:57:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IHn/x+Z9F53fOihdDv/H36Uh2d/ccZWFW9KwHQ0K68aisaKryWeicwNiu26pfoymzYspMkVSg== X-Received: by 2002:a05:6a00:ab0d:b0:7e8:450c:6195 with SMTP id d2e1a72fcca58-7ff66479a6bmr11612230b3a.44.1766473047557; Mon, 22 Dec 2025 22:57:27 -0800 (PST) Received: from hu-arakshit-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7af2b537sm12487623b3a.20.2025.12.22.22.57.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Dec 2025 22:57:27 -0800 (PST) Date: Tue, 23 Dec 2025 12:27:22 +0530 From: Abhinaba Rakshit To: Dmitry Baryshkov Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: qcom: monaco: add QCrypto node Message-ID: References: <20251222-enable-qualcomm-crypto-engine-for-monaco-v1-1-06741d6ea66a@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-GUID: 3SptEUK6OjVBhcUmGxKzzNu0Vq7zJrpx X-Proofpoint-ORIG-GUID: 3SptEUK6OjVBhcUmGxKzzNu0Vq7zJrpx X-Authority-Analysis: v=2.4 cv=cuKWUl4i c=1 sm=1 tr=0 ts=694a3d58 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=kj9zAlcOel0A:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=N-RZRtAeA9jCEb56goQA:9 a=CjuIK1q_8ugA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjIzMDA1NyBTYWx0ZWRfXx+9pjA1uZfdV uumw8KY+zYg2haG10TJeQJCRe/7qO2ggXVew3wlSyrLXgQCDcoitgBjVoqD3rWlB3aYoA3gRsuc nD8xCSsGYxJYUVy7PYfbpKodSj9sVtdkPbCdYvjpxwTUqP1LVHtlhupiTFflo5tYiRGXE33nxUP YLNIZhLP3P50W7EZKAFv8ZE3PgKjijc2xE4xBDApDxUm1J9WeCXvfIzhglW91sgsqG3/fjsQ7Ga FEow7ldYi/TkLa23XWUHhERm/osu9KM9qo+S7k3gnKywcqp8y9RIm3BIuY9wPAtwWH/Mc2Pi8H5 kC147ELcHz4g1YwzKBBhmrtz0crqybCtOzMS+S9Nby+JH0yNIwUklNI5iwxTBVM9qyT35Bq7OWx rd0nLQhcLwJFZYRTGXWh6IPSqx9Cb5rnBvh+lkwyrC5CZQfepkjyXFsYuqNGFeAhzd++5egXXAL N2dAwMy46JO8X00R+qg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-23_02,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 phishscore=0 clxscore=1015 malwarescore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512230057 On Mon, Dec 22, 2025 at 11:29:06AM +0200, Dmitry Baryshkov wrote: > On Mon, Dec 22, 2025 at 01:00:19PM +0530, Abhinaba Rakshit wrote: > > Add Qualcomm Crypto Engine device node for Monaco platform. > > Bindings and Crypto DMA nodes for the same platform is already > > present in the tree. > > > > QCE and Crypto DMA nodes patch was applied as part of the > > commit a86d84409947 ("arm64: dts: qcom: qcs8300: add QCrypto nodes"), > > however was reverted due to compatible string being miss-matched > > against schema. > > > > Resubmitting the enablement of QCE device node for monaco platform > > with compatible-string being aligned with qcom-qce schema. > > This part will not make any sense in the commit message, once the > patch gets applied. > > Please put it under the three dashes at the end of the commit message, > after the SoB (or into the b4's cover letter, it will also be properly > included here). Or, better, rephrase it in a way that makes sense for > the applied patch. Sure, will move this description to b4's cover-letter and update in patchset v2. > > > > > Signed-off-by: Abhinaba Rakshit > > --- > > arch/arm64/boot/dts/qcom/monaco.dtsi | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > With the commit message fixed: > > > Reviewed-by: Dmitry Baryshkov > Thank you Abhinaba Rakshit