From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D9532F5479 for ; Tue, 23 Dec 2025 10:26:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766485604; cv=none; b=Takqu7JzWqJr+H58SuH6EPgzYmmUq/WhWcTGe971lc2NqtV5PhVxknzsauYAOOVenSuzMGHKU+OoRAGX7hcex9d16GhBj282XwYc5ZHuGPAja96aUpHSa99XuubGa2HTgQpmvM0bmXcl+3PZLpQAvp+J5Q6InSy3WC+Hl+VXyUs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766485604; c=relaxed/simple; bh=sNEqRtQD4cC/+OMMSzcvqkxq3t+X4HG/LceG/m0g/kA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XvaKaLPIyjpOL4yiXeOjwDfN2xWDW1h00TOMSZEBNoJaSfjWLnRPEkdDovlPLkFlIAk0Sb07CJKA94W00pOmJWWN2PHhC2CQ/HGJ1KD+PKotNfEkU7L+/6KMw73qLy4IvAEM3v7Upl9IBLG/gwvF816NNeZonMSSHRzLdasOBBE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LC094IuK; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=OT4aaQh+; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LC094IuK"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="OT4aaQh+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766485601; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6Xk52MTUM6mXrnsoh/1vCK6e+/qWXck10bUHZ/gzoQs=; b=LC094IuKYvSX/y2SvHgkJpcZu0sSGS1xwCVZABzK4wUNdEShgrR+slBAxK5xNYJeVv8m4p sO4WGxIBq4Gmof78Hd62xKB0OFGAGnOWOmgEIrDBNW5b+lTqTaeRInCqfzB5ezInFe5Y4D bfG0+XilPdB8HQaNK8DaTmCj+N9opss= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-259-Z8lan9BKPFOOyDCNbMLg-g-1; Tue, 23 Dec 2025 05:26:39 -0500 X-MC-Unique: Z8lan9BKPFOOyDCNbMLg-g-1 X-Mimecast-MFC-AGG-ID: Z8lan9BKPFOOyDCNbMLg-g_1766485598 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-43100a07eb1so2518086f8f.3 for ; Tue, 23 Dec 2025 02:26:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1766485598; x=1767090398; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6Xk52MTUM6mXrnsoh/1vCK6e+/qWXck10bUHZ/gzoQs=; b=OT4aaQh+F/b5Macq8i7wXdZv07/6oO7yjLbzdjpTHYt2Dcf6BhDk65MmFlMmRtgs6v 2sEuwR4lAqT63ypi7TGpD0paJrjXCzrbWZnnTBLJS21IvxmTg4Q1X3LBq+DNQMH3pVI/ YfXCZBHduVg2yB62QKnbTeZya1+apagtnjGCd/tkUgTi+3HClESGDwQBAIyCEhhZFFEA RU+kOCAquItBL6zzZ9wmyYz9wrv5CCYGajZXZN5pGxJmBTumfCYCXnOLi8TxYMZiP9et 4jmf7qyFhz4HdGQt5i1nnLXEc8PrXRR5aA8bjcB8SHCXDd43ASOIJ75L3Z6dG7PXLEJU C4yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766485598; x=1767090398; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6Xk52MTUM6mXrnsoh/1vCK6e+/qWXck10bUHZ/gzoQs=; b=PtQeyLX8rHlHmCYWIoJuft6gWlO+am/jet6umn1s5qmLY300BujATwdhZcAte/6Bcj 02jwl2PF96Gui/bNkc8MFJxufCRyISYcw7gHNiuej7x7298oR8epbx/nnah74kQTBsx4 ldv42h3nA6BI/Yu8e+JdA3TJczfpWWWS0wxoF3zW+6pjYhK4XoHDsRUzVcSJJaSSfRQt RGP9zkRfRrWr54ZkS7SFV/3A2uQWdrCbwv00ib1ub3TvltBEp0aJJAZwFbxRPNfczr7v kOzQVfgHSw130TPTObgcrLH0Lv3XI8kUt26gRiJu5h3PGxuxxL29V6cGWOEIRuneccT0 BYfA== X-Forwarded-Encrypted: i=1; AJvYcCUzU7tPanhGd/no0SjALKb/08RI045HrNf4GbDxPRgQyLewKQsxFoG8Vq5hgElV3gXnvAnG39fVUaXpzf4=@vger.kernel.org X-Gm-Message-State: AOJu0YxcFg9gU0L46Wt2b2mcnIfq33HuMSCjTTG1TOXim3hW9Yo7b7Gx 8R9s2P6Y6eGGOdp9DlqlCyD5embFLY+vKi677aFEDOQZ9u+dgTcvITjK2noDKuSON5GMZQXmF2O HT7xXAljbytP1iALqJ1pjCClfd7/E5/fxgrD9hqsbVYk6Tc4gU8Qg8BYRm8xVRtTFIA== X-Gm-Gg: AY/fxX7N1o9jB/U+KEbCTAIuClWBcKwb0lZSE8mX1+FKyVoq1mKNYCMZRYFx958yzhs /Kwo1YLC4DWRIQQsoH//zv36n/GJMfUSMIr21RXtk1XLV6MJvZhNP/0NDojoIXLJJUXY81C4+I0 XAM31Oe/NILokYdqMX6Eu/2MeYa9hdeDSETEke2bH6W0cR5nrC8aq1zugIxZdnQHA+JpipJnD1M IDfcMjcNBhMbqi1PypoL6U7y67AC19pDbOc+UL+nuxfV6cKMFZ8oEW3xoj7OPph9lW9vkuVDNBp UpvZD05cvxh1myBCqF4BpwaBiie/5wjI/0f6L8H3PkpLea0BhApw3t5LbbZCo9I937CEWdkla1W 4ILeeZy0Ibw9+qldcydBO0c8nFOJ4f9kRJmKUwkKMrPAXxfkxVUkh X-Received: by 2002:a05:600c:1c21:b0:47b:e2a9:2bd9 with SMTP id 5b1f17b1804b1-47d19583142mr164372415e9.31.1766485598484; Tue, 23 Dec 2025 02:26:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IFbUtwawXu/vlfSTAPP1ZyM81dCauGdjKgGdznuMdm2wRU0UBQ0kTjpv1BCy/z2B8qhN87GiA== X-Received: by 2002:a05:600c:1c21:b0:47b:e2a9:2bd9 with SMTP id 5b1f17b1804b1-47d19583142mr164372085e9.31.1766485598067; Tue, 23 Dec 2025 02:26:38 -0800 (PST) Received: from sgarzare-redhat (18.red-88-19-32.staticip.rima-tde.net. [88.19.32.18]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d19346d33sm240268595e9.3.2025.12.23.02.26.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Dec 2025 02:26:37 -0800 (PST) Date: Tue, 23 Dec 2025 11:26:31 +0100 From: Stefano Garzarella To: Michal Luczaj Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Arseniy Krasnov , virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net 1/2] vsock: Make accept()ed sockets use custom setsockopt() Message-ID: References: <20251223-vsock-child-sock-custom-sockopt-v1-0-4654a75d0f58@rbox.co> <20251223-vsock-child-sock-custom-sockopt-v1-1-4654a75d0f58@rbox.co> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20251223-vsock-child-sock-custom-sockopt-v1-1-4654a75d0f58@rbox.co> On Tue, Dec 23, 2025 at 10:15:28AM +0100, Michal Luczaj wrote: >SO_ZEROCOPY handling in vsock_connectible_setsockopt() does not get called >on accept()ed sockets due to a missing flag. Flip it. > >Fixes: e0718bd82e27 ("vsock: enable setting SO_ZEROCOPY") >Signed-off-by: Michal Luczaj >--- > net/vmw_vsock/af_vsock.c | 1 + > 1 file changed, 1 insertion(+) Thanks for the fix! > >diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c >index adcba1b7bf74..c093db8fec2d 100644 >--- a/net/vmw_vsock/af_vsock.c >+++ b/net/vmw_vsock/af_vsock.c >@@ -1787,6 +1787,7 @@ static int vsock_accept(struct socket *sock, struct socket *newsock, > } else { > newsock->state = SS_CONNECTED; > sock_graft(connected, newsock); >+ set_bit(SOCK_CUSTOM_SOCKOPT, &newsock->flags); I was a bit confused about next lines calling set_bit on `connected->sk_socket->flags`, but after `sock_graft(connected, newsock)` they are equivalent. So, maybe I would move the new line before the sock_graft() call or use `connected->sk_socket->flags` if you want to keep it after it. WDYT? BTW the fix LGTM. Thanks, Stefano > if (vsock_msgzerocopy_allow(vconnected->transport)) > set_bit(SOCK_SUPPORT_ZC, > &connected->sk_socket->flags); > >-- >2.52.0 >