From: Johan Hovold <johan@kernel.org>
To: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Cc: Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Bryan O'Donoghue <bod@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: iris: use devm_mutex_init()
Date: Tue, 23 Dec 2025 15:10:45 +0100 [thread overview]
Message-ID: <aUqi5frf5GzWt8cO@hovoldconsulting.com> (raw)
In-Reply-To: <20251223102528.14355-1-bartosz.golaszewski@oss.qualcomm.com>
On Tue, Dec 23, 2025 at 11:25:28AM +0100, Bartosz Golaszewski wrote:
> Drop the call to mutex_destroy() in .remove() by using the managed API
> in .probe().
You commit message should explain *why* you think this should be done.
mutex_destroy() doesn't free anything and is just used for a pretty
useless debugging feature. And devres is not free and increases runtime
memory consumption.
And you're also adding more lines than you are removing.
Johan
prev parent reply other threads:[~2025-12-23 14:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-23 10:25 Bartosz Golaszewski
2025-12-23 14:10 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUqi5frf5GzWt8cO@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=abhinav.kumar@linux.dev \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=bod@kernel.org \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®