From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45105312826 for ; Tue, 6 Jan 2026 14:33:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767710028; cv=none; b=dy7iR6v9kJqeYGUDKqVqeihS3hNm03pHiCRrFOfvOj+YwDPAPay5k4klcB2DLxFdSrebmul97Cf1yyrmOabWkia/wJDQDmwVJ0ju39/Z14Um4Y/Pe31BQgO3oEkbZNap0quqVVUnPN+Wh95ccwqwVlpNGq0NKCe60erYzBdtB6E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767710028; c=relaxed/simple; bh=56snyi9ptnCLoa/W6ZDI+a9sAVGPG2EwnK4UXdu9zZ4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QI7k4A4P+MHlX5bbZga5HZcpB+pQDLHFuTJU44hiMKjmfwFRoHzurEqnxp65ZvflDZ7xMK39iAv+/C6WthqDoXz6EEu5ssLAlLI5JRj3PMoek6lGQ1IMEuIVKCly5BENBg7YT41+tbbAUhJ/FpoXk9SJk41baRyhF7blOBg2t2g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vd87o-00072m-Kp; Tue, 06 Jan 2026 15:33:32 +0100 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vd87m-009MNP-16; Tue, 06 Jan 2026 15:33:30 +0100 Received: from mtr by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1vd87m-00EKlW-0l; Tue, 06 Jan 2026 15:33:30 +0100 Date: Tue, 6 Jan 2026 15:33:30 +0100 From: Michael Tretter To: Alper Ak Cc: hverkuil@kernel.org, mchehab@kernel.org, Jacob Chen , Ezequiel Garcia , Heiko Stuebner , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: rockchip: rga: Fix possible ERR_PTR dereference in rga_buf_init() Message-ID: Mail-Followup-To: Michael Tretter , Alper Ak , hverkuil@kernel.org, mchehab@kernel.org, Jacob Chen , Ezequiel Garcia , Heiko Stuebner , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20251227084038.28679-1-alperyasinak1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20251227084038.28679-1-alperyasinak1@gmail.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: m.tretter@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Sat, 27 Dec 2025 11:40:37 +0300, Alper Ak wrote: > rga_get_frame() can return ERR_PTR(-EINVAL) when buffer type is > unsupported or invalid. rga_buf_init() does not check the return value > and unconditionally dereferences the pointer when accessing f->size. > > Add proper ERR_PTR checking and return the error to prevent > dereferencing an invalid pointer. > > Fixes: 6040702ade23 ("media: rockchip: rga: allocate DMA descriptors per buffer") > Signed-off-by: Alper Ak Reviewed-by: Michael Tretter > --- > drivers/media/platform/rockchip/rga/rga-buf.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/media/platform/rockchip/rga/rga-buf.c b/drivers/media/platform/rockchip/rga/rga-buf.c > index 730bdf98565a..bb575873f2b2 100644 > --- a/drivers/media/platform/rockchip/rga/rga-buf.c > +++ b/drivers/media/platform/rockchip/rga/rga-buf.c > @@ -80,6 +80,9 @@ static int rga_buf_init(struct vb2_buffer *vb) > struct rga_frame *f = rga_get_frame(ctx, vb->vb2_queue->type); > size_t n_desc = 0; > > + if (IS_ERR(f)) > + return PTR_ERR(f); > + > n_desc = DIV_ROUND_UP(f->size, PAGE_SIZE); > > rbuf->n_desc = n_desc; > -- > 2.43.0 > >