From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 727F1288525 for ; Wed, 7 Jan 2026 08:40:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767775215; cv=none; b=cLa1tuO5zsEjcmhwsdpXdGoPizGmRC03fvspku2993LIFOLlx4s1vrpjuxwZsjl1RUe/BEw5AcpzefCwY1e8z7hM4mwlGU4jZzfgyknZzVVScENjDeVkm4LaR9XCXPEMe5wGQmEd4mCtjWkv13dqysd3nS4KBUEy5+VdZ83kS9E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767775215; c=relaxed/simple; bh=/FkOGFo8g1cSpZe2gOZ8w+2bAT1CvYH5znNXRG79Gh0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=anDO9nOElia7Q202OGVg9lj2SCeJbCM7xig3Hz1YV3roqKEJHLUeXspz/Y54bqzVSD2XAh0wpHRngLU1RotqZs/LjQTwPx1bD9yPNoqy7RZu+xsDeQ7XSGKWGVcpaicmwhGNVAZJRmuXXdaT0j4WPV1IKsY4U9nh3CgPj30EAWU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HO+J/mFf; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HO+J/mFf" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-47755de027eso10522645e9.0 for ; Wed, 07 Jan 2026 00:40:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767775212; x=1768380012; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3vOMipufGcGKuelPXUN9rVs1wLSPnDQy94IgZFqYtmo=; b=HO+J/mFfrXiPIMsQvB9dkIfTVwap3XTgLF4M5NhO4vOgXhgdniZARLgLApy2REYFAe GPZipzXLlJfWY+8h6pV4W/jKGzZ8YVr+OuLep166ozrRYtk+HV7Lqb3AHBQz94jZlDhr 6ZVZaabcs1i0rY/HNzkJJXYKqJtjXz8hXLGXCh8NXXI2sko87CJ99xVDv0yPGNf0afDe T6z0GfYPeHS2mJG55pCxq0yus7cSJfz4MGCTtUYr3OwYcBvXW5Ybl9CjXVqzbI3i7ntx XscV9ZScD6w6aHkwCZNtBq9qJpVqUvaN1k9E8dcfxijzPVEDvJ9QaMTZplk5MrYjSf4x UkYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767775212; x=1768380012; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3vOMipufGcGKuelPXUN9rVs1wLSPnDQy94IgZFqYtmo=; b=It94krxmXW+RpL23Zh/LNgLwlJ6pj85rAadEvwyZrVs5feWktHSqXkCGHANyywk3hg vMEUQPfuxIIIEcoWRvgEbhkFDTxgQbPL3iOEAHA8F5lgVE2+teCK9i81QWR44rkX3Fh3 EW+ttaArpToGIFJ2YJaqqYLa0UGbuuVVNx9ypbvOnBVSXmSmKsd3LZjlUK/BX8idqDEF zSoXWZXPcmw29glgNrONQv0RqiHasiybOp1hSifxxvo6RXpeiLdyKBjkGpuLPMGY1N4P JMAWVfPAzX32ZW4t0TScr19UcCCJ9WG/hQMtQANDloOa+i4KllSOQmQvMQtRPTgtlLwZ yTOA== X-Forwarded-Encrypted: i=1; AJvYcCVv1uzd8cuhCCgxvZqjD8KCNleOP8O514Ol588a4pd5gMCpGhtFyxnbcd38lNrFMFUJZ5dnbZGMfKjInls=@vger.kernel.org X-Gm-Message-State: AOJu0YxTdfxfv7iUrksTDvHezva2iTom3s9/fnOpUQSixeTPysAGE8vy OoNQweCqL27XlrobaM90/ZIu3AQupr8Z9P8+bAaZVUMit4iOsPfLvG5I6E6ieZ/y7mk= X-Gm-Gg: AY/fxX6osO4WG2sIsbPa9dd1SC5dfYSptebGUgbMfLqYpB/puKaGmDmuZhfAzpA8Nps h0+8lkaSwkiTnvoIRH+qyNcDvR08xlziK9/Myy1BIBuvWR243uSCvQxFa9F0q89q+AomTHVbWm6 Gk54MFlF+9GG8b3uooYekJXXt+uhDQDcuGGxxsPx3D/Yx+GnWynd2bpATDhJgQRJLoYAJ48Uu8k jIJPJx6Rld7N7Y/6XB+dRLjGU9c4ftkC14auSHRjV6UxYvOoVWVxIYRda/PGKBiNFeT0hmb49Bc nNuR7wxu6zBt0/F3ncgNcGGd3YhMbmBuyXvCAWDV1FnOZTAzT9uORhITvWioqAbtvrw0h1ZA5l9 axs7aQTKObbO86ujB/tvBjrJCXMbHe+IKGrG+WDzQueDO/GFZHDkVHIeUTSfDNVfh6Rrzn6hpNK 8V1UVuFFEjkzbPCZ0i X-Google-Smtp-Source: AGHT+IEr9Jee3oNgh/rPm8U67PCjrXwoDwrkibED2q6zVqo4sAFR090MQLpBiX5V1OXNPJAxbWMVxQ== X-Received: by 2002:a05:600c:19cd:b0:477:a246:8398 with SMTP id 5b1f17b1804b1-47d84b09166mr15022315e9.2.1767775211605; Wed, 07 Jan 2026 00:40:11 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d8636e588sm8712765e9.0.2026.01.07.00.40.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 00:40:11 -0800 (PST) Date: Wed, 7 Jan 2026 11:40:08 +0300 From: Dan Carpenter To: Jonas Jelonek Cc: Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Rosin , Geert Uytterhoeven , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Richard Subject: Re: [PATCH v7 2/2] gpio: add gpio-line-mux driver Message-ID: References: <20251227180134.1262138-1-jelonek.jonas@gmail.com> <20251227180134.1262138-3-jelonek.jonas@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251227180134.1262138-3-jelonek.jonas@gmail.com> On Sat, Dec 27, 2025 at 06:01:34PM +0000, Jonas Jelonek wrote: > +struct gpio_lmux { > + struct gpio_chip gc; > + struct mux_control *mux; > + struct gpio_desc *muxed_gpio; > + > + u32 num_gpio_mux_states; > + unsigned int gpio_mux_states[] __counted_by(num_gpio_mux_states); > +}; > + > +static int gpio_lmux_gpio_get(struct gpio_chip *gc, unsigned int offset) > +{ > + struct gpio_lmux *glm = gpiochip_get_data(gc); > + int ret; > + > + if (offset > gc->ngpio) This is off by one. Should be >=. regards, dan carpenter > + return -EINVAL; > + > + ret = mux_control_select_delay(glm->mux, glm->gpio_mux_states[offset], > + MUX_SELECT_DELAY_US); > + if (ret < 0) > + return ret; > + > + ret = gpiod_get_raw_value_cansleep(glm->muxed_gpio); > + mux_control_deselect(glm->mux); > + return ret; > +}