From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f50.google.com (mail-dl1-f50.google.com [74.125.82.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BF051F03D2 for ; Thu, 8 Jan 2026 01:05:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767834356; cv=none; b=pD9WJ7W0LjUBCppa7ch9Z9fBixHmVjfuBNzEZO3CRmC/AstPuK96LIDNtE9F+N0F45USMQJb13bmtlI2tuphXHLnMBuY08Y2jOdr8b8QvpPhFYoQKiuoxQgOQqtHzSoEuTRreYuEVpAtDScCwC2ritXA7WHj2H3xjXflfcanccI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767834356; c=relaxed/simple; bh=YwYFk2Qx+js9gbhXOBYT/PL0EMA9IaaTTXp8tsgIuMo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gjnjH7eFbfzGcFWELmKDuyIQSqDIeXUPNAf93N/NEGMnuYYG5UmpAGPER6TlWMjfb8bva8xdzTIp06TdrV2jH8RIYk8GT6V+gSF/pm3d3LxVIPQzvzxGooKU6Z1l16BE9TVOV4B9x4wD6LG2g4jaPjt7kUhg7v+0n/3aYPsGq0o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XRNuL+j7; arc=none smtp.client-ip=74.125.82.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XRNuL+j7" Received: by mail-dl1-f50.google.com with SMTP id a92af1059eb24-11dd2370722so4475996c88.1 for ; Wed, 07 Jan 2026 17:05:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767834355; x=1768439155; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:from:to:cc:subject:date :message-id:reply-to; bh=oG5BFbOLzzfCmy3i7IH0OAHPZrkRaMAHq+KjKb1KniM=; b=XRNuL+j7D9Gi3pP7y3SZUS6oRuhmR/7LDwzUhRmcSkKPsrtlcD3h8koYndHbzcStbu +Up0TPX3R/BzZEl4IsnU38giwzY2kWPvWpHggL03uV4589QauJS9yUzCj8BNSi9UEwIV 9/BxiDqS2iOCUXgAnNi4iR2SrhASLZ+VASc+TLRzL4/iqkAzPfWtlrl/lhpzi6KfV+Qr bMV21MhWBFqppZLH0IAqpLpkG3Ml7RBOMkhhxTqAGjK6Jmc08jvlb+rdfaf9Lb1Ntixl GvI0AmNBMPMiOucgbN9YchvUM0rSEMhEYxde/1YT2QOZxQQSTv2j9nqS+nZgpS8ipNXZ 9T0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767834355; x=1768439155; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=oG5BFbOLzzfCmy3i7IH0OAHPZrkRaMAHq+KjKb1KniM=; b=RsX7Plg4o2DBCXTJsEpK1VgI69Lz8vTncwQN75e1VosWR4ozRjDbUiK3zsoYUpU/e4 1zjj3FivowW9e6m71Aa9yFnzmS6X9xWAalbIQpp9iA2+0qTZt1a8DUyG/0zdfyah7HdW aXkoDGr/GaBML5yaEKcddhzUCzgV2ZiB+lsKg0o+LUAAPWyOHdema7VjUW6kYTIGX4Q5 zsxDQ6l+kX8qZPJhguW3TReWSChosp8p0tg0ZvOh4Z0YTRS9zhTFtb/FQ2Ohi3HsR9gW h0t4lk0FkbFDnG4/jKiHkF17NqYyfabdtSW5n/VLBneFMP73GmeGeXeXknWSt3pbYUjy 3tyQ== X-Forwarded-Encrypted: i=1; AJvYcCWnPIUDtm3IanXNxBqL7WqnkcN860YMf5kubKomALuJyEIkoRVLkugpRPQ+amUYmbj4a8afI2peaRW/OWg=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0BRItm8mXo2cdKI4LHhsnskDEyUhtldJOWg8sonBEw3YXx3bP QYLl6bZ900km6RiN91vb/VyBhPCpHHpK4wrPGBvRQpOcl0Zf1GxqQHOdoA962nR3 X-Gm-Gg: AY/fxX7dclbYWoBvvc7XWIhd81KNCxlp2DymU2ec/gqUGWuzyKXe3H6fCLmaftug13q zFELN3SMhv58jp+ccc0x4H0UYLfhyS/dzGMbLFCCgtZsQJ4Vps7XdgMt3DN4R3TrRbaTuAWA0M/ vcOE1uNA2T4WRlMt/H+DLWkOp7FTGTWY6OWvEkuMMtsNqbJuiCtMk6mQfe8rhvM2EPGb6VjbLGR 9Rr6ph0xndICtK1eyY4rniq/I5ooZ+Ck2JLMUlMsbdo00wF71GxScHCpDIBS3997FHnw96/wRxJ Vg8ai3Wy3QtcGKBnFnGDGRLnJot0+ml0nB7l4DHvXsEuRSWiC57jj8Lqi0B7KncGROOf01NeBaK ctk3TDYwSfwsulx08prJej3WeHMVRpoiLPMDuHvWQIE4LNzhzEN/AC4ypSkYMOhnHwwXKKIuel/ 8pLxepofKq4cGM8eZr2vIxBDsCLum8xEhybDGKKH6zOqBPs6HYVt8jnh3agQzViDA0pbhSyKyGT vTDifGzEfXwWxI= X-Google-Smtp-Source: AGHT+IGIT0eYr8Gbwd/QQudTYQgriqF4Hv1aOqCZKTB6uNL4p+UUE718Oq8T33nlodImpPSbreHPXg== X-Received: by 2002:a05:620a:2a09:b0:8b2:e5cd:fa42 with SMTP id af79cd13be357-8c3891b060cmr560895085a.0.1767827439197; Wed, 07 Jan 2026 15:10:39 -0800 (PST) Received: from fauth-a2-smtp.messagingengine.com (fauth-a2-smtp.messagingengine.com. [103.168.172.201]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8c37f51cdcesm464558185a.26.2026.01.07.15.10.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 15:10:38 -0800 (PST) Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfauth.phl.internal (Postfix) with ESMTP id 63DD8F40068; Wed, 7 Jan 2026 18:10:38 -0500 (EST) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Wed, 07 Jan 2026 18:10:38 -0500 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddutdegfeeiucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepuehoqhhunhcu hfgvnhhguceosghoqhhunhdrfhgvnhhgsehgmhgrihhlrdgtohhmqeenucggtffrrghtth gvrhhnpeelffdvhedvheeiuefgleejjedtteeileekgeekueffffegheeuledvkeejjeeh udenucffohhmrghinhepkhgvrhhnvghlrdhorhhgpdduledqrhgtuddrqdhlihhnkhenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegsohhquhhn odhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdeiledvgeehtdeigedqudejje ekheehhedvqdgsohhquhhnrdhfvghngheppehgmhgrihhlrdgtohhmsehfihigmhgvrdhn rghmvgdpnhgspghrtghpthhtohepudehpdhmohguvgepshhmthhpohhuthdprhgtphhtth hopegrlhhitggvrhihhhhlsehgohhoghhlvgdrtghomhdprhgtphhtthhopehpvghtvghr iiesihhnfhhrrgguvggrugdrohhrghdprhgtphhtthhopeifihhllheskhgvrhhnvghlrd horhhgpdhrtghpthhtohepmhhinhhgohesrhgvughhrghtrdgtohhmpdhrtghpthhtohep lhhonhhgmhgrnhesrhgvughhrghtrdgtohhmpdhrtghpthhtohepohhjvggurgeskhgvrh hnvghlrdhorhhgpdhrtghpthhtohepghgrrhihsehgrghrhihguhhordhnvghtpdhrtghp thhtohepsghjohhrnhefpghghhesphhrohhtohhnmhgrihhlrdgtohhmpdhrtghpthhtoh eplhhoshhsihhnsehkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 7 Jan 2026 18:10:37 -0500 (EST) Date: Thu, 8 Jan 2026 07:10:35 +0800 From: Boqun Feng To: Alice Ryhl Cc: Peter Zijlstra , Will Deacon , Ingo Molnar , Waiman Long , Miguel Ojeda , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org Subject: Re: [PATCH v2] rust: sync: inline various lock related methods Message-ID: References: <20251218-inline-lock-unlock-v2-1-fbadac8bd61b@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251218-inline-lock-unlock-v2-1-fbadac8bd61b@google.com> On Thu, Dec 18, 2025 at 12:10:23PM +0000, Alice Ryhl wrote: > While debugging a different issue [1], I inspected a rust_binder.ko file > and noticed the following relocation: > > R_AARCH64_CALL26 _RNvXNtNtNtCsdfZWD8DztAw_6kernel4sync4lock8spinlockNtB2_15SpinLockBackendNtB4_7Backend6unlock > > This relocation (and a similar one for lock) occurred many times > throughout the module. That is not really useful because all this > function does is call spin_unlock(), so what we actually want here is > that a call to spin_unlock() dirctly is generated in favor of this > wrapper method. > > Thus, mark these methods inline. > > Link: https://lore.kernel.org/p/20251111-binder-fix-list-remove-v1-0-8ed14a0da63d@google.com > Signed-off-by: Alice Ryhl > --- > Changes in v2: > - Rebased on v6.19-rc1. > - Link to v1: https://lore.kernel.org/r/20251113-inline-lock-unlock-v1-1-1b6e8c323bcf@google.com Queued, thanks you! Regards, Boqun