mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Mastro <amastro@fb.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: David Matlack <dmatlack@google.com>,
	Alex Williamson <alex@shazbot.org>, Shuah Khan <shuah@kernel.org>,
	Peter Xu <peterx@redhat.com>, <linux-kernel@vger.kernel.org>,
	<kvm@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH] vfio: selftests: Add vfio_dma_mapping_mmio_test
Date: Wed, 7 Jan 2026 18:41:10 -0800	[thread overview]
Message-ID: <aV8ZRoDjKzjZaw5r@devgpu015.cco6.facebook.com> (raw)
In-Reply-To: <20260108005406.GA545276@ziepe.ca>

On Wed, Jan 07, 2026 at 08:54:06PM -0400, Jason Gunthorpe wrote:
> On Wed, Jan 07, 2026 at 11:54:09PM +0000, David Matlack wrote:
> > On 2026-01-07 02:13 PM, Alex Mastro wrote:
> > > Test MMIO-backed DMA mappings by iommu_map()-ing mmap'ed BAR regions.
> > 
> > Thanks for adding this!
> > 
> > > Also update vfio_pci_bar_map() to align BAR mmaps for efficient huge
> > > page mappings.
> > > 
> > > Only vfio_type1 variants are tested; iommufd variants can be added
> > > once kernel support lands.
> > 
> > Are there plans to support mapping BARs via virtual address in iommufd?
> > I thought the plan was only to support via dma-bufs. Maybe Jason can
> > confirm.
> 
> Only dmabuf.

Ack. I got confused. I had thought iommufd's vfio container compatibility mode
was going to support this, but realized that doesn't make sense given past
discussions about the pitfalls of achieving these mappings the legacy way.

> 
> > Assuming not, should we add negative tests here to make sure iommufd
> > does not allow mapping BARs?
> 
> Yes

Will add.

>  
> > And then we can add dma-buf tests in a future commit.
> 
> Yes
> 
> Jason

  reply	other threads:[~2026-01-08  2:41 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-07 22:13 Alex Mastro
2026-01-07 22:37 ` Alex Mastro
2026-01-07 23:54 ` David Matlack
2026-01-08  0:54   ` Jason Gunthorpe
2026-01-08  2:41     ` Alex Mastro [this message]
2026-01-08 14:10       ` Jason Gunthorpe
2026-01-08 15:45         ` Alex Williamson
2026-01-08 18:24           ` David Matlack
2026-01-08 18:33             ` Jason Gunthorpe
2026-01-08 21:29               ` David Matlack
2026-01-09  0:36                 ` Jason Gunthorpe
2026-01-09  0:43                   ` David Matlack
2026-01-09  0:54                     ` Jason Gunthorpe
2026-01-09 17:04                       ` David Matlack
2026-01-09 18:01                         ` Jason Gunthorpe
2026-01-09 21:38                           ` Alex Williamson
2026-01-13 23:47                             ` David Matlack
2026-01-08  3:36   ` Alex Mastro
2026-01-08 14:38     ` Jason Gunthorpe
2026-01-08 16:25       ` Alex Mastro
2026-01-08 23:04         ` Alex Mastro
2026-01-08 15:42     ` Alex Williamson
2026-01-08 18:20       ` David Matlack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aV8ZRoDjKzjZaw5r@devgpu015.cco6.facebook.com \
    --to=amastro@fb.com \
    --cc=alex@shazbot.org \
    --cc=dmatlack@google.com \
    --cc=jgg@ziepe.ca \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=peterx@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®