From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2D51236453 for ; Sat, 27 Dec 2025 19:49:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766864996; cv=none; b=ehqxJjlf8oYIj+C0xD8UMV8g0z0xfKzHaWw7OFCQP53ILQGLu6My4qYL3PMg46cpl6/5Les85RuEbz0UMt5BKyu/LTCXRMOjnWw2OuBdYfrpHmqbZ2TpYV4lGsPLfQix8yDSJeS0lR1mAhnr67ZnG0wzP7+4xW0CQR9FwtozW/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766864996; c=relaxed/simple; bh=tcOhN5F2jVUyljFaKmwclxjwwd9i7p+unxHW3FV3GSg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Dnhh87pNQKK7FGEGq69LDpgv31KBdUqARtrOalUplKTG3cYH9Wet/YELOqMykI8jibMbv98kcHSTzIUBaR7IJyu8EcOX9TV9ct1y6BiqB95xg4joQR1QfxCYaClqZAB3ktO2mydNKkXCOVAIjPYflPbC2DLzRqvQIA+taJOZIZ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VYPif88n; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VYPif88n" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2a0a33d0585so74625145ad.1 for ; Sat, 27 Dec 2025 11:49:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766864994; x=1767469794; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tcOhN5F2jVUyljFaKmwclxjwwd9i7p+unxHW3FV3GSg=; b=VYPif88nXNlbRiRAedXIM5a+3BYkAgEhhdhGmz69ABzLYQObv8fSjDezVYrt0Jiv73 aBwANTYMBSttitjIBXzpd9R3VbK5fvTXC9qGA6TZ8m/wTM7aqFqP2uG4Qexf0ZFKSeUy Amyk9SBnkcklxdp8b90uzoPWgLIylGknU0qtp4rYJimZLaOx5eTi/fe1H827Ib/JWqJs fpzIYToL7jgjcoZkScJN2Wa5sn5VArCw3EF7621Urad4QdlPy1PSU5boLVEwWz1Pu5bz Fag1mZDPa1pBoGcDbBR9vVc2VWhVItoDSqJTYsAIXh+rf3iW4narbe5pPb41ueW9Mglb Y6FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766864994; x=1767469794; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tcOhN5F2jVUyljFaKmwclxjwwd9i7p+unxHW3FV3GSg=; b=RSvm35fUv1jlPyeoRg79EBA/lwbjSATOd0qi86YydEyNu2jkXelvNK2Svgpw/DbF72 1CAVit/S1cnqlCEil08tZlulC1+tjz0YTTCu1erBjA/gCJvUAXxyV8ffJYlAZ7Ajb63J CcM/kMOkQSBVCEOWtxFVF7dnWj0M0EpxS2rnNt5C/o2awDQEK/rIKZ3LvgBevb/BSl0f SdVRKtlsoNwBy+DyqdLWvVEVycaUtIYyF1Iz+jm2QzXFGDqwd9korG32lv+DBC9RLM+q 6NIAos7al4TEJ3iS547zc/uAsXIh5D2Bzg0VI40HWS3lb8dk02R6UnQ/D59IthzaJkzz jydg== X-Forwarded-Encrypted: i=1; AJvYcCUKgXU4BTf7qS5TSvuh0cSyWGUbibduoQ+/tREMjfKViMDRaV40EdPoNIgZIC8/8/AYVCYRbeUlUWfqNME=@vger.kernel.org X-Gm-Message-State: AOJu0YykSXtLdFcVu+qrJJCI18kX62aEsg0i/u5IBreXegVWn9tWzorV /mWOQRg5JsKBSrkO1OaQkjijJywS4iaeW2uihySgXWY0AnlBGnrWQp4P X-Gm-Gg: AY/fxX7xwBUIJBKE+6/pUqwqzr/I603iqLE6hJedGyEoZXom1BDNUbDeY8wZuTw8YFe 5xYcAJjtfsXuSwXoeEGYAiUO1KFNmikFbBssim//Bl+8yPYDWK3lCR4am5LHJV369b5wIkNlUd5 sdH+RLeOLYIkLjjTH5sMH1X3UKeMf7QjDz2QbyVwGSJZYbo15aUGQAvaeceloW2lNUWTBuXuf9k keJTjv+KbgAeFsnWzYaC24rHCpwZaeEQoQeOj1HS110wENZJYZ56kDrIGzcEx90mnbCJswIK0jQ VqBGaKLBYK9mWPHausBbCLROA5cuo6E2hhtBtIRAkqFpGW3j1gtJxazf/4e4FECPOLrjKlXkvgV kOIutRgJPW300NCXb2GbhvpIqd5GJLhzSdX7cHnjPBN46tGjcRgNkQarbK3WwQlXkup9MOJp3va 45JTrJbc6mwy6WexbK+Q== X-Google-Smtp-Source: AGHT+IHUmJ2kT9c+ffkvaSVuIXDpr8kxbxH8p6fmp38yx57OoC0P4CfNd9P5Zk4bVWgwm9EFWoqYVg== X-Received: by 2002:a05:7022:687:b0:11b:baa5:f4d1 with SMTP id a92af1059eb24-121721aab3dmr24764391c88.6.1766864994173; Sat, 27 Dec 2025 11:49:54 -0800 (PST) Received: from localhost ([2601:647:6802:dbc0:de11:3cdc:eebf:e8cf]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1217253c058sm101037018c88.11.2025.12.27.11.49.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Dec 2025 11:49:53 -0800 (PST) Date: Sat, 27 Dec 2025 11:49:52 -0800 From: Cong Wang To: Manas Cc: stephen@networkplumber.org, jhs@mojatatu.com, jiri@resnulli.us, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net/sched: Fix divide error in tabledist Message-ID: References: <20251222061306.28902-1-ghandatmanas@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251222061306.28902-1-ghandatmanas@gmail.com> Hi Manas, On Mon, Dec 22, 2025 at 11:43:06AM +0530, Manas wrote: > Previously, a duplication check was added to ensure that a > duplicating netem cannot exist in a tree with other netems. When > check_netem_in_tree() fails after parameter updates, the qdisc > structure is left in an inconsistent state with some new values > applied but duplicate not updated. Move the tree validation check > before modifying any qdisc parameters We are reverting the check_netem_in_tree() code due to user-space breakage. I hope reverting it could also fix the bug you repported here? See: https://lore.kernel.org/netdev/20251227194135.1111972-3-xiyou.wangcong@gmail.com/ Thanks! Cong