From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1E40239E9B for ; Sun, 28 Dec 2025 17:26:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766942780; cv=none; b=IGKyI3QPE9x1ZRvmfqKuR/YnkkyvrKy16yI4G3M3dSni0ef3gYoytzJu06ZFkDF9XHSq+2H/SMQk77YfXYE0okbv3oU5xOFMm982eIMiVbnah5OsQraPNU5yI+h34Zg/CV4lWJ+EyC33RzrXFtfGv9eMGwnF1ifHWZvKIReCm+4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766942780; c=relaxed/simple; bh=5s1ONPFCb6zhe/2cygceRy0ZotmKUG/UDqcCs6qDnoY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XNBCTWZ3itxxxb9d+EBrWVWXdLS1jg7udIbPVwJfiMvug2FiwQmgXIvQ9eJrGV957bCf0Uqot7lhd6D8eZ+R5/PQqG6I4/kkNHHo808QKgWkdigPlup7fuvEAxoZlLycEba2HR32Jh5RCa7/ia1W41YUTqPSeM7dF662O+6RbB8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=hUVkOXW3; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="hUVkOXW3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1766942778; x=1798478778; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=5s1ONPFCb6zhe/2cygceRy0ZotmKUG/UDqcCs6qDnoY=; b=hUVkOXW3buVkOTuy0Eq1zfOZJP4iRj+Sw1hLojrSIltob2NnkXfAxcS/ b6WmTmg54OFxDfh1+HAHLKVuHn2CncxZTACVt3doO9PXKu9Fs66rHbAxD naZ1Uu6H8PscGxIS969IickKIh8qgXMKMJ4hCK4rWKOGJFsT9E6hc0UML 643KXuKC8LIHyhFjfQC8DAsfsxQhc8qFj2/J4OR7zZm9gU+/THATAJfpy rgiYFSYLRqKVSoto4IFd2nO1FmS8DCBcbfkbaLIMZ+rIobTD+uauTdNtP 7bWOJvEAGBhogeS3UINCIE4iil6faKsi1ffX+xtRJg+AUlRlhWbm+AMnq g==; X-CSE-ConnectionGUID: YphOYPKDSb2RfulybOqk7Q== X-CSE-MsgGUID: ZVXodT05TBCROr8C1WKi8w== X-IronPort-AV: E=McAfee;i="6800,10657,11655"; a="86160036" X-IronPort-AV: E=Sophos;i="6.21,183,1763452800"; d="scan'208";a="86160036" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Dec 2025 09:26:18 -0800 X-CSE-ConnectionGUID: n7yBwMK8QieeQjj34+ZGnQ== X-CSE-MsgGUID: oon2Wh1/Qx+dvdXOKAFFVw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,183,1763452800"; d="scan'208";a="231826757" Received: from abityuts-desk.ger.corp.intel.com (HELO localhost) ([10.245.244.236]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Dec 2025 09:26:16 -0800 Date: Sun, 28 Dec 2025 19:26:13 +0200 From: Andy Shevchenko To: Diederik de Haas Cc: Michael Wu , myungjoo.ham@samsung.com, cw00.choi@samsung.com, linux-kernel@vger.kernel.org, Dragan Simic , linux-rockchip@lists.infradead.org Subject: Re: [PATCH v3] extcon: Fixed sysfs duplicate filename issue Message-ID: References: <20251024024946.16618-1-michael@allwinnertech.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Sun, Dec 28, 2025 at 12:01:54PM +0100, Diederik de Haas wrote: > On Sat Dec 27, 2025 at 4:08 PM CET, Andy Shevchenko wrote: > > On Sun, Dec 21, 2025 at 03:01:11PM +0100, Diederik de Haas wrote: > >> On Fri Oct 24, 2025 at 4:49 AM CEST, Michael Wu wrote: > >> > With current extcon_dev_unregister() timing, ida_free is before > >> > device_unregister(), that may cause current id re-alloc to another > >> > device in extcon_dev_register() context but sysfs filename path not > >> > removal completed yet. > >> > >> I periodically get errors like this: > >> > >> [ 7.116152] rockchip-usb2phy fe8a0000.usb2phy: error -EEXIST: failed to register extcon device > >> [ 7.117005] rockchip-usb2phy fe8a0000.usb2phy: probe with driver rockchip-usb2phy failed with error -17 > >> > >> This was today on a NanoPi R5S (rk3568), but I have seen it before and > >> on multiple devices. They are all Rockchip based, but that's (quite) > >> possible because that's what I use the most (and where I pay quite a bit > >> of attention to dmesg). > >> > >> Slightly fuller dmesg output of the above error is here: > >> https://paste.sr.ht/~diederik/42c6b3405386c823cd9f837d73a9a32e810361be > >> And via 'journalctl' I hopefully got the full dmesg output: > >> https://paste.sr.ht/~diederik/7a6109115b1ad85290de482db091dad3759ec159 > >> > >> Here are 2 similar logs, this time on PineTab2 and Quartz64-A (both rk3566) > >> https://paste.sr.ht/~diederik/cfe606801d3dab0267bea7049687d24c0d6e8d71 > >> > >> Those are all the logs I have saved, but it has happened several times > >> besides that. But most times I just rebooted and didn't save the log. > >> Today I looked a bit further, found commit 7bba9e81a6fb, searched on > >> lore.k.o and found this patch. > >> > >> So I'm wondering whether this patch would also fix 'my' issue? > >> Or is this a different issue? > > > > But have you had a chance to test it? The code looks correct after this patch > > as the first we remove the struct device and all associated data (including > > sysfs nodes) and then remove the ID from the list. Without that there is a > > window to get the same id for the devices that is pending to be removed. > > I've build a kernel with it and it will be part of my kernels going > forward. But it can take many months before the issue shows up again. > So if I don't get it in a year, then I'm going to *assume* it's probably > fixed. I believe you may speed up the test case by creating two shell scripts that trying insmod / rmmod the same module in parallel. -- With Best Regards, Andy Shevchenko