From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E10D26F2BD for ; Mon, 29 Dec 2025 08:27:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766996844; cv=none; b=Rca4RAASzrT4jcyjMA79Wv5k60smJnd70JXTEOwpbz3Q8oVi1Z4qy7MDarHzuExVYTKtEAYTOB9R7f/yt6bZpCxiHm0bH0QoqGgxAE6W8TmyUsPyZNfWIJMpMaceB12gP/6xttaIbD72VnrCHB8B+2b/2BfKGrnHl0hJ/Kjc0og= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766996844; c=relaxed/simple; bh=adqv39GtoU4V5lhx4HWBBeEFXEnE7kgR8wFAFqz5Sb8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NqKzepDdDnLpVfNk7nM5a6ZCD0ZBBeE8CS1Qcb3fr2h97DmKwheBVnGRvAEgk81ATK3AA8O+GuRU56B+ezu24tfwH2TgwDMbTGwRFqd46vnHLr9WhMma1ooUfombAKVG0Dq3tFiw7EWTsU3GUqDxKw9IWPGZ3NRh4llhR85ilj8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=ZHxvzgPJ; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="ZHxvzgPJ" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-47aa03d3326so55900125e9.3 for ; Mon, 29 Dec 2025 00:27:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1766996841; x=1767601641; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fdN4i2DMWC2lGiJD/4d5sV2Ct8oIxvukmkIqv6R+Lcw=; b=ZHxvzgPJqQIzKMjAceStYYQkGmMeiD8XfOjIWI2zw8VCjAg6GTVySNo7lnYVMOhKL5 n3JxILQG9jezMTAZaO5lLU8AKFH177z7Msrt5dp39VIifm7p9kIHFfSOdDSNv4LSOPeS QVicUn6uRneF188QEaxJAxsUz7uHkXNZ4EsQTzlSt0yWSTbK3oJhgSM4Uh6hS8wyKZ15 PJcCQjS9lRSW/OMFKf7SSSzg0SamS1A8fLPQoqim5CTzYzZPcd3m9YXe40y4dnIaP1Uj t2t4OUdJIKWOcUSZwhRU6+TNKq2yebL7SXIsEaAnhmstGP5ysTq3m81sof6wmrOwZcDC 01Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766996841; x=1767601641; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fdN4i2DMWC2lGiJD/4d5sV2Ct8oIxvukmkIqv6R+Lcw=; b=MbNJGxTN5wJO/q8UG10QWsTba8WB06esGYn2Zy0HJcMkSB7gf6wgZUG//TjVscWxcK nr56G77OJv2LDP15v5d/G8aCeBvHd7qOBpX1NgKuzUFjzubUgrDedUZKU8BgbMRSaZGZ UrJN5g6/0a82SZeENC9U681bYicAGPt0lDDd2N/PdIpJ5UuhZ/LU+Ie2LTBXNIT98I+O /87TdxsABbKqiQm3jkQP+6YXC1721rjSJCovxiYY5mZte3mfhBqq1XElLzEuVca4rhfy ykhnodezaeAOo7FJ6nZAd27xyGsEcvNzrPc/128vgkR6pm7s+mWH61gLykLKAHwqCn7/ 8Pmg== X-Forwarded-Encrypted: i=1; AJvYcCXmYTbkWk6KhSzla6j/qgqcHatnThVnb/L0hi38OZbtHsHall3Nktyb2E0dDCG3thSv5XS+fE6uZs69I1E=@vger.kernel.org X-Gm-Message-State: AOJu0Yzc1xx+ivmqfkJbGu9KQH16jYPIjEAxs+nzlaPgZ1yX1a/bz1mt EHY2SO+ChIHWE3XPYlg1O6s8cjvYbDa/6DbGbm/ripPo7LbhgkuPVq64O+PKvKrFL1oCktEjBDn MqQ5X X-Gm-Gg: AY/fxX7et8t2SPfGTKqWxm1hq/OcRrLcu+AVpXkKWMzEV8eKOPMyfQYuN0ur/SHOSry 8mmja5hU/CKwnLpz5nEoRBEqO1ZjzjEYCEEuZYmn7RGessiAPJbkrthor5ur10rozXoS6oLUfTz tf9qhJEX5crO8dLOMiyO0qP2dQryHV1bD2nZa6vThakX90/rQOnpZH1WIwBNWzRcueyDTaa5DCW 4/Dz8nBZ7VR5HqHip7msNBgxRXaq6FhoRGtYWNWxlurRmrDMITt+NyrVpTKoHXgkFelO6g10HRm OjmM5/YPBok6VpbNx4v15knHrhnCihgJmx6ZMHA6ycpBHAMXkD7O04S5/vetHA+r5kKNWqEt93g 1LUKKDDM2Xz/FeQM8tGrVwZECXc2f6bEzoATBwfOyNAm88q28KsGR9+PKenjmLFdcYMQCrcyf8k KkXOpPxvKEg+HZRSJFfaLdyyEd X-Google-Smtp-Source: AGHT+IELwHA+UHDrVzL4wnDtEXCyDMiRCKsNJHLwn90wHHZmKgOk77ST04CvXoQGVeP5Zdga0fQmew== X-Received: by 2002:a05:600c:3b15:b0:479:3a88:de5d with SMTP id 5b1f17b1804b1-47d247132b8mr300308835e9.36.1766996840713; Mon, 29 Dec 2025 00:27:20 -0800 (PST) Received: from localhost (109-81-26-224.rct.o2.cz. [109.81.26.224]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eaa64cesm61431589f8f.35.2025.12.29.00.27.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Dec 2025 00:27:20 -0800 (PST) Date: Mon, 29 Dec 2025 09:27:18 +0100 From: Michal Hocko To: Dipendra Khadka Cc: Andrew Morton , David Rientjes , Shakeel Butt , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/oom_kill: Remove unnecessary integer promotion in format string Message-ID: References: <20251228154456.2386-1-kdipendra88@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251228154456.2386-1-kdipendra88@gmail.com> On Sun 28-12-25 15:44:55, Dipendra Khadka wrote: > The 'h' length modifier in '%hd' is unnecessary as short integers are > promoted to int in variadic functions. Use '%d' instead. > > Signed-off-by: Dipendra Khadka Why should we change the currently correct code in the first place? What is an added value? -- Michal Hocko SUSE Labs