From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F5D92C0F7A for ; Mon, 29 Dec 2025 11:47:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767008830; cv=none; b=c949KEU76862Lp6YwuZRfrC81FXB3uM6CN/IXSFwoB6hvSaSn2AhRzstKDANCjm3nJtqUaJiYb6/cQXTkTjEhVD0jdIOFYOGqjATpgodrkIUKmUsMHiOedNq4ZSZyuiyeLDykix31MhgjWuZughYhhJJDMbAlkFCXeNFtU7SJ98= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767008830; c=relaxed/simple; bh=HkH5N2sCSZATBK6DPKkbYweTOgvAx2hC81qJ2oZEES0=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cski2e9+jSPUdI81OEu8Lr5C+HsaxqKnbEbf3nP+97b35WRfZf+d/agXJCxestMq8KFkPlcHs2DsSwWKSyD3Z91W4VKq4FmKVtLJvhAxIlPXfEdipGehAhG/0F+BZi0chSQMcXonIzcPxYYlD/KnObv4kZrYRzuZ0EPiel7wcrY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Oj/nPovB; arc=none smtp.client-ip=209.85.208.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Oj/nPovB" Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-37ce27af365so77759551fa.0 for ; Mon, 29 Dec 2025 03:47:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767008824; x=1767613624; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=H25YjglsiDocpn+BoTyVRQ1j/CuNDDswQSIC0niKha8=; b=Oj/nPovBrQ2+yf684fPsdDIu/NynNPycOpOn4NLhFG9onoJvNwiNguDtJScPBUiItc BrR6ZkBa3dPY8y1ONPrHqasyIEA74Vd6QT50tj4YXUDvyn23f9wnSOvVp9oheB3fEW89 XhA13pt6TORsTWLf1TsSZ9VsSKvXUKKP30i6WuOtuiLMjvWgxvcz0h1kC2Sm4foGlZ8D pY+mpfTC6Z3drXh5qo/QrP169vUV8wjysRPYBWLn/tWjSyEPoWXSpMDkcxPOme/Pph4s 5gda6RetD4knfBC63Y4PljqZ8H9eSJRKq4etWJIHBU3xYbwmUkadKd0q/FO1E8mzeDEC /V7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767008824; x=1767613624; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H25YjglsiDocpn+BoTyVRQ1j/CuNDDswQSIC0niKha8=; b=ISVzJj/NoaSefUoTdtgISPqHn/Xmlp79sxHnUc6AT6meAflaXgVE8z81auS/eOmgj5 lY6fh5S+CIwfk6Rc5HW44oRFku7UbEuMvV2hgv9Gw0OtqJCcu/YoiNS6q4qFsW9HCV19 p+31tYZlK+9K/LBoz8G5yYsfIZh7adi6oUzoWAZH5xtfzRaW8Pfvfl+6VNJVQloNMVPz M9IGR6w9ay+sHNcN2sKrHz0MEYpUKjRnnZ/0YS3qaGWsZaaPQF8pkptNBhvoeYCIzz4L pt1Ihtlk18XgbJNTunmNioHYEP4qLV8Iif+SGduyJ2obW+9AgzNx7USOLVRT+iWgOBIf CPsA== X-Forwarded-Encrypted: i=1; AJvYcCXcDql1mtIktAUBD4i89oeqTYr2/+m1ApGIsgsc4HmwZHFW4mlWim2G4jkJcANFDQlgs3H7p5jMGgV4hRo=@vger.kernel.org X-Gm-Message-State: AOJu0Yzr54z4F0AojuJV0q+iQfE9bXIqyNgIxWGMqwi8bDlA1X4QgKFV jG4+iV/DA/W9gfPTh7ZDHL+OMiPiRMrRGM2ilTcENmrqjPx8TwB0aOpQ X-Gm-Gg: AY/fxX4ayasiajT3rSZiClF6Se0UFT7FRPs1lJaRfMchuPTsS97Zt+0AI55XsYfoTxg OhmxEUYvftBlj2E4Odx8I7INZQVmaGIRtk9swO6AdCN3qYBzMyGHSDs8kNJm/ZsDxPau6PEUnzx X4/HgMt1GJhBUTt0Pk5gHyCFDKu8maOvnyX/4cCn8hxxjgTiq6ab8GIqJodtmxe1C6A15kYZ+6c juDtQ4xCkxd3F/XEBIiTNoYJ43jeXo+4nB6ycVJBy0L7nOip8nqTGSctNzNKCxHz4h7FvpdVDoo GJ+DDwtCkK1Cgk+4PQtUET2vMeL5aELvkX/+CB+1uEDaRZgY09IiWsSYMGRr6lkomSsQYVVUwmx AS074RWa2+HgJ82QtA1RoyNQMMNNWhulqNNlg8iDkBWJPdO6fArXEGErr179h96M= X-Google-Smtp-Source: AGHT+IFSg+WSEwB3XB79RKQVyNhsmnCsLQUY9OP3lUuJ7bveG+0qIPegeK5CbVGhYsQruQ8DQXKbvw== X-Received: by 2002:a2e:b8c5:0:b0:372:8d61:c26f with SMTP id 38308e7fff4ca-38121605c79mr97545091fa.11.1767008824228; Mon, 29 Dec 2025 03:47:04 -0800 (PST) Received: from milan ([2001:9b1:d5a0:a500::24b]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3812264cc13sm82419611fa.37.2025.12.29.03.47.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Dec 2025 03:47:03 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 29 Dec 2025 12:47:01 +0100 To: "Paul E. McKenney" Cc: Uladzislau Rezki , Joel Fernandes , linux-kernel@vger.kernel.org, Frederic Weisbecker , Neeraj Upadhyay , Josh Triplett , Boqun Feng , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , rcu@vger.kernel.org Subject: Re: [PATCH v2] rcu: Reduce synchronize_rcu() latency by reporting GP kthread's CPU QS early Message-ID: References: <20251223034630.1092719-1-joelagnelf@nvidia.com> <20251226023339.GB739018@joelbox2> <1033a68f-c17b-4847-819d-7fb4e9e45016@paulmck-laptop> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1033a68f-c17b-4847-819d-7fb4e9e45016@paulmck-laptop> On Sun, Dec 28, 2025 at 04:04:49PM -0800, Paul E. McKenney wrote: > On Sun, Dec 28, 2025 at 06:57:58PM +0100, Uladzislau Rezki wrote: > > On Thu, Dec 25, 2025 at 09:33:39PM -0500, Joel Fernandes wrote: > > > On Thu, Dec 25, 2025 at 10:35:44AM -0800, Paul E. McKenney wrote: > > > > On Mon, Dec 22, 2025 at 10:46:29PM -0500, Joel Fernandes wrote: > > > > > The RCU grace period mechanism uses a two-phase FQS (Force Quiescent > > > > > State) design where the first FQS saves dyntick-idle snapshots and > > > > > the second FQS compares them. This results in long and unnecessary latency > > > > > for synchronize_rcu() on idle systems (two FQS waits of ~3ms each with > > > > > 1000HZ) whenever one FQS wait sufficed. > > > > > > > > > > Some investigations showed that the GP kthread's CPU is the holdout CPU > > > > > a lot of times after the first FQS as - it cannot be detected as "idle" > > > > > because it's actively running the FQS scan in the GP kthread. > > > > > > > > > > Therefore, at the end of rcu_gp_init(), immediately report a quiescent > > > > > state for the GP kthread's CPU using rcu_qs() + rcu_report_qs_rdp(). The > > > > > GP kthread cannot be in an RCU read-side critical section while running > > > > > GP initialization, so this is safe and results in significant latency > > > > > improvements. > > > > > > > > > > I benchmarked 100 synchronize_rcu() calls with 32 CPUs, 10 runs each > > > > > showing significant latency improvements (default settings for fqs jiffies): > > > > > > > > > > Baseline (without fix): > > > > > | Run | Mean | Min | Max | > > > > > |-----|-----------|----------|-----------| > > > > > | 1 | 10.088 ms | 9.989 ms | 18.848 ms | > > > > > | 2 | 10.064 ms | 9.982 ms | 16.470 ms | > > > > > | 3 | 10.051 ms | 9.988 ms | 15.113 ms | > > > > > | 4 | 10.125 ms | 9.929 ms | 22.411 ms | > > > > > | 5 | 8.695 ms | 5.996 ms | 15.471 ms | > > > > > | 6 | 10.157 ms | 9.977 ms | 25.723 ms | > > > > > | 7 | 10.102 ms | 9.990 ms | 20.224 ms | > > > > > | 8 | 8.050 ms | 5.985 ms | 10.007 ms | > > > > > | 9 | 10.059 ms | 9.978 ms | 15.934 ms | > > > > > | 10 | 10.077 ms | 9.984 ms | 17.703 ms | > > > > > > > > > > With fix: > > > > > | Run | Mean | Min | Max | > > > > > |-----|----------|----------|-----------| > > > > > | 1 | 6.027 ms | 5.915 ms | 8.589 ms | > > > > > | 2 | 6.032 ms | 5.984 ms | 9.241 ms | > > > > > | 3 | 6.010 ms | 5.986 ms | 7.004 ms | > > > > > | 4 | 6.076 ms | 5.993 ms | 10.001 ms | > > > > > | 5 | 6.084 ms | 5.893 ms | 10.250 ms | > > > > > | 6 | 6.034 ms | 5.908 ms | 9.456 ms | > > > > > | 7 | 6.051 ms | 5.993 ms | 10.000 ms | > > > > > | 8 | 6.057 ms | 5.941 ms | 10.001 ms | > > > > > | 9 | 6.016 ms | 5.927 ms | 7.540 ms | > > > > > | 10 | 6.036 ms | 5.993 ms | 9.579 ms | > > > > > > > > > > Summary: > > > > > - Mean latency: 9.75 ms -> 6.04 ms (38% improvement) > > > > > - Max latency: 25.72 ms -> 10.25 ms (60% improvement) > > > > > > > > > > Tested rcutorture TREE and SRCU configurations. > > > > > > > > > > [apply paulmck feedack on moving logic to rcu_gp_init()] > > > > > > > > If anything, these numbers look better, so good show!!! > > > > > > Thanks, I ended up collecting more samples in the v2 to further confirm the > > > improvements. > > > > > > > Are there workloads that might be hurt by some side effect such > > > > as increased CPU utilization by the RCU grace-period kthread? One > > > > non-mainstream hypothetical situation that comes to mind is a kernel > > > > built with SMP=y but running on a single-CPU system with a high-frequence > > > > periodic interrupt that does call_rcu(). Might that result in the RCU > > > > grace-period kthread chewing up the entire CPU? > > > > > > There are still GP delays due to FQS, even with this change, so it could not > > > chew up the entire CPU I believe. The GP cycle should still insert delays > > > into the GP kthread. I did not notice in my testing that synchronize_rcu() > > > latency dropping to sub millisecond, it was still limited by the timer wheel > > > delays and the FQS delays. > > > > > > > For a non-hypothetical case, could you please see if one of the > > > > battery-powered embedded guys would be willing to test this? > > > > > > My suspicion is the battery-powered folks are already running RCU_LAZY to > > > reduce RCU activity, so they wouldn't be effected. call_rcu() during idleness > > > will be going to the bypass. Last I checked, Android and ChromeOS were both > > > enabling RCU_LAZY everywhere (back when I was at Google). > > > > > > Uladzislau works on embedded (or at least till recently) and had recently > > > checked this area for improvements so I think he can help quantify too > > > perhaps. He is on CC. I personally don't directly work on embedded at the > > > moment, just big compute hungry machines. ;-) Uladzislau, would you have some > > > time to test on your Android devices? > > > > > I will check the patch on my home based systems, big machines also :) > > I do not work with mobile area any more thus do not have access to our > > mobile devices. In fact i am glad that i have switched to something new. > > I was a bit tired by the applied Google restrictions when it comes to > > changes to the kernel and other Android layers. > > How quickly I forget! ;-) > > Any thoughts on who would be a good person to ask about testing Joel's > patch on mobile platforms? > As Joel already wrote, Suren probably is a good person to ask :) -- Uladzislau Rezki