From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED18623B63F for ; Mon, 29 Dec 2025 13:33:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767015212; cv=none; b=Yk6/HIkYEQ9+7DQRPyTjKS2/txV60JhCjwcTYfI9PMJKWjDmZIFRrXxYB8GNuoRq5vrG78Dyb5vyzTaQLgPaJnW0AvlChTa1t0u0to+7RXlUmwDSuUAZdRfHVpI5jpNINqmhugh3wN7Injkj5tkdRvtvA+PHV/OexN7LiZlAzo8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767015212; c=relaxed/simple; bh=gpqz5nElaphZZvs4CCE1UfaZsgG+uPqb45FcVwe74RY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=H+DVyZJaG4szGNIdePk8aWxLc2HNoNuwGb0cyEVo2Ps8NQ20alHJJoSGcyCXlYUSTSCi+dPk1TlSZ+emVCxIMTy7gXzFogV+gPcQWKSHW93Yzpx8CLLvmjXIpVQrQ+qAbs40YJDFyQcTyfdZ68lotIiz8AC4C/L/OKS+ewlVNjs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=afkKoYkJ; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="afkKoYkJ" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-477aa218f20so54210185e9.0 for ; Mon, 29 Dec 2025 05:33:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1767015209; x=1767620009; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ce+SSTAL9sTdn9J8kGBQul5VYS4g6m6imR78LaTLra0=; b=afkKoYkJz8LgTMthFuJ0WGvjZF2Ik2TBU9Ig6x7BhZ061kNHtSE2tDSKaEUEOgUO28 YQ4EvqIupuy/HJ3A7+Hw/qnfD2TgIUMe5njD6J9mu81sRLbgptx5LpmzQ5H8HJDJEWog E9BRp+cbY/m1bk5amdCi+dyh7pxMLE1474FlA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767015209; x=1767620009; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ce+SSTAL9sTdn9J8kGBQul5VYS4g6m6imR78LaTLra0=; b=vCbJBJQ/TZJArxylnjG/0U9YwJ/uzNVSvWt7CAPaX3a1m7+ZJNfdlRHlyX+NVVsnsd 2M3dTAPt7IQRJiPE2hAivhf3AaazfPmF1kJkpg1QCKuwmysnVVyOixXNs8wUHT6sVveT SfFrr+Nqtm4RAaL+Q//ii9YxWGATpmFI/01+wOd+LHmnPu8RyUgHYMRtKg3u8D6rtaAy thyKdIIIliXjwAdk7j8GP8iLIyRrhUT/hfLp6dZD3up3BNcQspC0vIYsfPmevOMh7Uzc +kdS0DqX510AiqZIRliy8J285lu5EoyKdngTvtRKeV/mXyGQCO5L1QBIQQqEPAabcjwk h5OQ== X-Forwarded-Encrypted: i=1; AJvYcCW5IJobW2+tCfUQl+F+ZTCA0pq5NtHL79ZHCZsRJ6Mzyy5SWg86MJPMp7VHprcHHxdaX5Sa+Pmp1fOomd8=@vger.kernel.org X-Gm-Message-State: AOJu0YzWtybzKW98mFJ1zhdtsd9Vz2SQ7EwPwLCrQpjJMrf1uGkwe/X7 0/NXoMZvO6pFZv75juBSeAgjwvMSA/SuMJg33VjL7yqqvh6Nqkiu8avlRhiKClVIvw== X-Gm-Gg: AY/fxX7wYmVLtJcaoa3GHpceddJcOEoFoOxz7S2Yph5RL/CbWnsSrWX9HRNyRyXsXrF XMjraNZGFXlR2+DRsnSxDy82P6/MXlN15badwG1mC3GweNpxOV6rqSWnflr6pZ+OrQFzTCAjTOP kediQ4em6Li11XT327w9L0oJmjIeUBovwKrmDAnHxs1jvl51/HOmD2WVeThTDam/953RxmhaLfp Xe6QBSXIxigADIRJ0qDmPh3GHv0FhbKhfY721cPIcnYj822S2FhRyK76fjnHeTS9YFqADL5Ow3w uLna/cEmY2zF1bDy+XtTHhxojAzZCT/qIs80Q0DglKbwxofIS+KGtknLc1hF3XEvKgOAE2P80RV AojmIrwa6DC+atKIgdLgu7eRyx0yv92SuL9g4geoSP2aBHYDRtuWQxjPLFyYxwwO1cSLOYYaBg+ XGTmiitApLYCvU3L+I3LIt7jvqTzLH X-Google-Smtp-Source: AGHT+IEUBZibrNmtAx6mvVHkXWievEathjOoZ/y0M7H5kW76AmTFaxiWkAnyB/oLKVKeKbF8HcRCLQ== X-Received: by 2002:a05:600c:c494:b0:479:35e7:a0e3 with SMTP id 5b1f17b1804b1-47d19582aacmr352970715e9.30.1767015209342; Mon, 29 Dec 2025 05:33:29 -0800 (PST) Received: from google.com ([37.228.206.31]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be2723b2bsm591030295e9.3.2025.12.29.05.33.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Dec 2025 05:33:28 -0800 (PST) Date: Mon, 29 Dec 2025 13:33:26 +0000 From: Fabio Baltieri To: Krzysztof Kozlowski Cc: Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Benson Leung , Guenter Roeck , Tzung-Bi Shih , Simon Glass , linux-input@vger.kernel.org, devicetree@vger.kernel.org, chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] dt-bindings: google,cros-ec-keyb: add use-fn-overlay prop Message-ID: References: <20251224152238.485415-1-fabiobaltieri@chromium.org> <20251224152238.485415-3-fabiobaltieri@chromium.org> <20251227-laughing-white-dalmatian-f9d98a@quoll> <0c01fa63-670f-4c82-aa74-dc855cb12a78@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0c01fa63-670f-4c82-aa74-dc855cb12a78@kernel.org> On Mon, Dec 29, 2025 at 01:49:05PM +0100, Krzysztof Kozlowski wrote: > On 27/12/2025 16:48, Fabio Baltieri wrote: > > On Sat, Dec 27, 2025 at 01:44:26PM +0100, Krzysztof Kozlowski wrote: > >>> diff --git a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml > >>> index fefaaf46a240..437575cdf352 100644 > >>> --- a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml > >>> +++ b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml > >>> @@ -44,6 +44,14 @@ properties: > >>> where the lower 16 bits are reserved. This property is specified only > >>> when the keyboard has a custom design for the top row keys. > >>> > >>> + google,use-fn-overlay: > >>> + description: | > >>> + Use a function key overlay. This allows defining an extra set of codes > >> > >> What is a function key overlay? Overlays are DT term and therefore are > >> not suitable for bindings. > > > > Ok, guess I can rename it to `use-fn-key` or `use-fn-layer`, open to > > suggestions really. > > Use as Linux should use? Then it's software, so not suitable for DT. Sorry I'm not sure how I understand the comment, this describes how the driver handles a keyboard with Fn keys, the codes are defined in the DT linux,keymap property and the driver needs to know that there's an extra layer to interpret the codes correctly. > >>> + that are sent if a key is pressed while the KEY_FN is held pressed as > >>> + well. The function codes have to be defined in the linux,keymap property > >>> + with an offset of keypad,num-rows from the normal ones. > >>> + type: boolean > >>> + > >>> dependencies: > >>> function-row-physmap: [ 'linux,keymap' ] > >>> google,needs-ghost-filter: [ 'linux,keymap' ] > >>> @@ -132,6 +140,23 @@ examples: > >>> /* UP LEFT */ > >>> 0x070b0067 0x070c0069>; > >>> }; > >>> + - | > >>> + /* With function keys */ > >>> + #include > >>> + keyboard-controller { > >>> + compatible = "google,cros-ec-keyb"; > >>> + keypad,num-rows = <8>; > >>> + keypad,num-columns = <18>; > >>> + google,use-fn-overlay; > >> > >> Difference in one property does not justify new example. > > > > Sure but when the property is set then one has to specify the extra > > codes in the linux,keymap property and this examples shows how. I'll > > drop it if you want me to but I think there's value in it. > > Examples are for verifying schema and you do not have schema enforcing > this, thus still pointless. Add schema for that, assuming property will > stay. Ok got it, I'll just drop it in v3.