From: Amir Goldstein <amir73il@gmail.com>
To: Namjae Jeon <linkinjeon@kernel.org>
Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, hch@infradead.org,
hch@lst.de, tytso@mit.edu, willy@infradead.org, jack@suse.cz,
djwong@kernel.org, josef@toxicpanda.com, sandeen@sandeen.net,
rgoldwyn@suse.com, xiang@kernel.org, dsterba@suse.com,
pali@kernel.org, ebiggers@kernel.org, neil@brown.name,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
iamjoonsoo.kim@lge.com, cheol.lee@lge.com, jay.sim@lge.com,
gunho.lee@lge.com
Subject: Re: [PATCH v3 RESEND 01/14] Revert "fs: Remove NTFS classic"
Date: Mon, 29 Dec 2025 17:49:13 +0200 [thread overview]
Message-ID: <aVKi-ZiyIRj9IF1h@amir-ThinkPad-T480> (raw)
In-Reply-To: <20251229112446.12164-2-linkinjeon@kernel.org>
On Mon, Dec 29, 2025 at 08:24:33PM +0900, Namjae Jeon wrote:
> This reverts commit 7ffa8f3d30236e0ab897c30bdb01224ff1fe1c89.
> ---
> fs/ntfs/aops.c | 1744 ++++++++++++++++++++++++
> fs/ntfs/aops.h | 88 ++
> fs/ntfs/attrib.c | 2624 ++++++++++++++++++++++++++++++++++++
> fs/ntfs/attrib.h | 102 ++
> fs/ntfs/bitmap.c | 179 +++
> fs/ntfs/bitmap.h | 104 ++
> fs/ntfs/collate.c | 110 ++
> fs/ntfs/collate.h | 36 +
> fs/ntfs/compress.c | 950 +++++++++++++
> fs/ntfs/debug.c | 159 +++
> fs/ntfs/debug.h | 57 +
> fs/ntfs/dir.c | 1540 +++++++++++++++++++++
> fs/ntfs/dir.h | 34 +
> fs/ntfs/endian.h | 79 ++
> fs/ntfs/file.c | 1997 +++++++++++++++++++++++++++
> fs/ntfs/index.c | 440 ++++++
> fs/ntfs/index.h | 134 ++
> fs/ntfs/inode.c | 3102 ++++++++++++++++++++++++++++++++++++++++++
> fs/ntfs/inode.h | 310 +++++
> fs/ntfs/layout.h | 2421 +++++++++++++++++++++++++++++++++
> fs/ntfs/lcnalloc.c | 1000 ++++++++++++++
> fs/ntfs/lcnalloc.h | 131 ++
> fs/ntfs/logfile.c | 849 ++++++++++++
> fs/ntfs/logfile.h | 295 ++++
> fs/ntfs/malloc.h | 77 ++
> fs/ntfs/mft.c | 2907 ++++++++++++++++++++++++++++++++++++++++
> fs/ntfs/mft.h | 110 ++
> fs/ntfs/mst.c | 189 +++
> fs/ntfs/namei.c | 392 ++++++
> fs/ntfs/ntfs.h | 150 +++
> fs/ntfs/quota.c | 103 ++
> fs/ntfs/quota.h | 21 +
> fs/ntfs/runlist.c | 1893 ++++++++++++++++++++++++++
> fs/ntfs/runlist.h | 88 ++
> fs/ntfs/super.c | 3202 ++++++++++++++++++++++++++++++++++++++++++++
> fs/ntfs/sysctl.c | 58 +
> fs/ntfs/sysctl.h | 27 +
> fs/ntfs/time.h | 89 ++
> fs/ntfs/types.h | 55 +
> fs/ntfs/unistr.c | 384 ++++++
> fs/ntfs/upcase.c | 73 +
> fs/ntfs/volume.h | 164 +++
> 42 files changed, 28467 insertions(+)
> create mode 100644 fs/ntfs/aops.c
> create mode 100644 fs/ntfs/aops.h
> create mode 100644 fs/ntfs/attrib.c
> create mode 100644 fs/ntfs/attrib.h
> create mode 100644 fs/ntfs/bitmap.c
> create mode 100644 fs/ntfs/bitmap.h
> create mode 100644 fs/ntfs/collate.c
> create mode 100644 fs/ntfs/collate.h
> create mode 100644 fs/ntfs/compress.c
> create mode 100644 fs/ntfs/debug.c
> create mode 100644 fs/ntfs/debug.h
> create mode 100644 fs/ntfs/dir.c
> create mode 100644 fs/ntfs/dir.h
> create mode 100644 fs/ntfs/endian.h
> create mode 100644 fs/ntfs/file.c
> create mode 100644 fs/ntfs/index.c
> create mode 100644 fs/ntfs/index.h
> create mode 100644 fs/ntfs/inode.c
> create mode 100644 fs/ntfs/inode.h
> create mode 100644 fs/ntfs/layout.h
> create mode 100644 fs/ntfs/lcnalloc.c
> create mode 100644 fs/ntfs/lcnalloc.h
> create mode 100644 fs/ntfs/logfile.c
> create mode 100644 fs/ntfs/logfile.h
> create mode 100644 fs/ntfs/malloc.h
> create mode 100644 fs/ntfs/mft.c
> create mode 100644 fs/ntfs/mft.h
> create mode 100644 fs/ntfs/mst.c
> create mode 100644 fs/ntfs/namei.c
> create mode 100644 fs/ntfs/ntfs.h
> create mode 100644 fs/ntfs/quota.c
> create mode 100644 fs/ntfs/quota.h
> create mode 100644 fs/ntfs/runlist.c
> create mode 100644 fs/ntfs/runlist.h
> create mode 100644 fs/ntfs/super.c
> create mode 100644 fs/ntfs/sysctl.c
> create mode 100644 fs/ntfs/sysctl.h
> create mode 100644 fs/ntfs/time.h
> create mode 100644 fs/ntfs/types.h
> create mode 100644 fs/ntfs/unistr.c
> create mode 100644 fs/ntfs/upcase.c
> create mode 100644 fs/ntfs/volume.h
>
Namje,
This is a partial revert, something that should be mention in commit
message.
But also, I think you should include more of the original revert, like
the docs and MAINTAINERS entry, which you added later, sometimes inside
unrelated patches.
The only think that you need to omit from the revert in the Makefile and
Kconfig changes, so that ntfs code remains dormant until the end of the
series.
Thanks,
Amir.
next prev parent reply other threads:[~2025-12-29 15:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-29 11:24 [PATCH v3 RESEND 00/12] ntfs filesystem remake Namjae Jeon
2025-12-29 11:24 ` [PATCH v3 RESEND 01/14] Revert "fs: Remove NTFS classic" Namjae Jeon
2025-12-29 15:49 ` Amir Goldstein [this message]
2025-12-29 23:02 ` Namjae Jeon
2025-12-29 11:24 ` [PATCH v3 RESEND 02/14] ntfs: update in-memory, on-disk structures and headers Namjae Jeon
2025-12-29 11:24 ` [PATCH v3 RESEND 03/14] ntfs: update super block operations Namjae Jeon
2025-12-29 11:24 ` [PATCH v3 RESEND 05/14] ntfs: update directory operations Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aVKi-ZiyIRj9IF1h@amir-ThinkPad-T480 \
--to=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=cheol.lee@lge.com \
--cc=djwong@kernel.org \
--cc=dsterba@suse.com \
--cc=ebiggers@kernel.org \
--cc=gunho.lee@lge.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=iamjoonsoo.kim@lge.com \
--cc=jack@suse.cz \
--cc=jay.sim@lge.com \
--cc=josef@toxicpanda.com \
--cc=linkinjeon@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil@brown.name \
--cc=pali@kernel.org \
--cc=rgoldwyn@suse.com \
--cc=sandeen@sandeen.net \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®