From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E8B0257435 for ; Tue, 30 Dec 2025 11:42:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767094969; cv=none; b=tO5n5gFguStL6RmOz4gv3bYQu2n5W0i6NhF0tmLHoLvIBaF/4jiNRqa8OKaqmiUTMywQQRWp2r1E0gyQKwHXLeyyReHhk2I7C3mbburLpopSglj/BlwKFA7Dwg1lI2R1GzU+LLyw6/BkOcJtLx4KEJyWruuJ2TXs1n2BGqKByRs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767094969; c=relaxed/simple; bh=W1I5n7Y43qAPPmembYAFQ2bODbvz/MzKLDxex8k0KLg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=X8fPQjSHVXBgmTR1ps3B/BVIO0uwb21cU09V/qrBPQrNCyYGESBNHQKQsFZ5+XpCwIZc/5t0Wth12fG4eC3qsgqP5VsS9w1cVd2OXG4v8WMIeimvewWlAk54L4NBN4yXG/EBImgIp/Zi5ayJ/Dskujd1FTG2L0hYfmAfk29TQwI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Ew3JWeCT; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Ew3JWeCT" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-42fb0fc5aa4so7704893f8f.1 for ; Tue, 30 Dec 2025 03:42:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1767094966; x=1767699766; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Ec7rpaL2aGUuJsuasFfWfPs3/0VhYUl5PR3FKjXgrDs=; b=Ew3JWeCTIjkLSSMSM7XMcNKpcGxtgZSobrUNFvqPmD3BHjlXCGdWnPbxd/KEqGFSyz coUp0zJs1aK5PukFOSys5pc5jT72ELeuoWMKEXGOemoN62XaT24Gdi7RpbLUkGRyoHUp oM/R+H7iEg4t8MsBhwP8WdkJ7oeZo+gvG8Ppg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767094966; x=1767699766; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ec7rpaL2aGUuJsuasFfWfPs3/0VhYUl5PR3FKjXgrDs=; b=sFBq+ylAwnbNfxkpVPx1h0KK9JLuuyeQeE/IfImnIXzO6sAqi8wVm1nw9AMw9h02Qj qr9vZ3CEatbSMY2CDjiPzPl7fZBaWQpEELZC/JkzW3MT74XZzWRwaA8WJ4BIWo/OEKzM V/NXAcN6sdBYxV2YFOFcUaaJjNWL/tNXwAGr9/C917/N6LQ2SGyklG55NtXaoFUk9cJY sbjX+C7o7NX3BlEbswPBZrcgl7a8OeEdckHWWMNqi5ZJLb9dY/PeqpYBmnMR//kVvV/u EKnKba7St88yeeyYFGB2VJxaArHahIkQEPllEfEVJL4Fmcc4wY2mKqKyZXC1nxNRrOmV d6zA== X-Forwarded-Encrypted: i=1; AJvYcCWqjJ3N+AlcShlvZXobDnKSor8YIinvoN3W7BuX+fZHt30NRgFg+5kMzstGASlm2aZ7NOKsf5v+bdbTQH8=@vger.kernel.org X-Gm-Message-State: AOJu0YwRc7IvhRi+7VAehKq/zAbLw+BzNLuHXTSr8KYyOVTAhtQ+NCEX g4eidQDn5qcMNEq7b/DSBvmFI3D9VdNc16WPE9l9Bm4+Q5kU7AWV6UHnWPcQzGC+8A== X-Gm-Gg: AY/fxX4GcomjfKORm38pabVsD7PpS3DI8UOShXtYRXNGTve6Y4RE5GrXbrPT8t+AvVI KZDkFWltqtlC04ILElXYsuIOKDGyW1J/M6i5uCzpoL+dUsMx3TPknZOFeBcuISsgMAKRnRbBjT0 DXs9/QeS9qXp3FT/0Wgtvz18NIsl75oVShL9Q8uO1ZgaafcEVqMpx/ifwH32zHsd2q1kYLr5uGY sR7sKbZMVxBcK+HYoJiGxH0MBm10LGMPjSHmJ0KFW+5sWuLXOj2rxd+JT9RTxI/K/A6ebSGMqVS 4oO0ymoBVBEx1YY0v3j38UR8Mt3U7WaDnqp/kQ53wqfA87F5E9SbiekevApTSIrHyVvHSi8SjMQ aZjIRWuNcUiWAJ+AxN3rBRgZflmVCzeroauwmj1LnoKBt6pmtrvY2qBVRkZGBkJwTrv7GhipcF5 ZzBSTpe88QYTvOpOhOMYHYS2ZENoO8 X-Google-Smtp-Source: AGHT+IE1EZZ3iXjzIXqJjM6pUCinYXxs5mhQl9LTGmF+m9PMSBJUOFGdEr/Asv7D9VBeVrox2F4jkQ== X-Received: by 2002:a05:6000:2586:b0:431:808:2d3d with SMTP id ffacd0b85a97d-4324e4fdcbfmr38901938f8f.32.1767094965729; Tue, 30 Dec 2025 03:42:45 -0800 (PST) Received: from google.com ([37.228.206.31]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eaa08efsm68411184f8f.29.2025.12.30.03.42.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Dec 2025 03:42:45 -0800 (PST) Date: Tue, 30 Dec 2025 11:42:43 +0000 From: Fabio Baltieri To: Krzysztof Kozlowski Cc: Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Benson Leung , Guenter Roeck , Tzung-Bi Shih , Simon Glass , linux-input@vger.kernel.org, devicetree@vger.kernel.org, chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] dt-bindings: google,cros-ec-keyb: add use-fn-overlay prop Message-ID: References: <20251224152238.485415-1-fabiobaltieri@chromium.org> <20251224152238.485415-3-fabiobaltieri@chromium.org> <20251227-laughing-white-dalmatian-f9d98a@quoll> <0c01fa63-670f-4c82-aa74-dc855cb12a78@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Dec 30, 2025 at 08:26:56AM +0100, Krzysztof Kozlowski wrote: > On 29/12/2025 16:39, Fabio Baltieri wrote: > > Sure so I guess this falls into the "describe the hardware feature" > > category, so is the suggestion to rename it to something like > > "has-fn-key"? That would be the hardware feature. > > > Maybe, but then I would follow up with - what about "alt", "ctrl", > "shift" and "fn" keys? And what about combinations alt+ctrl, alt+shift? > And also caps-lock? And why exactly this has to be even specified if > matrix map already has the FN key? Fn works as a key layer, that is when the key is pressed the rest of the matrix uses a different keymap, different codes. The driver has to make extra space in the internal data structures for reading the new codes from the keymap property and use them when they are specified. The other combinations you mentioned behave normally, nothing special about them. Looking at the input driver history the other driver that [used to] have this was using a platform data field called use_fn_map, guess I'll go with use-fn-map then (that one has never been ported over to dt).