From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4561427FD43 for ; Tue, 30 Dec 2025 11:08:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767092895; cv=none; b=djCE6EC/++wzMIdQEF8d6ugk8ADgtJwWEoc5KR2oDd9YvSQbA214ViuKlmRZhw0njtVEX5L+9+8pOViRMPvm797A/jtmZw1o1QlSDr0Nt5K8TXYpjyFUG9QK4HsZHtMoCUDBUQg5aeELgfALngKgtw5ihnqLGNiEZ0MZv9jTekk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767092895; c=relaxed/simple; bh=4D0fiHWhXDEW5Ytcxhqg+9wEzv3/DBgvxj/5BYRqJW4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QwhADWjdAU2YbwFmY/S8sbLYv7uJZoz2cBGUmYEojfEP8oJ/G/2l4v9Ema4Tf3tBDgXYVZuk/UI8cMlrSDy1suQXuKRNEhBRM1O+23tahPtMnmrnu8Hrb/LVUegQJ/G7+/h9B+07h8rK+RRkxVArRmN6H5wQgIbah+EXRklZbt0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Gndf205i; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Gndf205i" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-29f2676bb21so132735565ad.0 for ; Tue, 30 Dec 2025 03:08:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767092893; x=1767697693; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=O6T4TM4UyzYhmp2v2V8GRXesYGcD0Z4PxJ/JcroqgtI=; b=Gndf205iuN0DhK+1hdMhJAjoBigjehNqRKMKO0X4NmZECHnyYCc4GK4BgoGDvFBo2U iVUQiVFVmU2WUvoPYDvsTCsyfhqVHU5biu2irsADIszD9DUHN+bNDEGwOppr8lsFZ4gS 8hzuqXtVLLTEqdOeNEFyJUjC6noHfSN8CAdYrlk+TBW4U5nPyWmaRCLnHGJQOE4aBPKE s5j/gIb+bUOO+0ImfJw3g1pi14ihpLpNDvc9SWSsFKTTZUu7hNsqo+p44QLqcXTL8+fj 8pHkoc43kNkEH9ZVo9LJxlIAbxNmPkvvbodTlWZejZUzkEEmLFQfHaFITF3GEYQNIrhW lHyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767092893; x=1767697693; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O6T4TM4UyzYhmp2v2V8GRXesYGcD0Z4PxJ/JcroqgtI=; b=GI/sUtUO8X6ONvluwSIzoVrSIzAVvyzsNNFNGAF/KRFBg/cczrrI96QzvP0/ll6PRF xfAQvx8kC+qxd1MYJvjgLPmtmMD8/S0SpTnhb2goMgfIiZnYofgV5Ud+9R2XLdFWTmJW 4xcxgdqdpQzzCjnMEkhVCAByYuSjv6M06myGNv1vdI7vWkWlnXpdEpukFRHX/DnXCUta wn7bUpBhUT2AX40UnhOkuXgZ+GUgcHJ625lstirUXaBrB0xtQDbkwlZ9q84BGaojXDq/ LusYfgQbCL7qhuOP3AB0LTfkln3fpGEafzagwC7DztDteC6flNjoPD/RV49lc1DimPuV Rjrw== X-Forwarded-Encrypted: i=1; AJvYcCXKMttuGDzziOwk1jnfwHbDjWRCTqOjD27OSVt7fo0x0votvTqp5r7I7fHpMM7QNLt8huUcMnB+u+rS0iI=@vger.kernel.org X-Gm-Message-State: AOJu0YyUh4exw8yi2DB5eiXpb6iUUJaLeKpMpP0M4xfBPnO4pzCadUPq gltZIWd593/kCV/FtDOyvivvYf+ay9fJgLXfoiVisGIW/UnhJ884EHz4 X-Gm-Gg: AY/fxX5UJ7Wls+HpKik/sarq3lREg0EUSklA1bIXmxhra4tIk2sNksPDphKGr93m9rT uiebEfOpGcAvDR7KkfRJd3sHrUzRB3k2xYTXMBd7vpD8/E52qHz+m4fPKUa4R+rdomyB0AcHSEo i5uNpfUM9HtXovQSdZmhusFRkU8/N7z0H0Ukw6Z3aH3j3gJDQ2kLjRJTEPh6a2XSI+dOi9LDk60 k4xXMQ3M6o4Bvv6+ssFbGeRCuePt/jLl8Jv9VYPHQfovCx6qusVxbD4XviT18fi0SKQkY7tVZy8 HvbSeCi4ny9RhnDRpUHHkVfnz5Em/rVBiN+JEMffI8OkXkBKrgJwlr4cUcmMK2e9tOgofHcoNzI ef7kT50tvRr52y9DcQHNlz/GGPm3ZtpinaDKX1ASax126N2Y6bKhPXEcTDa6jNJOLKDd4SLEr68 hPx95xov3e4Q== X-Google-Smtp-Source: AGHT+IFdoXT1kgIAaEAH0f/HKYeNyf//JmLjWqqguUf/fnFyPcQf8JSxquZN9Ic4u5zIlQU2VDZMEA== X-Received: by 2002:a05:7022:689:b0:119:e569:f620 with SMTP id a92af1059eb24-121722e13ddmr42552599c88.25.1767092893296; Tue, 30 Dec 2025 03:08:13 -0800 (PST) Received: from localhost ([2001:19f0:ac00:4eb8:5400:5ff:fe30:7df3]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-121724dd7f5sm126440428c88.5.2025.12.30.03.08.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Dec 2025 03:08:12 -0800 (PST) Date: Tue, 30 Dec 2025 19:08:06 +0800 From: Inochi Amaoto To: Manivannan Sadhasivam , Inochi Amaoto Cc: Bjorn Helgaas , Bjorn Helgaas , Chen Wang , Han Gao , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Yixun Lan , Longbin Li Subject: Re: [PATCH 0/2] PCI/ASPM: Avoid L0s and L1 on Sophgo 2042/2044 PCIe Root Ports Message-ID: References: <20251225100530.1301625-1-inochiama@gmail.com> <20251226163031.GA4128882@bhelgaas> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Dec 30, 2025 at 03:38:11PM +0530, Manivannan Sadhasivam wrote: > On Tue, Dec 30, 2025 at 05:45:39PM +0800, Inochi Amaoto wrote: > > On Fri, Dec 26, 2025 at 10:30:31AM -0600, Bjorn Helgaas wrote: > > > On Thu, Dec 25, 2025 at 06:05:27PM +0800, Inochi Amaoto wrote: > > > > Since commit f3ac2ff14834 ("PCI/ASPM: Enable all ClockPM and ASPM > > > > states for devicetree platforms") force enable ASPM on all device tree > > > > platform, the SG2042/SG2044 PCIe Root Ports breaks as it advertises L0s > > > > and L1 capabilities without supporting it. > > > > > > > > Override the L0s and L1 Support advertised in Link Capabilities by the > > > > SG2042/SG2044 Root Ports so we don't try to enable those states. > > > > > > > > Inochi Amaoto (2): > > > > PCI/ASPM: Avoid L0s and L1 on Sophgo 2042 PCIe [1f1c:2042] Root Ports > > > > PCI/ASPM: Avoid L0s and L1 on Sophgo 2044 PCIe [1f1c:2044] Root Ports > > > > > > > > drivers/pci/quirks.c | 2 ++ > > > > include/linux/pci_ids.h | 2 ++ > > > > 2 files changed, 4 insertions(+) > > > > > > 1) Can somebody at Sophgo confirm that this is a hardware erratum? I > > > just want to make rule out some kind of OS bug in configuring L0s/L1. > > > > > > > Hi Bjorn, > > > > I have asked for the Sophgo staff, and they already confirmed this > > hardware errata. > > > > Okay. If the hardware (Root Port) doesn't support L0s and L1, you should disable > the capability in the sophgo controller driver instead. You can use this as a > reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/controller/dwc/pcie-qcom.c#n331 > > Quirks is mostly meant for PCI endpoint devices (sometimes Root Ports also if > there is no host controller driver). > > - Mani > Good to know, I will switch to quirks, thanks. Regards, Inochi