From: Frank Li <Frank.li@nxp.com>
To: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
Cc: tomm.merciai@gmail.com, linux-renesas-soc@vger.kernel.org,
biju.das.jz@bp.renesas.com,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] i3c: renesas: Factor out hardware initialization to separate function
Date: Tue, 30 Dec 2025 10:47:57 -0500 [thread overview]
Message-ID: <aVP0LV3K07ciFR+e@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <c93219af1fcfc461a1b072df0289c291a37c45bb.1767090535.git.tommaso.merciai.xr@bp.renesas.com>
On Tue, Dec 30, 2025 at 11:39:38AM +0100, Tommaso Merciai wrote:
> Move the hardware initialization sequence in renesas_i3c_bus_init()
> into a dedicated renesas_i3c_hw_init() helper.
>
> This simplifies the code, and prepares the driver for upcoming
> suspend/resume support.
Nit: Simplify the code and prepare the driver for ...
Reviewed-by: Frank Li <Frank.Li@nxp.com>
>
> No functional change intended.
>
> Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
> ---
> v1->v2:
> - New patch.
>
> drivers/i3c/master/renesas-i3c.c | 99 ++++++++++++++++++--------------
> 1 file changed, 55 insertions(+), 44 deletions(-)
>
> diff --git a/drivers/i3c/master/renesas-i3c.c b/drivers/i3c/master/renesas-i3c.c
> index 2736363c9074..4f076c372b36 100644
> --- a/drivers/i3c/master/renesas-i3c.c
> +++ b/drivers/i3c/master/renesas-i3c.c
> @@ -485,13 +485,65 @@ static int renesas_i3c_reset(struct renesas_i3c *i3c)
> 0, 1000, false, i3c->regs, RSTCTL);
> }
>
> +static void renesas_i3c_hw_init(struct renesas_i3c *i3c)
> +{
> + u32 val;
> +
> + /* Disable Slave Mode */
> + renesas_writel(i3c->regs, SVCTL, 0);
> +
> + /* Initialize Queue/Buffer threshold */
> + renesas_writel(i3c->regs, NQTHCTL, NQTHCTL_IBIDSSZ(6) |
> + NQTHCTL_CMDQTH(1));
> +
> + /* The only supported configuration is two entries*/
> + renesas_writel(i3c->regs, NTBTHCTL0, 0);
> + /* Interrupt when there is one entry in the queue */
> + renesas_writel(i3c->regs, NRQTHCTL, 0);
> +
> + /* Enable all Bus/Transfer Status Flags */
> + renesas_writel(i3c->regs, BSTE, BSTE_ALL_FLAG);
> + renesas_writel(i3c->regs, NTSTE, NTSTE_ALL_FLAG);
> +
> + /* Interrupt enable settings */
> + renesas_writel(i3c->regs, BIE, BIE_NACKDIE | BIE_TENDIE);
> + renesas_writel(i3c->regs, NTIE, 0);
> +
> + /* Clear Status register */
> + renesas_writel(i3c->regs, NTST, 0);
> + renesas_writel(i3c->regs, INST, 0);
> + renesas_writel(i3c->regs, BST, 0);
> +
> + /* Hot-Join Acknowlege setting. */
> + renesas_set_bit(i3c->regs, BCTL, BCTL_HJACKCTL);
> +
> + renesas_writel(i3c->regs, IBINCTL, IBINCTL_NRHJCTL | IBINCTL_NRMRCTL |
> + IBINCTL_NRSIRCTL);
> +
> + renesas_writel(i3c->regs, SCSTLCTL, 0);
> + renesas_set_bit(i3c->regs, SCSTRCTL, SCSTRCTL_ACKTWE);
> +
> + /* Bus condition timing */
> + val = DIV_ROUND_UP(I3C_BUS_TBUF_MIXED_FM_MIN_NS,
> + NSEC_PER_SEC / i3c->rate);
> + renesas_writel(i3c->regs, BFRECDT, BFRECDT_FRECYC(val));
> +
> + val = DIV_ROUND_UP(I3C_BUS_TAVAL_MIN_NS,
> + NSEC_PER_SEC / i3c->rate);
> + renesas_writel(i3c->regs, BAVLCDT, BAVLCDT_AVLCYC(val));
> +
> + val = DIV_ROUND_UP(I3C_BUS_TIDLE_MIN_NS,
> + NSEC_PER_SEC / i3c->rate);
> + renesas_writel(i3c->regs, BIDLCDT, BIDLCDT_IDLCYC(val));
> +}
> +
> static int renesas_i3c_bus_init(struct i3c_master_controller *m)
> {
> struct renesas_i3c *i3c = to_renesas_i3c(m);
> struct i3c_bus *bus = i3c_master_get_bus(m);
> struct i3c_device_info info = {};
> struct i2c_timings t;
> - u32 double_SBR, val;
> + u32 double_SBR;
> int cks, pp_high_ticks, pp_low_ticks, i3c_total_ticks;
> int od_high_ticks, od_low_ticks, i2c_total_ticks;
> int ret;
> @@ -564,49 +616,8 @@ static int renesas_i3c_bus_init(struct i3c_master_controller *m)
>
> renesas_writel(i3c->regs, REFCKCTL, REFCKCTL_IREFCKS(cks));
>
> - /* Disable Slave Mode */
> - renesas_writel(i3c->regs, SVCTL, 0);
> -
> - /* Initialize Queue/Buffer threshold */
> - renesas_writel(i3c->regs, NQTHCTL, NQTHCTL_IBIDSSZ(6) |
> - NQTHCTL_CMDQTH(1));
> -
> - /* The only supported configuration is two entries*/
> - renesas_writel(i3c->regs, NTBTHCTL0, 0);
> - /* Interrupt when there is one entry in the queue */
> - renesas_writel(i3c->regs, NRQTHCTL, 0);
> -
> - /* Enable all Bus/Transfer Status Flags */
> - renesas_writel(i3c->regs, BSTE, BSTE_ALL_FLAG);
> - renesas_writel(i3c->regs, NTSTE, NTSTE_ALL_FLAG);
> -
> - /* Interrupt enable settings */
> - renesas_writel(i3c->regs, BIE, BIE_NACKDIE | BIE_TENDIE);
> - renesas_writel(i3c->regs, NTIE, 0);
> -
> - /* Clear Status register */
> - renesas_writel(i3c->regs, NTST, 0);
> - renesas_writel(i3c->regs, INST, 0);
> - renesas_writel(i3c->regs, BST, 0);
> -
> - /* Hot-Join Acknowlege setting. */
> - renesas_set_bit(i3c->regs, BCTL, BCTL_HJACKCTL);
> -
> - renesas_writel(i3c->regs, IBINCTL, IBINCTL_NRHJCTL | IBINCTL_NRMRCTL |
> - IBINCTL_NRSIRCTL);
> -
> - renesas_writel(i3c->regs, SCSTLCTL, 0);
> - renesas_set_bit(i3c->regs, SCSTRCTL, SCSTRCTL_ACKTWE);
> -
> - /* Bus condition timing */
> - val = DIV_ROUND_UP(I3C_BUS_TBUF_MIXED_FM_MIN_NS, NSEC_PER_SEC / i3c->rate);
> - renesas_writel(i3c->regs, BFRECDT, BFRECDT_FRECYC(val));
> -
> - val = DIV_ROUND_UP(I3C_BUS_TAVAL_MIN_NS, NSEC_PER_SEC / i3c->rate);
> - renesas_writel(i3c->regs, BAVLCDT, BAVLCDT_AVLCYC(val));
> -
> - val = DIV_ROUND_UP(I3C_BUS_TIDLE_MIN_NS, NSEC_PER_SEC / i3c->rate);
> - renesas_writel(i3c->regs, BIDLCDT, BIDLCDT_IDLCYC(val));
> + /* I3C hw init*/
> + renesas_i3c_hw_init(i3c);
>
> ret = i3c_master_get_free_addr(m, 0);
> if (ret < 0)
> --
> 2.43.0
>
next prev parent reply other threads:[~2025-12-30 15:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-30 10:39 [PATCH v2 0/4] i3c: renesas: Add suspend/resume support Tommaso Merciai
2025-12-30 10:39 ` [PATCH v2 1/4] i3c: renesas: Switch to clk_bulk API and store clocks in private data Tommaso Merciai
2025-12-30 15:44 ` Frank Li
2025-12-30 16:24 ` Tommaso Merciai
2025-12-30 18:39 ` Tommaso Merciai
2025-12-30 10:39 ` [PATCH v2 2/4] i3c: renesas: Store clock rate and reset controls in struct renesas_i3c Tommaso Merciai
2025-12-30 15:45 ` Frank Li
2025-12-30 10:39 ` [PATCH v2 3/4] i3c: renesas: Factor out hardware initialization to separate function Tommaso Merciai
2025-12-30 15:47 ` Frank Li [this message]
2025-12-30 16:27 ` Tommaso Merciai
2025-12-30 10:39 ` [PATCH v2 4/4] i3c: renesas: Add suspend/resume support Tommaso Merciai
2025-12-30 15:52 ` Frank Li
2025-12-30 16:31 ` Tommaso Merciai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aVP0LV3K07ciFR+e@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=tomm.merciai@gmail.com \
--cc=tommaso.merciai.xr@bp.renesas.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®