From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3907B219E8D for ; Thu, 8 Jan 2026 15:52:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767887571; cv=none; b=D83IJniHeN2nMyuzYsBCyb4Zef8wI+9slfsLLEhQ15uGm0MX8M2lXfJT9nP6V8SsvTtPqgVOZvaI+7z5y2c6FpUuK0gZ8y85gzWqFCx0KVoiGAViHXr/bxSPakQSN6ldkAlQW59w2YcqMyP/RPLhZN+cutm5TEQOAL42fKX4Kts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767887571; c=relaxed/simple; bh=EEJh77iqEYFpeDoad0e8nWOGFqAtS/ukL7H/PM0/J48=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Lu/Ow3qw+EKYUkquKzkApcdy+0AMFmjEJbtpPk3vxuZUF/+rye+V0vrharG1IMXwP59FcAFokw8vsR8ZExTjk4Ijf6F6g7lShZ5YHlKyQaFgYI0CUSvx4V38qjDdiNyjxbqwEcKaLZiVM1AODm+PbaL/sRl0cXmNfBMxuwCDYyU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=SAQlabKx; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="SAQlabKx" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-47a95efd2ceso30386915e9.2 for ; Thu, 08 Jan 2026 07:52:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1767887568; x=1768492368; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zWqYkaBYEdNJihPXD2ZUvss1qwPda+IeW592mvFAn6A=; b=SAQlabKxampmp8z0K67L79KMTKOagOLqifC2XYYFBgvkqC6HBbH7xo6VMbAatjC3FY isPvBrMtQIq6Cd264TUoJW2IsmsVf2irIbMDk26Vsq9vw1HfnNbqooFVJfjiyxrDo0DU 06LwUc7b9ra9kDXRE/FbI0UaOizxyXQCvAJgRPPTxZF6tuAWaK6uwJABCGMDRP3Jwy/g T8+lCOr+K7UNmpZlxEFNlpi8KO3EF4iWTX23Cs9fdhT2yGM26my55VeTNkZZGkvtM12f T68KtjK8z0AQYkPsegghW/+8jikyLWBBmah4QGJrIIOl0WRCf5jnglx4hOVY8adLbEUk 5JGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767887568; x=1768492368; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zWqYkaBYEdNJihPXD2ZUvss1qwPda+IeW592mvFAn6A=; b=gniyLG68wYse8LoDKWj/Qz5vxl418deEa1I01S+bA5lmMHZRcDYGaAL/gJMJCul/gg 45CTOckA7Y88U6VcDE8QJhm4ErM6eAIzr7GZ2PtPSy4XdMFTaDtSP675l4RsexcLQPxu MmctblnqrzNlFKA2o8TLzfPMHzMktikgmjWBqID7djjixhefJBP6/3qTs+WF0ypYHm00 wHqvqAeZuoklYdDE0k4lnug2mmhzA4mjXPVyhlQ2r+Ys9hGYgKPmF6z1ADDsPmxq5jdB Pej+IAaelA7GRkcDM2mT0++CU4Mcu6KhS/0S32LzjToEukvjDloEBzGejKtiYTnOmqXk EZoQ== X-Forwarded-Encrypted: i=1; AJvYcCU1iwhqderICaSuSOv3tJiOcIkQq3+hN6NviTqNsmCf1p9f3NDd2geA/NNZLq87ANljPaX0GNV8LCZqTdY=@vger.kernel.org X-Gm-Message-State: AOJu0YzQAD589mWxigu4ilSueI1PVpzHRz/hHTA1kRq1rbG5TkKNgLIB moeq30b9kJPmnTO07mhtu5a0sf4h/Q87VSekrq8FcnzBr1Ie9MDCPINv1dCZH1ZBWzk= X-Gm-Gg: AY/fxX5ePpOliyCRO/cr7lHIvRAw3YmTTopbDovZ42M9sCFHtLexoazEAt3iNm7Qo4V pg7VBAs8WQmwRGK37EM29+bZ3P3u12ILR16i7Yiw16WRrtWRdxlc4Jv3jz7lKkEXR1ZuZx5P5Us ib9vQSzmPcCN3BG5Md6iZmkRenR/ktn1SlnuL2eyvXXrXIW1wcgxmNqfvi8EVnpQXY3lMmhebmS A3uug77vTDb406PKiySwq9Ch5swT78E9PHg5gXo+oa84nJauemd1XFVDZMgD2WOuhMhdNQGYtQL z7D2t44Vx1Wa0rfBwW4rAu+nDT6Eu3vwGJnEblVAIJuMH7F0P2XkDl/ZdFFoDx9DBv55Ih7s8kL pnHVO+C+OohxvwAKa6T5MNpCBwQr0dw4tx7iapxh23Z+r4/3HVmG3/vPGfbEhOCq8uxjPwqxlTd L2XQ7QdA2lq1nC+Q== X-Google-Smtp-Source: AGHT+IGTZOs6qtiyWerKGlDUdCsrd967EGAnWeVmwk4R+3K7x23OV54U8yz39csMg0S1zFrnBwuJkw== X-Received: by 2002:a05:600c:8b58:b0:477:af07:dd1c with SMTP id 5b1f17b1804b1-47d84b4079fmr84588345e9.35.1767887568524; Thu, 08 Jan 2026 07:52:48 -0800 (PST) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f653c61sm156164005e9.10.2026.01.08.07.52.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 07:52:48 -0800 (PST) Date: Thu, 8 Jan 2026 16:52:46 +0100 From: Petr Mladek To: Feng Tang Cc: Gal Pressman , Andrew Morton , linux-kernel@vger.kernel.org, Mark Bloch , Nimrod Oren Subject: Re: [PATCH] panic: only warn about deprecated panic_print on write access Message-ID: References: <20260106163321.83586-1-gal@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed 2026-01-07 15:20:44, Feng Tang wrote: > On Wed, Jan 07, 2026 at 08:41:22AM +0200, Gal Pressman wrote: > > On 07/01/2026 5:00, Feng Tang wrote: > > >> @@ -1014,7 +1015,6 @@ static int panic_print_set(const char *val, const struct kernel_param *kp) > > >> > > >> static int panic_print_get(char *val, const struct kernel_param *kp) > > >> { > > >> - panic_print_deprecated(); > > > > > > Actually this was intentional, in one of the patch version, this > > > panic_print_get() was not there but reusing the param_get_ulong(). > > > > > > It was added later as sometimes developer do want to runtime check > > > the current 'panic_print' setting through /sys/module/kernel/parameters/ > > > interface, and I thought it may be better to give the warning. > > > > I figured it would make sense to keep the behaviors consistent. I see. > When people run 'sysctl -a', in 99.9% cases, the users don't care > 'panic_print' or even don't know what 'panic_print' is, that's why > I think removing it makes sense. > > But for a user running 'cat /sys/module/kernel/parameters/panic_rint', > giving a warning is meaningful. Makes perfect sense. We need to make people aware that "panic_print" will eventually go away. 'sysctl -a' is different because it prints all values and there is big chance that the caller is not interested in "panic_print" at all. It makes sense to remove the warning from sysctl read. But I would keep it in sysfs read. Best Regards, Petr