From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 176652DECBD for ; Fri, 2 Jan 2026 11:38:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767353908; cv=none; b=bmCE1RHjGn+Dt+eOn31UeiZ3asbHkvjv3Ju/0iu1UsEX8hE/ebrnOki0I5FM81v6x2txw4CCd3RFZGRa5Kaei8NP0ziUoKG93qcx0ZnPAAEc9PY7xpTODr2B3r19YCHmlRgTog/KiXL2BNFtTnhQreH5mGdPSxKr4aUL/Bb2JoM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767353908; c=relaxed/simple; bh=rnW5GkAMZuPUJQWbiyetfXsLLkG1QwiCHbVg2xxlaVE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OReLfsVI7QVAD0QlLUzl2HGNc7Dmbdwsg/C9WP/lXcEbTH3VOiw0yRlzcBbBPRmTcvHhXT9XhyugrDWb+gF/cQVuAqQl1SL9typj7p9BnWKwZqLkM2XJ1UgF/zrSwvWJoz3i3OYYmru+NW7sx9aK4EMhKKdB7fu7LsCeF+Yh0B4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=d+ur0IpA; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="d+ur0IpA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1767353906; x=1798889906; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=rnW5GkAMZuPUJQWbiyetfXsLLkG1QwiCHbVg2xxlaVE=; b=d+ur0IpA1VeekQqDJCvvSVSz1xeOD7Zi6SjfeMZQpfe5F//eVzEosMtL VAEDFwIfDNUtbcAeaU4zyBC2D7PZ91/POIMkTDffKjiL7fcYrkMvfoKq9 UD2MEsGrEYbD7NY70y9HBm+ebV9yvzGUrUI3J6HiUsOixv0axA1uqffEu i24hq6L6NyBAI5DPjsb+I7BojFCyl4b7N8JNOXgdgltf9GnZNE8pCwr4U VZtnKwqj2yftCyw2ICblPk19nQeEDW4k1tXsVmNlDL/LfBnP6a/do0FEb D83HOB650mWQ32t5LHhLHN9J7blNyiGjLb8FY/onj4HVkVqWbXghSkLQb Q==; X-CSE-ConnectionGUID: QZ0hYigUQsGQF7gRX4+VyQ== X-CSE-MsgGUID: iiiAuBx1QnWeNRlHMMUmJA== X-IronPort-AV: E=McAfee;i="6800,10657,11658"; a="80293589" X-IronPort-AV: E=Sophos;i="6.21,197,1763452800"; d="scan'208";a="80293589" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2026 03:38:23 -0800 X-CSE-ConnectionGUID: BmaERz2xSWu6qUQyPgUSVg== X-CSE-MsgGUID: Dz1set7RSXSjlFmWkdTqcg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,197,1763452800"; d="scan'208";a="232495780" Received: from ncintean-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.46]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2026 03:38:20 -0800 Date: Fri, 2 Jan 2026 13:38:18 +0200 From: Andy Shevchenko To: Diederik de Haas Cc: Michael Wu , myungjoo.ham@samsung.com, cw00.choi@samsung.com, linux-kernel@vger.kernel.org, Dragan Simic , linux-rockchip@lists.infradead.org Subject: Re: [PATCH v3] extcon: Fixed sysfs duplicate filename issue Message-ID: References: <20251024024946.16618-1-michael@allwinnertech.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Tue, Dec 30, 2025 at 03:24:36PM +0100, Diederik de Haas wrote: > On Tue Dec 30, 2025 at 12:26 PM CET, Andy Shevchenko wrote: > > On Tue, Dec 30, 2025 at 12:31:17AM +0100, Diederik de Haas wrote: > >> On Sun Dec 28, 2025 at 6:26 PM CET, Andy Shevchenko wrote: > >> > On Sun, Dec 28, 2025 at 12:01:54PM +0100, Diederik de Haas wrote: > >> >> On Sat Dec 27, 2025 at 4:08 PM CET, Andy Shevchenko wrote: > >> >> > On Sun, Dec 21, 2025 at 03:01:11PM +0100, Diederik de Haas wrote: > >> >> >> On Fri Oct 24, 2025 at 4:49 AM CEST, Michael Wu wrote: > >> >> >> > With current extcon_dev_unregister() timing, ida_free is before > >> >> >> > device_unregister(), that may cause current id re-alloc to another > >> >> >> > device in extcon_dev_register() context but sysfs filename path not > >> >> >> > removal completed yet. > >> >> >> > >> >> >> I periodically get errors like this: > >> >> >> > >> >> >> [ 7.116152] rockchip-usb2phy fe8a0000.usb2phy: error -EEXIST: failed to register extcon device > >> >> >> [ 7.117005] rockchip-usb2phy fe8a0000.usb2phy: probe with driver rockchip-usb2phy failed with error -17 > >> >> >> > >> >> >> This was today on a NanoPi R5S (rk3568), but I have seen it before and > >> >> >> on multiple devices. They are all Rockchip based, but that's (quite) > >> >> >> possible because that's what I use the most (and where I pay quite a bit > >> >> >> of attention to dmesg). > >> >> >> > >> >> >> Slightly fuller dmesg output of the above error is here: > >> >> >> https://paste.sr.ht/~diederik/42c6b3405386c823cd9f837d73a9a32e810361be > >> >> >> And via 'journalctl' I hopefully got the full dmesg output: > >> >> >> https://paste.sr.ht/~diederik/7a6109115b1ad85290de482db091dad3759ec159 > >> >> >> > >> >> >> Here are 2 similar logs, this time on PineTab2 and Quartz64-A (both rk3566) > >> >> >> https://paste.sr.ht/~diederik/cfe606801d3dab0267bea7049687d24c0d6e8d71 > >> >> >> > >> >> >> Those are all the logs I have saved, but it has happened several times > >> >> >> besides that. But most times I just rebooted and didn't save the log. > >> >> >> Today I looked a bit further, found commit 7bba9e81a6fb, searched on > >> >> >> lore.k.o and found this patch. > >> >> >> > >> >> >> So I'm wondering whether this patch would also fix 'my' issue? > >> >> >> Or is this a different issue? > >> >> > > >> >> > But have you had a chance to test it? The code looks correct after this patch > >> >> > as the first we remove the struct device and all associated data (including > >> >> > sysfs nodes) and then remove the ID from the list. Without that there is a > >> >> > window to get the same id for the devices that is pending to be removed. > >> >> > >> >> I've build a kernel with it and it will be part of my kernels going > >> >> forward. But it can take many months before the issue shows up again. > >> >> So if I don't get it in a year, then I'm going to *assume* it's probably > >> >> fixed. > >> > > >> > I believe you may speed up the test case by creating two shell scripts that > >> > trying insmod / rmmod the same module in parallel. > >> > >> I checked on several devices and the phy_rockchip_inno_usb2 module is > >> used by various other modules on all of them, so I can't just 'rmmod' it. > >> I guess it should technically be possible to remove all its dependencies > >> and then remove that module. I don't know if my skills are sufficient > >> for that and it feels like I'm mostly testing the robustness of the USB > >> subsystem. > >> > >> As I regularly already get the following kernel warning > >> ``Warning! ehci_hcd should always be loaded before uhci_hcd and ohci_hcd, not after`` > >> which often results in USB 2 ports not working, I have my doubts about > >> the robustness anyway. > > > > This is interesting issue, have you reported it to USB people (such as Alan Stern)? > > Not yet. I was reasonably sure I had mentioned this issue before, but > when doing a search on lore.k.o I couldn't find it. I guess I only > 'reported' it on IRC. > > Interestingly enough, I did find another very recent mail/patch: > https://lore.kernel.org/all/20251230080014.3934590-1-chenhuacai@loongson.cn/ > > but looks like Greg doesn't like it ... and his suggestion (make the > kernel module built-in) was exactly the thing I wanted to try before > reporting it. If it's tristate it _should_ be able to be built as > module, but it's extremely unlikely I'll spend time on that though. Okay, it seems you engaged Alan into the discussion, so I leave it to that thread where all necessary stakeholders are present. > >> So I'll just keep an eye out if the ``sysfs: cannot create duplicate > >> filename`` error pops up again 'naturally' and report if/when it does. > > > > Good, please monitor it and try to collect logs for the further investigations, > > if required. > > Will do. FWIW, Dragan asked me to enable DEBUG_DEVRES and share the > logs. Maybe they're useful for you too. > On Rock 5B (RK3588): https://paste.sr.ht/~diederik/2d8e0beced6477cc1abd28cd870ea76a1e413a9e > On NanoPi R5S (RK3568): https://paste.sr.ht/~diederik/1c4026d0c277b92391136bab4e80f64a989006f5 I don't see any smoking gun there. -- With Best Regards, Andy Shevchenko